From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: taylanbayirli@gmail.com (Taylan Ulrich =?utf-8?Q?Bay=C4=B1rl=C4=B1?= =?utf-8?Q?=2FKammer?=) Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add shell-quasiquote. Date: Sat, 17 Oct 2015 20:11:05 +0200 Message-ID: <87y4f1v006.fsf@T420.taylan> References: <87si59wj42.fsf@T420.taylan> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1445105517 8131 80.91.229.3 (17 Oct 2015 18:11:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 17 Oct 2015 18:11:57 +0000 (UTC) Cc: emacs-devel To: Artur Malabarba Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 17 20:11:52 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZnVwo-0002yU-EY for ged-emacs-devel@m.gmane.org; Sat, 17 Oct 2015 20:11:14 +0200 Original-Received: from localhost ([::1]:59375 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnVwn-00041S-4Y for ged-emacs-devel@m.gmane.org; Sat, 17 Oct 2015 14:11:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnVwi-0003zj-NJ for emacs-devel@gnu.org; Sat, 17 Oct 2015 14:11:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZnVwh-0002si-TL for emacs-devel@gnu.org; Sat, 17 Oct 2015 14:11:08 -0400 Original-Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:36954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnVwh-0002se-NJ for emacs-devel@gnu.org; Sat, 17 Oct 2015 14:11:07 -0400 Original-Received: by wicfv8 with SMTP id fv8so29026980wic.0 for ; Sat, 17 Oct 2015 11:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=wGcCvZnE1S3eea0WqXEgc+onmMjUWkkZ96DlKaajdGY=; b=ukur9ddU3LZYhUfhP/d2fsdD6fbDSJldQ+vA80Y+hHwXfZq+tdULObMfO8JG3jRNPs 4ZimsaJLboHxwk3qRVGtOWXlj/KGeN3KXmkPPto8zzmqn+68hXjt8gae3vkjY+0L5BwR ++oOpVmWGALEvqCNHPza/xmyyMfKTYI+jVQVBCEid37Lr+xqFap+ytEq8/0GzyON8boE mL00K6Q9BoJ2yHf+GGcuUhSshLXAAIPULLE1WXnX224IjssfXd37QAWM+MLN7q5Z9TrJ SSkgSZ33Yw63XFe0DV9I8l8IhIB0CBBCaRzUPM9DY9YVAuxPfE0z2s12kNpsFKWNkSvo WoYA== X-Received: by 10.194.57.242 with SMTP id l18mr23668727wjq.34.1445105467147; Sat, 17 Oct 2015 11:11:07 -0700 (PDT) Original-Received: from T420.taylan ([2a02:908:c32:4740:221:ccff:fe66:68f0]) by smtp.gmail.com with ESMTPSA id fp4sm571659wib.24.2015.10.17.11.11.05 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Oct 2015 11:11:06 -0700 (PDT) In-Reply-To: (Artur Malabarba's message of "Sat, 17 Oct 2015 18:23:04 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:191868 Archived-At: Artur Malabarba writes: > + (if (and (consp form) > + (eq '\, (car form)) > + (consp (cdr form)) > + (null (cddr form))) > + (cadr form))) > > There's nothing wrong with this code. But, just FYI, here's what it > would look like with pcase (assuming I didn't mess up writing this on > my phone). > > (pcase form > ((`\, x) x)) As pointed out somewhere else in the code: ;; We use the match-comma helpers because pcase can't match ,foo. Taylan