From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#6259: 24.0.50; `uniquify.el' advises `create-file-buffer' Date: Sun, 01 May 2016 19:53:00 +0200 Message-ID: <87y47tzmv7.fsf@gnus.org> References: <87ob2fhctp.fsf@building.gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1462125292 30726 80.91.229.3 (1 May 2016 17:54:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 May 2016 17:54:52 +0000 (UTC) Cc: 6259@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 01 19:54:39 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1awvZm-00056X-RH for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 May 2016 19:54:38 +0200 Original-Received: from localhost ([::1]:33810 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awvZj-0007ny-66 for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 May 2016 13:54:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awvZa-0007cX-1l for bug-gnu-emacs@gnu.org; Sun, 01 May 2016 13:54:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awvZF-0001kp-4y for bug-gnu-emacs@gnu.org; Sun, 01 May 2016 13:54:20 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awvZF-0001iP-1D for bug-gnu-emacs@gnu.org; Sun, 01 May 2016 13:54:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1awvZB-0005u1-Ks for bug-gnu-emacs@gnu.org; Sun, 01 May 2016 13:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 May 2016 17:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6259 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 6259-submit@debbugs.gnu.org id=B6259.146212519322624 (code B ref 6259); Sun, 01 May 2016 17:54:01 +0000 Original-Received: (at 6259) by debbugs.gnu.org; 1 May 2016 17:53:13 +0000 Original-Received: from localhost ([127.0.0.1]:60940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awvYM-0005sk-1S for submit@debbugs.gnu.org; Sun, 01 May 2016 13:53:13 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:40162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awvYH-0005sZ-75 for 6259@debbugs.gnu.org; Sun, 01 May 2016 13:53:08 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1awvYC-0000oy-IO; Sun, 01 May 2016 19:53:04 +0200 In-Reply-To: <87ob2fhctp.fsf@building.gnus.org> (Lars Ingebrigtsen's message of "Sun, 09 Feb 2014 19:21:54 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117530 Archived-At: Lars Ingebrigtsen writes: > And since uniquify is the default now, it should probably be fixed: > > -------- > > create-file-buffer is a compiled Lisp function in `files.el'. > > (create-file-buffer ARG1) > > :around advice: `uniquify--create-file-buffer-advice' > > -------- And amusingly enough, there's this comment in the file: ;; The below solution works because generate-new-buffer-name is called ;; only by rename-buffer (which, as of 19.29, is never called from C) and ;; generate-new-buffer, which is called only by Lisp functions ;; create-file-buffer and rename-uniquely. This isn't... er... very true any more. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no