all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Marcin Borkowski <mbork@mbork.pl>
To: John Mastro <john.b.mastro@gmail.com>
Cc: Help Gnu Emacs mailing list <help-gnu-emacs@gnu.org>,
	Oleh Krehel <ohwoeowho@gmail.com>,
	Kaushal Modi <kaushal.modi@gmail.com>
Subject: Re: Any infrastructure to select one of a few options in Emacs core?
Date: Sat, 21 May 2016 22:48:14 +0200	[thread overview]
Message-ID: <87y473rvch.fsf@mbork.pl> (raw)
In-Reply-To: <CAOj2CQS827bMSiiMLGce8mVH-Mg3Vs=85vr0_VdiHbbvxmu8Lw@mail.gmail.com>


On 2016-05-21, at 01:52, John Mastro <john.b.mastro@gmail.com> wrote:

> John Mastro <john.b.mastro@gmail.com> wrote:
>
>> I played around with a few cosmetic changes to your function and ended
>> up with this:
>
> I realized that, for my use case, it makes more sense to let the caller
> specify the characters rather than automatically using the digits 1-9.
> So I ended up with this instead, which is also a bit shorter and
> simpler.
>
> (defun read-choice (prompt choices)
>   (let ((cursor-in-echo-area t)
>         (prompt (if (get-text-property 0 'face prompt)
>                     prompt
>                   (propertize prompt
>                               'face
>                               'minibuffer-prompt))))
>     (save-window-excursion
>       (pop-to-buffer " *Read choice*" t t)
>       (setq-local cursor-type nil)
>       (erase-buffer)
>       (pcase-dolist (`(,char ,description) choices)
>         (insert (propertize (string char)
>                             'face
>                             'font-lock-variable-name-face)
>                 (format " %s\n" description)))
>       (goto-char (point-min))
>       (fit-window-to-buffer)
>       (or (assoc (read-key prompt) choices)
>           (user-error "Invalid selection")))))

Nice, thanks!  I didn't know about several things you used here - every
day is an opportunity to learn!  (I'll finally have to read about pcase,
too.)  I like especially the `fit-window-to-buffer' function - it seems
it's exactly what I needed, much better than my `delete-other-windows'!

Also, it seems you don't need `setq-local' here, since `cursor-type' is
automatically buffer-local anyway.

> In Emacs's master branch (but not the emacs-25 release branch) there's a
> new function `read-multiple-choice' that's similar in purpose and worth
> a look.

Yes, I've seen that.  Not useful for me, though -- in my use case the
descriptions of the choices are too long (maybe even several lines!).

>         John

Best,

-- 
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University



  reply	other threads:[~2016-05-21 20:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-09 10:09 Any infrastructure to select one of a few options in Emacs core? Marcin Borkowski
2016-05-09 14:13 ` Drew Adams
2016-05-09 15:40   ` Marcin Borkowski
2016-05-09 16:37     ` Kaushal Modi
2016-05-09 17:10       ` Marcin Borkowski
2016-05-09 17:27         ` Drew Adams
2016-05-09 18:08           ` Marcin Borkowski
2016-05-09 18:16             ` Drew Adams
2016-05-19 20:06               ` Marcin Borkowski
2016-05-20  1:16                 ` John Mastro
2016-05-20 23:52                   ` John Mastro
2016-05-21 20:48                     ` Marcin Borkowski [this message]
2016-05-09 18:36             ` Pascal J. Bourguignon
2016-05-14  4:20               ` Emanuel Berg
2016-05-21 20:49               ` Marcin Borkowski
2016-05-14  4:18 ` Emanuel Berg
2016-05-21 20:52   ` Marcin Borkowski
     [not found]   ` <mailman.43.1463863961.1216.help-gnu-emacs@gnu.org>
2016-05-22  6:32     ` Emanuel Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y473rvch.fsf@mbork.pl \
    --to=mbork@mbork.pl \
    --cc=help-gnu-emacs@gnu.org \
    --cc=john.b.mastro@gmail.com \
    --cc=kaushal.modi@gmail.com \
    --cc=ohwoeowho@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.