From: Stephen Berman <stephen.berman@gmx.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 23695@debbugs.gnu.org
Subject: bug#23695: 25.0.94; todo-mode breaks minibuffer-complete-word
Date: Fri, 10 Jun 2016 12:36:20 +0200 [thread overview]
Message-ID: <87y46dwct7.fsf@gmx.net> (raw)
In-Reply-To: <83h9d1pcs7.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 Jun 2016 13:18:48 +0300")
On Fri, 10 Jun 2016 13:18:48 +0300 Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Stephen Berman <stephen.berman@gmx.net>
>> Date: Fri, 10 Jun 2016 11:28:14 +0200
>>
>> On Sun, 05 Jun 2016 11:18:46 +0200 Stephen Berman <stephen.berman@gmx.net> wrote:
>>
>> > 0. emacs -Q
>> > 1. Sanity check: Typing e.g. `C-h f url- SPC' should pop up a
>> > *Completions* buffer showing functions beginning with "url-", since
>> > SPC in the minibuffer is bound to minibuffer-complete-word.
>> > 2. C-g to exit the minibuffer, then, if you have no files made by
>> > todo-mode (i.e. no directory ~/.emacs.d/todo), type `M-x todo-show
>> > RET RET RET RET RET' (accepting defaults) to create a todo file with
>> > a category and an entry.
>> > 3. Type `q' to quit todo-mode (optional) and redo step 1.
>> > => Upon typing SPC this time, instead of getting the *Completions*
>> > buffer, a space is inserted in the minibuffer after "url-".
>> >
>> > If at step 2 you already have one or more todo-files, then invoking a
>> > number of todo-mode commands, e.g. `j' to jump to another category or
>> > `C a' to add a new category, will likewise globally change the effect of
>> > all subsequent uses of SPC in the minibuffer.
>> >
>> > The patch below fixes this. I request approval to push this fix to
>> > emacs-25, since without it, todo-mode-specific behavior changes the
>> > minibuffer behavior in rest of Emacs. Also, the fix is certainly safe,
>> > since it replaces naively implemented functionality by canonical code to
>> > temporarily change a minibuffer key binding.
>>
>> Ping! Any objections to pushing this fix to emacs-25?
>
> We've lived with this for the last 2 years, how come it's so urgent
> now?
It's no more urgent now than it was two years ago, it's just that I only
discovered it now. And again, the bug not only affects todo-mode but
completion throughout Emacs. Admittedly, the intersection of those who
regularly use both todo-mode and minibuffer-complete-word is probably
very small (possibly empty), but still, why release with a known bug
when the fix is obvious and obviously safe? Or do you think it isn't?
Steve Berman
next prev parent reply other threads:[~2016-06-10 10:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-05 9:18 bug#23695: 25.0.94; todo-mode breaks minibuffer-complete-word Stephen Berman
2016-06-10 9:28 ` Stephen Berman
2016-06-10 10:18 ` Eli Zaretskii
2016-06-10 10:36 ` Stephen Berman [this message]
2016-06-14 17:05 ` Eli Zaretskii
2016-06-14 21:46 ` Stephen Berman
2016-06-29 9:52 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y46dwct7.fsf@gmx.net \
--to=stephen.berman@gmx.net \
--cc=23695@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.