all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: larsi@gnus.org, emacs-devel@gnu.org
Subject: Re: debbugs-gnu-bugs shows unanswered bugs as handled
Date: Sat, 11 Jun 2016 19:56:21 +0200	[thread overview]
Message-ID: <87y46bmwxm.fsf@gmx.de> (raw)
In-Reply-To: alpine.LRH.2.20.1606082227310.22595@calancha-ilc.kek.jp

Tino Calancha <tino.calancha@gmail.com> writes:

Hi Tino,

> I have found 2 more issues code (added patches at the end of the email).
>
> I)
>    I have noticed the code uses the attributes 'submitter and 'author
>    as synonymous: tipically they have same value but not always.

>    For instance try folowing example:
>
> [OK]
> M-x debbugs-gnu-search RET
> nuisance AND asked RET RET
> ;; list bugs: 19328, 23680
>
> [BAD]
> M-x debbugs-gnu-search RET
> nuisance AND asked RET submitter camdez@gmail.com RET RET
> ;; Don't show bugs because author and submitter are not equivalent;
> ;; for instance, in bug#19328, the submitter is camdez@gmail.com
> ;; but the author is drew.adams@oracle.com.

You are right. `debbugs-search-est' expects :@author, and not
:submitter. I've modified your patch slightly, and we get now

M-x debbugs-gnu-search RET
nuisance AND asked RET RET
;; List bugs: 19328, 23680

M-x debbugs-gnu-search RET
nuisance AND asked RET author drew.adams@oracle.com RET RET
;; List bugs: 19328. There was another error, encoding "@" for the
;; Debbugs::SOAP Perl module, which I have also fixed.

> II)
>    I guess attribute 'status should be handled also in the client side.
>
>    See for instance,
>
> [BAD]
> (setq debbugs-gnu-default-suppress-bugs nil) ; show bugs with status "done"
> M-x debbugs-gnu-search RET
> nuisance AND asked RET status done RET RET
> ;; Don't show any bug

That's not possible. Status is applicable for server-side filtering only
with a non-empty phrase. I've fixed this.

Client-side filtering is applied only for searches with an empty
phrase. Your use case is not foreseen (yet).

In general, client-side filtering should not promoted to the users. It
has bad performance, because it needs to retrieve all bugs first, before
it could start to filter. It's always better to promote server-side
filtering.

> There is other uses of :submitter on that file (e.g. debbugs-get-bugs);
> i am wondering if they also need to be fixed (i didn't look on it).

Haven't looked either, but it shall be OK.

> Regards,
> Tino

Best regards, Michael.



      reply	other threads:[~2016-06-11 17:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-04  4:10 debbugs-gnu-bugs shows unanswered bugs as handled Tino Calancha
2016-06-04  8:25 ` Michael Albinus
2016-06-05 14:50   ` Tino Calancha
2016-06-05 15:29     ` Michael Albinus
2016-06-08 13:29       ` Tino Calancha
2016-06-11 17:56         ` Michael Albinus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y46bmwxm.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.