From: Mario Lang <mlang@delysid.org>
To: emacs-devel@gnu.org
Subject: [elpa] packages/rudel/rudel-display.el:40:1:Error: eieio-oref called on a class: rudel-backend-factory
Date: Sun, 10 Jul 2016 22:14:15 +0200 [thread overview]
Message-ID: <87y459l088.fsf_-_@fx.delysid.org> (raw)
In-Reply-To: <m3inwdbgyn.fsf@fitzsim.org> (Thomas Fitzsimmons's message of "Sun, 10 Jul 2016 12:22:56 -0400")
Hi.
Now that fsm.el has been fixed (thanks), the elpa elc build fails in the rudel
package.
The problem seems to be in `eieio-oref' which looks a bit strange to me:
(defun eieio-oref (obj slot)
"Return the value in OBJ at SLOT in the object vector."
(declare (compiler-macro
(lambda (exp)
(ignore obj)
(pcase slot
((and (or `',name (and name (pred keywordp)))
(guard (not (memq name eieio--known-slot-names))))
(macroexp--warn-and-return
(format-message "Unknown slot `%S'" name) exp 'compile-only))
(_ exp)))))
(cl-check-type slot symbol)
(cl-check-type obj (or eieio-object class))
(let* ((class (cond ((symbolp obj)
(error "eieio-oref called on a class: %s" obj)
(let ((c (cl--find-class obj)))
(if (eieio--class-p c) (eieio-class-un-autoload obj))
c))
(t (eieio--object-class obj))))
(c (eieio--slot-name-index class slot)))
...))
I have to admit that I don't grok eieio, but this piece of code looks
suspicious. Wouldn't the code after the `error' call be dead?
On a somewhat related note, package rudel could use a port to cl-lib and
cl-generic. Would that be a worthwhile change to make?
--
CYa,
⡍⠁⠗⠊⠕
next prev parent reply other threads:[~2016-07-10 20:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 10:56 [elpa] excorporate.el:257:23:Error: Wrong type argument: listp, start-exco--fsm Mario Lang
2016-07-08 18:34 ` Paul Eggert
2016-07-08 20:12 ` Thomas Fitzsimmons
2016-07-10 13:08 ` Mario Lang
2016-07-10 14:26 ` Stefan Monnier
2016-07-10 15:17 ` Thomas Fitzsimmons
2016-07-10 15:20 ` Stefan Monnier
2016-07-10 15:28 ` Stefan Monnier
2016-07-10 16:22 ` Thomas Fitzsimmons
2016-07-10 20:14 ` Mario Lang [this message]
2016-07-10 21:27 ` [elpa] packages/rudel/rudel-display.el:40:1:Error: eieio-oref called on a class: rudel-backend-factory Stefan Monnier
2016-07-10 22:19 ` Stefan Monnier
2016-07-12 21:52 ` Mario Lang
2016-07-10 13:08 ` bug#23920: [elpa] excorporate.el:257:23:Error: Wrong type argument: listp, start-exco--fsm Mario Lang
2016-07-10 16:24 ` Thomas Fitzsimmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y459l088.fsf_-_@fx.delysid.org \
--to=mlang@delysid.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.