From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#26126: 26.0.50; file-notify-rm-watch removes arbitrary watches Date: Sat, 18 Mar 2017 20:36:51 +0100 Message-ID: <87y3w2gywc.fsf@detlef> References: <87r31x9ulw.fsf@luca> <87shmcney8.fsf@detlef> <87efxw7xvc.fsf@luca> <87mvcjophx.fsf@detlef> <87tw6rssoi.fsf@luca> <87pohfkmvh.fsf@detlef> <87lgs2sobr.fsf@luca> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1489865835 4756 195.159.176.226 (18 Mar 2017 19:37:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 18 Mar 2017 19:37:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 26126@debbugs.gnu.org To: Andreas Politz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 18 20:37:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpK9y-0000NW-Vs for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Mar 2017 20:37:07 +0100 Original-Received: from localhost ([::1]:54501 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpKA5-00042G-13 for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Mar 2017 15:37:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpK9y-00041C-ED for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2017 15:37:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cpK9u-0002Bg-GX for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2017 15:37:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36131) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cpK9u-0002BN-DR for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2017 15:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cpK9u-0007rp-7e for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2017 15:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Mar 2017 19:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26126 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26126-submit@debbugs.gnu.org id=B26126.148986582130237 (code B ref 26126); Sat, 18 Mar 2017 19:37:02 +0000 Original-Received: (at 26126) by debbugs.gnu.org; 18 Mar 2017 19:37:01 +0000 Original-Received: from localhost ([127.0.0.1]:34330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpK9t-0007rZ-93 for submit@debbugs.gnu.org; Sat, 18 Mar 2017 15:37:01 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:60039) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpK9q-0007rI-Tq for 26126@debbugs.gnu.org; Sat, 18 Mar 2017 15:36:59 -0400 Original-Received: from detlef.gmx.de ([87.146.40.245]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MDFB2-1czGJs0jdM-00GY0i; Sat, 18 Mar 2017 20:36:52 +0100 In-Reply-To: <87lgs2sobr.fsf@luca> (Andreas Politz's message of "Sat, 18 Mar 2017 14:32:08 +0100") X-Provags-ID: V03:K0:4xCEiI1Q/p5V1yD2wH/uur8DHv3nh+IYnpUG+GxYcqMWZP3+/tf ajKRqjiR/w+wPPRmfRwuAao/QwecUO2JnDeY+acSqWtWXUF+3PjTRu/ZM5l+ncqpYGympjH GR0q5N+aVdHnC4ueUmJVM86bZG1w8Hc/cLhAWEgDOI8fGecY6AP2woDrDQihRv1gDKWE0jI hZn+odSTnphMegWcwCauQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:mgqK2vN+BUM=:0UVy6nYmHGqv0K97iltyR0 mhsBvVZne4ys8gBD8nPP+WM7HEOdVs0jHk6HsLCxH7wRwI3n4M2whgyj21jDJIuyO9yBPAtq8 WkCIjb9dIw354LvCaOOPuoSnMY5PBhV9REcuI+vGRWiEsvFrTU1tXMgiS+gW9UBae4cXETfDV tUyERdEgV1Tw2CE4KsjCM4w0uUCK0C4x9HgE7BQaisDl0NtKLJaLXJYNObjRnXFtgoym9VWZm WGEAUUWHVnDEAimarI93XoV9uhwVsHHOtS3mT0uxMBKyJzkGkECIAmrTha/1UlwpAhSQnsAiM Uu/GuY99Vm1toTudE2ppkMTIgnnX44sDMrQbvoS0Zw6biePrYGKgrcztOvCukhFfngBAHkBMV Jz76lSnwai+21FoRZh3yN0QgrLC6fo2EkYveVC+BztekO+a4mPISlONDg6d9ZMJrh4psZf0nF RwPYhUxF9Ko5mEed+Ip0pZ1cH+4Zo7J+NK5JxaIkf3yiBfHfEvkIarsdORif+iu4VjlP8GRnH /UUbxxn+wX7aRsyRZc+XPtL6EwtgDWkLIJL3eH8NjNgDLDKfCicqCi97AuZdslYMrQ5HZJr5n GdtvJqRejB1SekXAXkf6LUXGutEiS2XCQKt93jioT9QTiDQOnCHwSEVJFQIgsAjc4EdJ3j8mw jqDoVUwMbnP8RgqiDC+uEt0tdZv/6XWtY9xPH9NU+gSwoD8TsbZ7EUHpO5RzDkU1QStZ432/s SMLUvslfpIEI7SRV229o31FbEUjWRmu0SktT+XvcJI2ZOvpMRBfypGaRMyKtFc7Uc9RsoOub X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130714 Archived-At: Andreas Politz writes: Hi Andreas, > I took a deeper look filenotify.el and found some problems/have some > further questions. Note that I use inotify. > > + A watched hard-link for some other file may not receive its events, > due to string-equal being used for file-comparisons. Shouldn't > file-equal be used instead ? How does inotify (and the other libraries) work in this case? Does it support hard links? We should not add more logic than the native libraries offer. > + Watching a /dir/file may receive events (e.g. touch /dir) for dir. Could you pls give an example? > + Why the seemingly arbitrary exclusion of backup-files in > file-notify-callback ? What if someone wants to track the creation of > said files ? When a file under supervision is renamed during backup, the supervision might be stopped. This case must be handled. > + Why is the existence of kqueue checked for the handler in > file-notify-add-watch ? After all we don't know how this handler will > operate. Why don't we know what kqueue does? > -ap Best rewgards, Michael.