From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: master bd60ee2 1/5: auth-source: factor out parsers and add tests Date: Fri, 28 Apr 2017 13:12:23 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87y3uklamg.fsf@lifelogs.com> References: <20170427213824.12196.63777@vcs0.savannah.gnu.org> <20170427213827.B6BDC22040@vcs0.savannah.gnu.org> <5ro9vgebfr.fsf@fencepost.gnu.org> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1493399565 21146 195.159.176.226 (28 Apr 2017 17:12:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 28 Apr 2017 17:12:45 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 28 19:12:41 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d49Re-0005LJ-AZ for ged-emacs-devel@m.gmane.org; Fri, 28 Apr 2017 19:12:38 +0200 Original-Received: from localhost ([::1]:38097 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d49Rk-0005B3-4I for ged-emacs-devel@m.gmane.org; Fri, 28 Apr 2017 13:12:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d49Rd-00057m-HH for emacs-devel@gnu.org; Fri, 28 Apr 2017 13:12:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d49RZ-0006VG-Hc for emacs-devel@gnu.org; Fri, 28 Apr 2017 13:12:37 -0400 Original-Received: from [195.159.176.226] (port=45291 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d49RZ-0006V5-Bg for emacs-devel@gnu.org; Fri, 28 Apr 2017 13:12:33 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1d49RQ-000525-HK for emacs-devel@gnu.org; Fri, 28 Apr 2017 19:12:24 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 31 Original-X-Complaints-To: usenet@blaine.gmane.org X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Cancel-Lock: sha1:rT4vwp46SLFUbeDPs9fTatgl67s= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214395 Archived-At: On Fri, 28 Apr 2017 12:36:40 -0400 Glenn Morris wrote: GM> Ted Zlatanov wrote: >> What breaks, and how should I have caught this problem before it was >> comitted? GM> You could have run "make check", to see a bunch of test failures due to GM> "return" being void. GM> I can't resist pointing out that this was flagged by GM> http://hydra.nixos.org/build/52055147 Huh. Thanks for the pointer. I'm glad you didn't resist. But I didn't see that failure on my system: SUMMARY OF TEST RESULTS ----------------------- Files examined: 154 Ran 2250 tests, 2233 results as expected, 17 skipped So my "make check" doesn't flag that `return' as a void-function, and the warning during compilation that Stefan pointed out is easy to miss. Hydra may be doing something differently to catch this? Stefan fixed it this morning by using `cl-return' and `cl-dolist' instead, which is great, but I'd like to make sure I don't break the build again. What am I missing in my test process? Thanks Ted