From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Nicolas Petton Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Make eshell =?utf-8?B?4oCYbHPigJk=?= output clickable. Date: Fri, 07 Jul 2017 17:08:47 +0200 Message-ID: <87y3s0s2rk.fsf@petton.fr> References: <595e6b24.c39f620a.f530.2881@mx.google.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Trace: blaine.gmane.org 1499440144 27931 195.159.176.226 (7 Jul 2017 15:09:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 7 Jul 2017 15:09:04 +0000 (UTC) To: Matthew Bauer , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 07 17:09:00 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTUsI-0006nE-36 for ged-emacs-devel@m.gmane.org; Fri, 07 Jul 2017 17:08:54 +0200 Original-Received: from localhost ([::1]:57017 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTUsN-0004SJ-Ks for ged-emacs-devel@m.gmane.org; Fri, 07 Jul 2017 11:08:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTUsG-0004QM-53 for emacs-devel@gnu.org; Fri, 07 Jul 2017 11:08:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTUsF-0006wG-7Q for emacs-devel@gnu.org; Fri, 07 Jul 2017 11:08:52 -0400 Original-Received: from [2a00:5884:8368::42] (port=60198 helo=petton.fr) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dTUsE-0006vq-Tj for emacs-devel@gnu.org; Fri, 07 Jul 2017 11:08:51 -0400 In-Reply-To: <595e6b24.c39f620a.f530.2881@mx.google.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=petton.fr; s=mail; t=1499440128; bh=7Yhk03zT6WT1qHZIKFkOgHjc8R5QtFzi3j0uM6AtT0g=; h=From:To:Subject:In-Reply-To:References:Date:Message-ID:MIME-Version:Content-Type; b=uKyT4o8Vn/6INUo35c4QQavTQbRUbXQ+Z6qYCRiLsDe3pDDlHoD2TXQximtDGt3l2/p99wec9M/PMGW69jy5k3ar6uM3UuM9nkUpMhOte71koMcHr6zxWzbdChrpnmc4cCQILCL1Uj/ARn/NqWm6uG9oyv02p4lEcPUVQiWzSN0= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:5884:8368::42 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216274 Archived-At: --=-=-= Content-Type: text/plain Matthew Bauer writes: Hi Matthew, Thanks for the patch! > It's debatable whether this is should be included in Eshell because it > can fairlhy easily be provided with advising (see link below). My > opinion, though, is that it's a fairly useful feature with fairly > little cost and gives Eshell a more Dired-like feel. I like the feature, I've been using something similar for a long time. I would even enable it by default, as I don't see any downside of doing so. I've commented the patch below: > +(defun eshell-ls-find-file-at-point (point) The function name suggests that this function finds a file based on the current position of the point, so I would remove the POINT argument, change `(interactive "d")' to `(interactive)', and use the `point' function. > + "RET on Eshell's `ls' output to open files. > +POINT is the point that the file is available at." The function does not bind `RET', as the docstring suggests. Cheers, Nico --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJZX6P/AAoJECM1h6R8IHkQxPEH/21nSLLJ2k88xkE0jhINYxbw 6oyTlSJfSWcNbGDo2wtDchKEk7/W0y0FDcsO29I4nx9ZKIjf4f6rk4Da5vmY5k0i eKEnRqFxYWNbDxnDJg4UaNrgWd3XHV5wYs4c6idqVdP8QDPnVHNzP2Qn0kyRVXK2 LobsEKsv8RlFApH5WMZJi7cOQAIC24wNL/Vzf+b/bnwJpNzrwegV1v9HuYsMFdZ+ X/mwlc1R2nfemrfL/qcuR24wZ5hv4J/44b21g1D05fPFXm5P88lIOdhAHw18rKsS csOhkPzu47KxsUErwT6xU55eW0/2JzbnEqcjmozBRtHzN7AOAkI8z/kK45yiXxc= =k1wv -----END PGP SIGNATURE----- --=-=-=--