From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Newsgroups: gmane.emacs.bugs Subject: bug#27890: 26.0.50; describe-font does not use Help buffer history Date: Sat, 05 Aug 2017 21:24:03 -0600 Message-ID: <87y3qxv0oc.fsf@lylat> References: <87ini8b8oz.fsf@lylat> <877eyhwr7q.fsf@lylat> <8760e15ywe.fsf@users.sourceforge.net> <873795wj2a.fsf@lylat> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1501989925 5783 195.159.176.226 (6 Aug 2017 03:25:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 6 Aug 2017 03:25:25 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 27890@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 06 05:25:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1deCBi-0000Yj-Hp for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Aug 2017 05:25:10 +0200 Original-Received: from localhost ([::1]:59579 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1deCBn-00066K-6H for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Aug 2017 23:25:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1deCBf-00062g-Eb for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2017 23:25:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1deCBa-00063B-Fe for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2017 23:25:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41289) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1deCBa-000635-BL for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2017 23:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1deCBa-0006rl-48 for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2017 23:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Aug 2017 03:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27890 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27890-submit@debbugs.gnu.org id=B27890.150198985526330 (code B ref 27890); Sun, 06 Aug 2017 03:25:02 +0000 Original-Received: (at 27890) by debbugs.gnu.org; 6 Aug 2017 03:24:15 +0000 Original-Received: from localhost ([127.0.0.1]:43966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1deCAo-0006qc-QJ for submit@debbugs.gnu.org; Sat, 05 Aug 2017 23:24:14 -0400 Original-Received: from mail-it0-f46.google.com ([209.85.214.46]:37616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1deCAn-0006qP-2g for 27890@debbugs.gnu.org; Sat, 05 Aug 2017 23:24:13 -0400 Original-Received: by mail-it0-f46.google.com with SMTP id v127so22734444itd.0 for <27890@debbugs.gnu.org>; Sat, 05 Aug 2017 20:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=80LqA046dUhyh5wdEDQ/fHFrD1loBWv6THUA51Xund4=; b=mC3O9slh9Lut3xN5JTG39iHRtHpsc/OdDVciGtoMTNitTe8r9wnJVCiG143QZaI0OR +Jqy364uKvubbfIh3FVg9R0wFgawmMCsgsCoJ+A5llCU+2P0kT05ioPyixLJkZFhcwWf ppE8N+n35PaGn1ti808hrl8MX+GoldC997syEezbKNsRlN7Sn2YzuzM0nyhVpa55luMp r1QJQUAUplMmGr27ScheNuxu4sCW8n/BRqXC8ZCrWj/9rV5846dDiZFPYtjG9se362sj 7WUycRnv3csfhP896YAJfQ4w8JESbR6TEfGuz47e6F16DEgSlS39Phl53PJA4vsDQSpn +cqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=80LqA046dUhyh5wdEDQ/fHFrD1loBWv6THUA51Xund4=; b=Lx0d1/zpjhmNj6TFTtqEs3XEMa1EJzlp4bAr114uxqvaXNXIIhJGw6GzijYGNmMb9A KSYrScGZ8KyHaai/1f/zcnulfxoqyf7aJ9DY7lM7aLZ5McRRm2j6Q9uu83Y8omZ/7BOV LHhm6Ft2/thTsRPOxR5m/fzcoMMG3t9kLmKkxGM9oaeZGHXm5G5vnsRY+KG3ikedtC1n zLhWKn5Qo5OE6oIBeTHBoDye33x1ceAUtzFqzzS22XEyGmh5S1XyLi9rUiddDPEGLCrq Wa70Ht1nLDpri5uvfqa2Q6wvopHJbCej7sxa4Qr/KH/0L3wZ1XeeglHZKL9lBE7+ksha sGhA== X-Gm-Message-State: AHYfb5iX6dhNazg6ImLMdzW4CeV+izai28oyi7887FnqZLczRdpL2N6Y eMX9hMr5uu4Rh5Bu X-Received: by 10.36.250.129 with SMTP id v123mr7821397ith.17.1501989847272; Sat, 05 Aug 2017 20:24:07 -0700 (PDT) Original-Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id z12sm1993634ioe.83.2017.08.05.20.24.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 05 Aug 2017 20:24:06 -0700 (PDT) In-Reply-To: <873795wj2a.fsf@lylat> (Alex's message of "Sat, 05 Aug 2017 20:01:33 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135468 Archived-At: Alex writes: > npostavs@users.sourceforge.net writes: > >> tags 27890 + patch >> quit >> >> Alex writes: >> >>> Here's a patch for it. >>> >>> + (let ((xref-item (list #'describe-font fontname)) >> [...] >>> + (help-setup-xref xref-item (called-interactively-p 'interactive)) >> >> Looks fine, personally I wouldn't bother introducing that local >> variable. > > I introduced that variable because the procedure conditionally sets > fontname if it's an empty sequence. As it stands, the procedure would > error without capturing that variable ahead of time due to `length' being > called on a font object. > > I figured this was the simplest way around that problem. Do you have an > easier way in mind? I could perhaps change the setq line to instead set > fontname to (face-attribute 'default :family), which would allow for > removing the local variable safely. I made a patch that does this, but it doesn't behave exactly the same. (font-info (face-attribute 'default :family)) for me returns a font with size/height 16/19, but (font-info (face-attribute 'default :font)) returns a font with size/height 15/18. I've tried this with multiple fonts, and it happens with each one. This seems like a bug.