From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#22819: 25.0.91; Don't try to indent region if the buffer is read-only Date: Tue, 08 Aug 2017 09:15:34 -0400 Message-ID: <87y3qu2oax.fsf@users.sourceforge.net> References: <87vam26amc.fsf@users.sourceforge.net> <83lgmywlo4.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1502198134 23108 195.159.176.226 (8 Aug 2017 13:15:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 8 Aug 2017 13:15:34 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 22819@debbugs.gnu.org To: Kaushal Modi Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 08 15:15:19 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1df4Ln-0004zq-0b for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Aug 2017 15:15:11 +0200 Original-Received: from localhost ([::1]:42559 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1df4Ls-0005vP-Qg for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Aug 2017 09:15:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1df4Li-0005pD-Uc for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2017 09:15:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1df4Le-0003Y5-3d for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2017 09:15:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42477) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1df4Le-0003Xw-0d for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2017 09:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1df4Ld-0004y8-Ld for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2017 09:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Aug 2017 13:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22819 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22819-submit@debbugs.gnu.org id=B22819.150219804519008 (code B ref 22819); Tue, 08 Aug 2017 13:15:01 +0000 Original-Received: (at 22819) by debbugs.gnu.org; 8 Aug 2017 13:14:05 +0000 Original-Received: from localhost ([127.0.0.1]:51157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1df4Kj-0004wV-Gb for submit@debbugs.gnu.org; Tue, 08 Aug 2017 09:14:05 -0400 Original-Received: from mail-it0-f67.google.com ([209.85.214.67]:33263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1df4Ki-0004vw-Dw for 22819@debbugs.gnu.org; Tue, 08 Aug 2017 09:14:04 -0400 Original-Received: by mail-it0-f67.google.com with SMTP id m34so2563025iti.0 for <22819@debbugs.gnu.org>; Tue, 08 Aug 2017 06:14:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=3uEZBZdICucuUwSFcST3vjUcVUOs6foYmJneLK6yB80=; b=dkB2cCY+jvYW6Bz9o5L/J+gRptfpMzaujPqK5lGfDNLolL3Exyjxt9dWOtF7/85bkZ E3tREg2HXPG8wMBtWAa4mh3qcPDhXuWUbqKa2Z1ZSOmlxEI0eo+WrZl7fYYs/e4jCQh7 p9BB8a9kr7JBumN43vpss2aX511g3hHIS1R84k6KMsBP/GPWaIO5A+6TT75RJ0whDr6d Olf9Bd/nDMQC5rKm4L4FGv3DSNcU/elR6orD420Eezv6B8gW97e6o0mI2ab79ZOApE+n QmQ+3Te8vR8b0uAzWTCvzokNuzwKFuZRsdgICYJD3Lw0f/Ztf6DVXgMnWlW0+BMuI6u1 OlAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=3uEZBZdICucuUwSFcST3vjUcVUOs6foYmJneLK6yB80=; b=kQn2f1gte58OUBXqE2uFqrgkkuGKjToYmkBtI77bOEeD+V2Cqsn3PDPKgKZgccF+pC p9VFfOTGCpnQGbSTFbUimolP8j2Okmm+xOA4eE4qCA451lrqhoijX53fuDFvj79KiSr8 TiGYTJ4xFDG0AOSWCxAFoGP2D8DcnTHjCcO6cL2O6umSY44NWmUwkmjJ4dAfriM6LCm3 kAhVA/RASkcEC2YmTwp5WZk4XWOa00z7jPOzgEbKqrrfs1tOKITjXsWdxODS1z1t3njv twIbgSv7eLR0fwc809MfPC2M/EnHurYyk3MJL84LENicLFJ1i06xx7ZGa3842pA5H7Y1 z69A== X-Gm-Message-State: AHYfb5jwuGvXI77qgWPXj8JtVVznGPMK83DCqoLyImjMFqupLd9uJCFB JiCCv8JGMZIdVXOW X-Received: by 10.36.17.216 with SMTP id 207mr3571167itf.86.1502198038614; Tue, 08 Aug 2017 06:13:58 -0700 (PDT) Original-Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id b83sm697400iod.35.2017.08.08.06.13.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Aug 2017 06:13:57 -0700 (PDT) In-Reply-To: (Kaushal Modi's message of "Tue, 08 Aug 2017 13:06:52 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135573 Archived-At: Kaushal Modi writes: > The advice gets tricky because I want to add barf-if-buffer-read-only > only if the original fn's interactive form had "*". > > I am using the same advice fn for eval-region and indent-region.. so I > don't need the barf fn call for eval-region. Possibly you could do something with `interactive-form' and `advice-eval-interactive-spec', but yes it's a bit tricky. > @Eli: Based on the discussion[1] on emacs-devel, there isn't any > opposition to doing what's proposed in this bug thread. So if it's > alright by you, and if there is no strong reason to use the more > concise alternative i.e. if both barf-if-buffer-read-only and > interactive "*.." are equally correct, can the former approach be > committed? The choice is not between "*.." and `barf-if-buffer-read-only' as such, "*.." is merely the string version of `barf-if-buffer-read-only'. The choice is between calling `barf-if-buffer-read-only' inside the `interactive' form or inside the function itself.