From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection Date: Fri, 13 Oct 2017 09:32:28 -0400 Message-ID: <87y3of9nrn.fsf@users.sourceforge.net> References: <87ing3w8rk.fsf@gmail.com> <87o9pdazmp.fsf@users.sourceforge.net> <87o9pdaxfo.fsf@gmail.com> <87infjc1s1.fsf@users.sourceforge.net> <83a80vlf0w.fsf@gnu.org> <878tgf8o9u.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1507901599 27968 195.159.176.226 (13 Oct 2017 13:33:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 13 Oct 2017 13:33:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Cc: 28631@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 13 15:33:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e305I-0005TD-SI for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Oct 2017 15:33:05 +0200 Original-Received: from localhost ([::1]:50360 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e305Q-0004IM-CQ for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Oct 2017 09:33:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e305J-0004Hs-46 for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 09:33:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e305F-0000fN-WC for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 09:33:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56558) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e305F-0000ep-RF for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 09:33:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e305F-0000sm-Jj for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 09:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Oct 2017 13:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28631 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28631-submit@debbugs.gnu.org id=B28631.15079015593359 (code B ref 28631); Fri, 13 Oct 2017 13:33:01 +0000 Original-Received: (at 28631) by debbugs.gnu.org; 13 Oct 2017 13:32:39 +0000 Original-Received: from localhost ([127.0.0.1]:37004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e304s-0000s4-27 for submit@debbugs.gnu.org; Fri, 13 Oct 2017 09:32:39 -0400 Original-Received: from mail-io0-f172.google.com ([209.85.223.172]:50972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e304q-0000rp-70 for 28631@debbugs.gnu.org; Fri, 13 Oct 2017 09:32:36 -0400 Original-Received: by mail-io0-f172.google.com with SMTP id 97so8983818iok.7 for <28631@debbugs.gnu.org>; Fri, 13 Oct 2017 06:32:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=BbUajqI2ZuCogwEf/g0OCxTjIRSJYFp8HauipDOMwI0=; b=SUE7EIKODkx+/yMhSjr9UeAe7sm5xlEfvbasDnoi1NUHdLL7AXrYHxIHWTHpXcmIhm dMBgzrJMpI+bhWxnACGHhMCh3CRjP1y+N+Y2DsOebhCbsQ/x2Z3lP1AeciJnl+CY8flE yVtPSafmh3uTaDCTDzi/Aouek0I2Cpieoz6ZI5SVm645ecU9Pp5LFflq8Qivv7g9AMsV 1yW+LmJy+mRxOrq3yTkRyWz/96t6svmux1dO8aIIBMt5DQRVxcCk7CKkb0ybCgYAgoGY YyADKoOF57ABpzAPgeMRBeGVDVG8/Uask0z0Ulku4gImPQv0nbEsNSTmNRC8bP7nmcaz ep3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=BbUajqI2ZuCogwEf/g0OCxTjIRSJYFp8HauipDOMwI0=; b=ZDyP47LS6Y1GLKj2VA6H6gVacGsy275+//O7qB+nasvjc6T8MZxjQPYLMoslp2EuDi c0Dh042S+m5dFZ1HmlbXlplxoLu2h3FSsChYvXMY1c3i354ru3lSLUOya7CXcPeWCSjk Q17Vhsx/l5C8fUttYjNzIlUxhdmns0a3v/Zg9q5Ea8aD7kRvVYIfXjp7pzJWRWpeGWL3 YnO+baON3eM8REi+UyPzKMB5UivMdk5Eb1f3n4geT17s6soMyKDorv1AAr08NSrV7ORB YMDiXXeuE3w3sbyV7xRdu3sn+BDxvVoIERQRIwVB2Sl3k2DgkkNSEHBKtZhU/zvG7ElN IIqA== X-Gm-Message-State: AMCzsaWKdcaF2HFNTldYM61OcrWpDR6ni1nkZMK6m8FIAonM5Lc5+mXO mw0/HkkTAkgqJnOJJ7jISltghQ== X-Google-Smtp-Source: AOwi7QB+AuGPt3EN+C5I7qj6xikYgy7c/scvTo+FKYa/Vg4qPKdPQvX05+ymOH2HEXfKfWIlGKA3gA== X-Received: by 10.107.140.18 with SMTP id o18mr1779036iod.35.1507901550414; Fri, 13 Oct 2017 06:32:30 -0700 (PDT) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id c187sm716278ith.4.2017.10.13.06.32.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Oct 2017 06:32:29 -0700 (PDT) In-Reply-To: <878tgf8o9u.fsf@gmail.com> (Tino Calancha's message of "Fri, 13 Oct 2017 17:06:53 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138341 Archived-At: Eli Zaretskii writes: >> ((and (/= (region-beginning) (region-end)) >> (or (gui-backend-selection-owner-p 'PRIMARY) >> - (null (gui-backend-selection-exists-p 'PRIMARY)))) >> + (null (gui-backend-selection-exists-p 'PRIMARY))) >> + ;; `winner-undo' shouldn't update the selection (Bug#28631). >> + (not (eq this-command 'winner-undo))) >> (gui-set-selection 'PRIMARY >> (funcall region-extract-function nil))))) > Is there really no way to solve this in winner? It seems like a > winner bug/misfeature, and I'm worried by the possible effect of this > patch on use cases that have nothing to do with the specific scenario > of this bug. deactivate-mark is used a lot in places and ways we > cannot possibly predict. That patch only has affect during winner-undo, no? Probably cleaner to avoid relying on `this-command' if possible though. Tino Calancha writes: > I agree it's better if it is handled inside winner. > I am not a winner guru, just an user so sorry if the following patch > is not right. > + ;; `winner-undo' shouldn't update the selection (Bug#28631) when > + ;; select-enable-primary is non-nil. > + (unless select-enable-primary > + (save-current-buffer > + (cl-loop for buf in buffers > + for entry = (cadr (assq buf winner-point-alist)) > + do (progn (set-buffer buf) > + (set-mark (car entry)) > + (setf (winner-active-region) (cdr entry)))))) Maybe only the (setf (winner-active-region) (cdr entry)) part should be skipped?