From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#24365: 24.4; [PATCH] url-http-options fails when connection refused Date: Wed, 06 Dec 2017 05:47:39 -0500 Message-ID: <87y3mgf7zo.fsf@users.sourceforge.net> References: <87inucqdwj.fsf@war.peplook.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1512577129 17559 195.159.176.226 (6 Dec 2017 16:18:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 6 Dec 2017 16:18:49 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 24365@debbugs.gnu.org To: Mark Schreiber Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 06 17:18:44 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eMcOl-0001Nn-Ab for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Dec 2017 17:18:15 +0100 Original-Received: from localhost ([::1]:54831 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMXFP-0007dA-V9 for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Dec 2017 05:48:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMXFG-0007bi-Ve for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2017 05:48:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMXFC-0003Hp-Up for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2017 05:48:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39879) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eMXFC-0003HA-Qk for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2017 05:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eMXFC-0003Aw-Gx for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2017 05:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Dec 2017 10:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24365 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24365-submit@debbugs.gnu.org id=B24365.151255727112188 (code B ref 24365); Wed, 06 Dec 2017 10:48:02 +0000 Original-Received: (at 24365) by debbugs.gnu.org; 6 Dec 2017 10:47:51 +0000 Original-Received: from localhost ([127.0.0.1]:48560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eMXF0-0003AR-Km for submit@debbugs.gnu.org; Wed, 06 Dec 2017 05:47:50 -0500 Original-Received: from mail-io0-f170.google.com ([209.85.223.170]:34909) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eMXEy-0003A9-Ct; Wed, 06 Dec 2017 05:47:48 -0500 Original-Received: by mail-io0-f170.google.com with SMTP id q15so2175684ioh.2; Wed, 06 Dec 2017 02:47:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=a/+zOksGKLMNmwZLWB6lzc4sDQGF8zJYoUgrZf9SkDQ=; b=Zz7wQ9SN7mL9rrr2OvDIWANjzyMv3go7tu6smetQC0gN+HFZDe8adBh0lHDpA8Ztbg tiEWK4MlnYPwwiaQwf5V7Adnu6SKi+zWl0r/vVKx1RTR+8/VKKwln8z8cDw2uYTsygeT Qrbvk/B+jie+XOF6UFDE6dAENcfohFMVhW2DVfhRkUxMjRqEZzRMuTSl+92JGErpCnsL GxMDBNmP6zcIqpFcpkLQoXALHCxG6jLdDawjusx2TkX6Yu2pSapLONumsZoPXUu7qH2x roT1lGz8HTqv44sal0K2jGO3xRM/F+nSepownObXkfrmuyPhDtop8iuaaxRuxysT1ScR 6BUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=a/+zOksGKLMNmwZLWB6lzc4sDQGF8zJYoUgrZf9SkDQ=; b=diG/rxS7Ax4NRlexeChnkEnhL3Xva0VMJ2p/oe4PFdH241bN49fb0i6E+qZlyE2joQ DSDfHEDZ3ZbYUd/yjM+V931KrWGg7F6zdcr2yNoN6WDnA6AzRn34Db9tu7JmfmQSZHIW ZHWB4UCW8vFT2AwxGXdvADvo4D7kRa2rQb+Up4ICT2vomMDyvgg67zn2daMBKhgD62X/ cxJmpq6ZreHaPX4gMkAZUywAv5WfC91bP10cua+8dJPQclYhTRTOAMfbggxct3ZMfDrY y/zqAzWclPRsiwLYKpGjSdzeNTp480lgCAPRKkNL6vXvfEAWdTTwz8HcDLrJtC9FUdNK /b1g== X-Gm-Message-State: AJaThX57I5hNj2MezMIs5H3A4a9M2j5wPqU4g8sX35D9XyK8zyHSRVBJ 83bRLRTOeudLjwq17eQhqhiLRg== X-Google-Smtp-Source: AGs4zMaudax/2gt0CMZuop+ayBdu+rNglhXKLv7Se5jzVue+bFlai6PIHLJn/ZI5mcyw1vTB+W0ycA== X-Received: by 10.107.131.217 with SMTP id n86mr31625501ioi.302.1512557262405; Wed, 06 Dec 2017 02:47:42 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id o73sm6214113ito.4.2017.12.06.02.47.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Dec 2017 02:47:41 -0800 (PST) In-Reply-To: <87inucqdwj.fsf@war.peplook.com> (Mark Schreiber's message of "Sun, 04 Sep 2016 01:15:24 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140737 Archived-At: found 24365 25.3 quit Mark Schreiber writes: > url-http-options fails when a web server refuses its connection. > > Evaluating (url-http-options "http://127.0.0.1:33333/") results in the > following error: > > Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil) > url-http-options("http://127.0.0.1:33333/") In emacs-26, I get a "Connection refused" error, which seems reasonable. Debugger entered--Lisp error: (file-error "make client process failed" "Connection refused" :name "127.0.0.1" :buffer # :host "127.0.0.1" :service 33333 :nowait nil :tls-parameters nil) make-network-process(:name "127.0.0.1" :buffer # :host "127.0.0.1" :service 33333 :nowait nil :tls-parameters nil) open-network-stream("127.0.0.1" # "127.0.0.1" 33333 :type plain :nowait nil) url-open-stream("127.0.0.1" # "127.0.0.1" 33333 nil) url-http-find-free-connection("127.0.0.1" 33333 nil) url-http(#s(url :type "http" :user nil :password nil :host "127.0.0.1" :portspec 33333 :filename "/" :target nil :attributes nil :fullness t :silent nil :use-cookies t :asynchronous nil) #f(compiled-function (&rest ignored) #) (nil)) url-retrieve-internal("http://127.0.0.1:33333/" #f(compiled-function (&rest ignored) #) (nil) nil nil) url-retrieve("http://127.0.0.1:33333/" #f(compiled-function (&rest ignored) #) nil nil nil) url-retrieve-synchronously("http://127.0.0.1:33333/") url-http-options("http://127.0.0.1:33333/") > In my case, this caused the third-party package org-caldav to fail with > this error when M-x org-caldav-sync was invoked and given an incorrect > org-caldav-url. > > I believe that the correct behavior would be to have url-http-options > return nil, which is the behavior of that function when it receives an > HTTP error response. The error which is thrown in emacs-26 would make it clear that you need to correct the url, so I think we should leave it as is.