From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tim Landscheidt Newsgroups: gmane.emacs.bugs Subject: bug#30101: 25.3; defcustom does not clear old :options when reevaluated Date: Sat, 13 Jan 2018 22:14:50 +0000 Organization: http://www.tim-landscheidt.de/ Message-ID: <87y3l1l82t.fsf@passepartout.tim-landscheidt.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1515881657 23937 195.159.176.226 (13 Jan 2018 22:14:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 13 Jan 2018 22:14:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) To: 30101@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 13 23:14:13 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaU40-0005kX-Pn for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Jan 2018 23:14:08 +0100 Original-Received: from localhost ([::1]:41798 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eaU60-00029X-GV for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Jan 2018 17:16:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eaU5u-000297-PS for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2018 17:16:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eaU5q-0006hd-Q9 for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2018 17:16:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47309) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eaU5q-0006hX-Lv for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2018 17:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eaU5q-0000z9-GE for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2018 17:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tim Landscheidt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jan 2018 22:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15158817133714 (code B ref -1); Sat, 13 Jan 2018 22:16:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 Jan 2018 22:15:13 +0000 Original-Received: from localhost ([127.0.0.1]:55206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaU53-0000xq-9J for submit@debbugs.gnu.org; Sat, 13 Jan 2018 17:15:13 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:53971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaU51-0000xb-J0 for submit@debbugs.gnu.org; Sat, 13 Jan 2018 17:15:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eaU4v-0006JE-KV for submit@debbugs.gnu.org; Sat, 13 Jan 2018 17:15:06 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:45913) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eaU4v-0006J7-H4 for submit@debbugs.gnu.org; Sat, 13 Jan 2018 17:15:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eaU4u-0001vY-JR for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2018 17:15:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eaU4p-0006H4-LA for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2018 17:15:04 -0500 Original-Received: from mezzogiorno.tim-landscheidt.de ([2a01:4f8:d15:2286::2]:46980) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eaU4p-0006Ew-Ee for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2018 17:14:59 -0500 Original-Received: from dslb-092-076-023-076.092.076.pools.vodafone-ip.de ([92.76.23.76]:36798 helo=passepartout.tim-landscheidt.de) by mezzogiorno.tim-landscheidt.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eaU4h-0002Km-Fq for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2018 22:14:51 +0000 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142135 Archived-At: If one evaluates first: | (defcustom tmp-test-variable2 nil | "A vowel." | :type 'alist | :options '("A" "F" "I" "O" "U")) and then changes "F" to "E" and evaluates: | (defcustom tmp-test-variable2 nil | "A vowel." | :type 'alist | :options '("A" "E" "I" "O" "U")) the resulting customization page looks like: | Hide Tmp Test Variable2: | [ ] Key: E | Value: nil | [ ] Key: A | Value: nil | [ ] Key: F | Value: nil | [ ] Key: I | Value: nil | [ ] Key: O | Value: nil | [ ] Key: U | Value: nil | INS | State : STANDARD. | A vowel. | Groups: Nil i. e., it is the superset of the :options of the two calls. This is unexpected and undocumented. AFAICT, this behaviour stems from lisp/custom.el's: | [=E2=80=A6] | ((eq keyword :options) | (if (get symbol 'custom-options) | ;; Slow safe code to avoid duplicates. | (mapc (lambda (option) | (custom-add-option symbol option)) | value) | ;; Fast code for the common case. | (put symbol 'custom-options (copy-sequence value)))) | [=E2=80=A6] which has not been substantially touched since the initial revision (d543e20b611fc289b174aa82cab940d873a586ff). Is there any harm in always putting the copied sequence un- conditionally? (Workaround: (put 'tmp-test-variable2 'custom-options nil).)