From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix frameset-restore in the presence of scaling Date: Mon, 22 Jan 2018 13:49:29 +0100 Message-ID: <87y3kqf486.fsf@gmail.com> References: <87efmnb5kr.fsf@gmail.com> <5A623F25.5090604@gmx.at> <87o9lmkvmt.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1516625316 3388 195.159.176.226 (22 Jan 2018 12:48:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 22 Jan 2018 12:48:36 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 22 13:48:32 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edbWK-00085k-CZ for ged-emacs-devel@m.gmane.org; Mon, 22 Jan 2018 13:48:16 +0100 Original-Received: from localhost ([::1]:40362 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edbYG-0003Jd-7G for ged-emacs-devel@m.gmane.org; Mon, 22 Jan 2018 07:50:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36167) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edbXc-0003JF-69 for emacs-devel@gnu.org; Mon, 22 Jan 2018 07:49:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edbXZ-0007JW-3v for emacs-devel@gnu.org; Mon, 22 Jan 2018 07:49:36 -0500 Original-Received: from mail-wr0-x229.google.com ([2a00:1450:400c:c0c::229]:35621) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1edbXY-0007IW-TQ for emacs-devel@gnu.org; Mon, 22 Jan 2018 07:49:33 -0500 Original-Received: by mail-wr0-x229.google.com with SMTP id g38so8508195wrd.2 for ; Mon, 22 Jan 2018 04:49:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version; bh=x07lYLgBxNAbl4EqmeMCrDgkGT9Iz/RSX5BcOvEobZo=; b=pw5o0xHS4FoFP0QsC5mg/taUu8XJFuRbbK5+bJ+7x1dmQIQItCVFyMKZ/AFg9pDBGw /CUYmi03yMwnXT/humuQWZ8Z/N9fPJnXjsSo6U/dpE+vhOByiHkuq1Tq0Wfpk6/7Gd60 jvwJ9/2lj1bHQhrSfO+h78P0BFmdkp/yoGkORIOds5D+TcOSqOr5LMgxnkBukmjjUTsF HKuQFrDhECkgVqFGhxxEX1YHFfp8F9Tc/AAbE113hseQXA7Z3hTy5CE3HSSiMApf+wJd 0EuLhMy3WdUmkDHaNLbx8I2muijFqXto3Cn+SwTmeAET8fQHtYqKW3nQbUC1PHd2WcOM SYAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version; bh=x07lYLgBxNAbl4EqmeMCrDgkGT9Iz/RSX5BcOvEobZo=; b=fMypLE1GSnhs1PFq88kbQDR2gq3dd54UKY/mLle/Ql7OWrz8J9dBe/joIoFeVMcPJs BPOf68UQDNfWVHdtQqz6RCh9b50Xqw7YzPowrn4M+3L+m3qrHJX1hSBrPsstdCxMCIR2 ciDImW8c6Oef8WVmFa3Xgkbib0DH6+77C6L830Dt8XG7KrB9RflLjH+hWrkhOkfBjHod 8hCwJpiqL7j7MLSogh0p4tyFJkOj+j//blY9BEj6wowTNdJ70R+dAIgqcLlQEPBa3dNJ M6pOCjFbhZITbPHNJNPF3aEKzisYIpbizOilMiaWIf+16U+x7bkCPsKb2PYU9vCXlKu2 RBEQ== X-Gm-Message-State: AKwxytdUWjoa4dR1PY8Vd0p+7Mj4GpdVpWAw89XG/eaQRa8Sy7tCdn+r 58oerZQlHFA09kWDA4FPr5297FeP X-Google-Smtp-Source: AH8x226vAt5lySMEFORjfey89TllMlLTqXllrusYeQd+ELDBceI4e/c25Dt6HLb0IGBx3VtmvjRHkg== X-Received: by 10.223.163.134 with SMTP id l6mr6214009wrb.220.1516625371175; Mon, 22 Jan 2018 04:49:31 -0800 (PST) Original-Received: from rpluim-ubuntu ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id o22sm30296144wra.51.2018.01.22.04.49.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2018 04:49:29 -0800 (PST) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <87o9lmkvmt.fsf@gmail.com> (Robert Pluim's message of "Mon, 22 Jan 2018 11:58:34 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222137 Archived-At: Robert Pluim writes: > martin rudalics writes: > >>> Running emacs-26 with GDK_SCALING=2, frameset-restore will position >>> 2nd and subsequent frames incorrectly if they are in the right half of >>> the screen. Turns out that we're querying GTK for the dimensions of >>> the display in order to ensure that frames remain on-screen, and those >>> dimensions need scaling. Patch attached, tested on GTK 3.18, I'd >>> appreciate if someone with a HiDPI screen and GTK >= 3.22 could >>> confirm whether it works for them. >> >> When 'left' and top' are negative, they specify a frame position >> relative to the right or bottom edge of the display. Are such >> specifications affected/corrected by your patch with scaling on? > > They will almost certainly be corrected. My testcase involved > destop-save, which doesn't use such specifications for frames as far > as I know, I'll have to do some manual testing. Negative offsets work correctly with my patch. Robert