From: Juri Linkov <juri@linkov.net>
To: Glenn Morris <rgm@gnu.org>
Cc: 30186@debbugs.gnu.org
Subject: bug#30186: 27.0.50; Password is not hidden in read-passwd
Date: Mon, 22 Jan 2018 23:38:00 +0200 [thread overview]
Message-ID: <87y3kp8thj.fsf@mail.linkov.net> (raw)
In-Reply-To: <o0k1w97mwo.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 22 Jan 2018 13:45:27 -0500")
>> Anyway, I bisected it for you, to
>> c5e89be20a3feba9c67be6855b1dbdc6d8ae5ce2
Thank you very much, I was considering creating a service that
would read git-bisect params in a webform and run a multi-core
VM instance, but with your tips it should be doable locally.
> Here's the discussion reference that should have been in the commit message:
>
> http://lists.gnu.org/r/emacs-devel/2015-04/msg00506.html
I confirm that after removing with-silent-modifications from
remove-yank-excluded-properties, C-y leaves ‘display’ properties
in the minibuffer. It's ‘(inhibit-modification-hooks t)’ in
let-bind of with-silent-modifications that prevents read-passwd
from calling hide-chars-fun again to put new ‘display’ properties
after set-text-properties removes old ones. So this patch should
fix this issue, but I'm not sure if this is right.
diff --git a/lisp/subr.el b/lisp/subr.el
index 092850a..8673547 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -3041,7 +3041,8 @@ remove-yank-excluded-properties
(setq run-start run-end)))))
(with-silent-modifications
(if (eq yank-excluded-properties t)
- (set-text-properties start end nil)
+ (let ((inhibit-modification-hooks nil))
+ (set-text-properties start end nil))
(remove-list-of-text-properties start end yank-excluded-properties)))))
(defvar yank-undo-function)
next prev parent reply other threads:[~2018-01-22 21:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-20 21:29 bug#30186: 27.0.50; Password is not hidden in read-passwd Juri Linkov
2018-01-21 15:59 ` Eli Zaretskii
2018-01-21 21:19 ` Juri Linkov
2018-01-22 18:27 ` Glenn Morris
2018-01-22 18:45 ` Glenn Morris
2018-01-22 21:38 ` Juri Linkov [this message]
2018-01-23 21:38 ` Juri Linkov
2018-01-25 17:39 ` Alan Mackenzie
2018-01-25 21:15 ` Juri Linkov
2018-01-26 18:37 ` Alan Mackenzie
2018-01-26 19:08 ` Eli Zaretskii
2018-01-26 20:00 ` Alan Mackenzie
2018-01-27 9:40 ` Eli Zaretskii
2018-01-27 11:37 ` Alan Mackenzie
2018-01-27 12:23 ` Eli Zaretskii
2018-01-27 13:38 ` Alan Mackenzie
2018-01-27 21:43 ` Juri Linkov
2018-01-27 22:10 ` Alan Mackenzie
2018-01-27 8:27 ` martin rudalics
2018-01-27 9:21 ` Alan Mackenzie
2018-01-30 8:30 ` martin rudalics
2018-01-22 1:53 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3kp8thj.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=30186@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.