From: Noam Postavsky <npostavs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 31312@debbugs.gnu.org, cyrus.and@gmail.com
Subject: bug#31312: Segmentation fault with doom-emacs, NeoTree and Zoom
Date: Thu, 03 May 2018 08:21:34 -0400 [thread overview]
Message-ID: <87y3h1lyk1.fsf@gmail.com> (raw)
In-Reply-To: <83h8nppiyb.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 03 May 2018 05:32:44 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> Please push to the emacs-26 branch, and thanks.
Wouldn't it make sense to remove the previous check, like this?
--- i/src/xdisp.c
+++ w/src/xdisp.c
@@ -13924,11 +13924,6 @@ redisplay_internal (void)
/* Notice any pending interrupt request to change frame size. */
do_pending_window_change (true);
- /* do_pending_window_change could change the selected_window due to
- frame resizing which makes the selected window too small. */
- if (WINDOWP (selected_window) && (w = XWINDOW (selected_window)) != sw)
- sw = w;
-
/* Clear frames marked as garbaged. */
clear_garbaged_frames ();
@@ -13936,6 +13931,13 @@ redisplay_internal (void)
if (NILP (Vmemory_full))
prepare_menu_bars ();
+ /* do_pending_window_change could change the selected_window due to
+ frame resizing which makes the selected window too small.
+ prepare_menu_bars may call lisp hooks and hence also change the
+ selected_window. */
+ if (WINDOWP (selected_window) && (w = XWINDOW (selected_window)) != sw)
+ sw = w;
+
reconsider_clip_changes (w);
/* In most cases selected window displays current buffer. */
next prev parent reply other threads:[~2018-05-03 12:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-29 10:56 bug#31312: Segmentation fault with doom-emacs, NeoTree and Zoom Andrea Cardaci
2018-05-01 13:25 ` Noam Postavsky
2018-05-01 14:33 ` martin rudalics
2018-05-01 23:10 ` Noam Postavsky
2018-05-02 6:16 ` martin rudalics
2018-05-02 11:52 ` Eli Zaretskii
2018-05-02 12:21 ` Noam Postavsky
2018-05-02 12:45 ` Eli Zaretskii
2018-05-02 13:27 ` Andrea Cardaci
2018-05-02 13:47 ` martin rudalics
2018-05-02 15:06 ` Andrea Cardaci
2018-05-02 15:06 ` Eli Zaretskii
2018-05-02 15:14 ` Andrea Cardaci
2018-05-02 15:30 ` Eli Zaretskii
2018-05-02 13:42 ` martin rudalics
2018-05-02 15:03 ` Eli Zaretskii
2018-05-02 18:43 ` martin rudalics
2018-05-02 19:02 ` Eli Zaretskii
2018-05-03 7:11 ` martin rudalics
2018-05-03 0:04 ` Noam Postavsky
2018-05-03 2:32 ` Eli Zaretskii
2018-05-03 12:21 ` Noam Postavsky [this message]
2018-05-03 17:54 ` Eli Zaretskii
2018-05-04 1:18 ` Noam Postavsky
2018-05-02 13:42 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3h1lyk1.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=31312@debbugs.gnu.org \
--cc=cyrus.and@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.