From: Michael Heerdegen <michael_heerdegen@web.de>
To: Noam Postavsky <npostavs@gmail.com>
Cc: "Clément Pit-Claudel" <clement.pitclaudel@live.com>,
31715@debbugs.gnu.org
Subject: bug#31715: cl-incf and cl-decf error out when passed a nil-valued variable as 'offset'
Date: Wed, 06 Jun 2018 02:32:18 +0200 [thread overview]
Message-ID: <87y3fsoiul.fsf@web.de> (raw)
In-Reply-To: <87h8mg7r2c.fsf@gmail.com> (Noam Postavsky's message of "Tue, 05 Jun 2018 19:26:51 -0400")
Noam Postavsky <npostavs@gmail.com> writes:
> Oh, huh, I didn't think to check that case. Maybe we should just change
> cl-incf to disintguish between nil and unspecified then.
>
> (defmacro cl-incf (place &rest args)
> "Increment PLACE by X (1 by default).
> PLACE may be a symbol, or any generalized variable allowed by `setf'.
> The return value is the incremented value of PLACE.
>
> \(fn PLACE &optional X)"
> (declare (debug (place &optional form)))
> (let* ((got-x (= (length args) 1))
> (x (car args)))
> (if (symbolp place)
> (list 'setq place (if got-x (list '+ place x) (list '1+ place)))
> (list 'cl-callf '+ place (if got-x x 1)))))
That's quite hackish, just to make (cl-incf x nil) error, which is a
backward incompatible change with no real gain. Wouldn't we even lose
the byte compiler barfing for something like (incf x 1 2)?
Michael.
next prev parent reply other threads:[~2018-06-06 0:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 20:06 bug#31715: cl-incf and cl-decf error out when passed a nil-valued variable as 'offset' Clément Pit-Claudel
2018-06-04 22:58 ` Noam Postavsky
2018-06-04 23:43 ` Michael Heerdegen
2018-06-05 0:12 ` Noam Postavsky
2018-06-05 0:40 ` Michael Heerdegen
2022-04-21 13:11 ` Lars Ingebrigtsen
2018-06-05 15:19 ` Clément Pit-Claudel
2018-06-05 22:53 ` Noam Postavsky
2018-06-05 23:01 ` Clément Pit-Claudel
2018-06-05 23:26 ` Noam Postavsky
2018-06-05 23:36 ` Clément Pit-Claudel
2018-06-06 0:32 ` Michael Heerdegen [this message]
2018-06-06 0:37 ` Noam Postavsky
2018-06-05 15:03 ` Clément Pit-Claudel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3fsoiul.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=31715@debbugs.gnu.org \
--cc=clement.pitclaudel@live.com \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.