all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stephen Berman <stephen.berman@gmx.net>
To: Noam Postavsky <npostavs@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Tests involving post-command-hook
Date: Wed, 01 Aug 2018 10:47:46 +0200	[thread overview]
Message-ID: <87y3dq79sd.fsf@gmx.net> (raw)
In-Reply-To: <CAM-tV-85bV96t5eGm9p1Uvv19SoXRQghq4n6QC6q2h8pMjKfmQ@mail.gmail.com> (Noam Postavsky's message of "Tue, 31 Jul 2018 19:50:14 -0400")

On Tue, 31 Jul 2018 19:50:14 -0400 Noam Postavsky <npostavs@gmail.com> wrote:

> On 31 July 2018 at 18:10, Stephen Berman <stephen.berman@gmx.net> wrote:
>
>> Is this behavior of post-command-hook expected and if so, is using
>> run-hooks in ERT valid, i.e. is it still really testing hl-line-mode
>> behavior?
>
> Asking whether it's "really" testing seems in danger of getting
> philosophical, but you might also want to look at ert-simulate-command
> which runs those hooks (it doesn't perfectly simulate everything
> though).

Thanks, this indeed works just like calling run-hooks.  I didn't mean to
wax philosophical, just wondering whether running a hook function
explicitly in a test when it isn't automatically run as expected is
legitimate in the test environment, and given the existence of
ert-simulate-command, I conclude the answer is yes.  Thanks (once again)
for the pointer.

Steve Berman



  reply	other threads:[~2018-08-01  8:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31 22:10 Tests involving post-command-hook Stephen Berman
2018-07-31 23:50 ` Noam Postavsky
2018-08-01  8:47   ` Stephen Berman [this message]
2018-08-01 11:51 ` Stefan Monnier
2018-08-01 12:37   ` Stephen Berman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3dq79sd.fsf@gmx.net \
    --to=stephen.berman@gmx.net \
    --cc=emacs-devel@gnu.org \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.