From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#33398: 26.1, netbsd-8; Hi Lock Faces, Hi Green B, default setting suggestion Date: Tue, 27 Nov 2018 01:27:40 +0200 Organization: LINKOV.NET Message-ID: <87y39fmnbn.fsf@mail.linkov.net> References: <9B715204-BE6D-4F02-B484-1EA9EDACE0EB@scratch.space> <87wope15gh.fsf@mail.linkov.net> <4D07BB6C-98A9-4EC2-BB37-097D5D753E53@scratch.space> <87wopbzeuy.fsf@mail.linkov.net> <87d0r04tmg.fsf@mail.linkov.net> <87sgzv747k.fsf@mail.linkov.net> <740AF1DA-7EDB-4310-8C6E-F7944D714513@scratch.space> <87sgzuca5o.fsf@mail.linkov.net> <87a7m0hi5t.fsf@mail.linkov.net> <837eh4gpjd.fsf@gnu.org> <87a7lyi29o.fsf@mail.linkov.net> <837eh1jeak.fsf@gnu.org> <87k1l0c3be.fsf@mail.linkov.net> <83h8g3j0aa.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1543279366 7886 195.159.176.226 (27 Nov 2018 00:42:46 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 27 Nov 2018 00:42:46 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: Van L , 33398@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 27 01:42:41 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRRSa-0001wa-W7 for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Nov 2018 01:42:41 +0100 Original-Received: from localhost ([::1]:39493 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRRUh-00011S-L6 for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Nov 2018 19:44:51 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRRU6-0000e9-E3 for bug-gnu-emacs@gnu.org; Mon, 26 Nov 2018 19:44:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRRPC-0000aQ-Dl for bug-gnu-emacs@gnu.org; Mon, 26 Nov 2018 19:39:15 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45996) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gRRPC-0000Zn-9u for bug-gnu-emacs@gnu.org; Mon, 26 Nov 2018 19:39:10 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gRRP8-0000Op-9I for bug-gnu-emacs@gnu.org; Mon, 26 Nov 2018 19:39:09 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Nov 2018 00:39:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33398 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33398-submit@debbugs.gnu.org id=B33398.15432791151423 (code B ref 33398); Tue, 27 Nov 2018 00:39:06 +0000 Original-Received: (at 33398) by debbugs.gnu.org; 27 Nov 2018 00:38:35 +0000 Original-Received: from localhost ([127.0.0.1]:50239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRROc-0000Mt-PP for submit@debbugs.gnu.org; Mon, 26 Nov 2018 19:38:35 -0500 Original-Received: from insect.birch.relay.mailchannels.net ([23.83.209.93]:48688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRROa-0000Mk-S9 for 33398@debbugs.gnu.org; Mon, 26 Nov 2018 19:38:33 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 980055C29DB; Tue, 27 Nov 2018 00:38:31 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a3.g.dreamhost.com (unknown [100.96.11.179]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 44DA75C28DE; Tue, 27 Nov 2018 00:38:31 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a3.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Tue, 27 Nov 2018 00:38:31 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Stretch-Stretch: 66ecb34e3e158f8e_1543279111449_3461100032 X-MC-Loop-Signature: 1543279111449:2725241589 X-MC-Ingress-Time: 1543279111448 Original-Received: from pdx1-sub0-mail-a3.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTP id 0EBF6807FD; Mon, 26 Nov 2018 16:38:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=FYpCtzfnR9IvNgVviSe14OjeB3g=; b= uEku8HVrc63XKRjHDe3RCQ5QZLlba5ZULnHhOjEd9FWKQefGIb6u/DDofwMjatZ5 uo1VwFzftls0enrVc0GWRFxbrqmAaEpF6m29UVs6NtUUN21CIGE2JpS2/QHbwDI7 SlF2lEUlzoY5u9AhsBTxOR3flQ5Ioq8c8tL4F3fj2ng= Original-Received: from mail.jurta.org (m91-129-107-242.cust.tele2.ee [91.129.107.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTPSA id 70C2380801; Mon, 26 Nov 2018 16:38:27 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a3 In-Reply-To: <83h8g3j0aa.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 26 Nov 2018 18:01:17 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedruddukedgvdegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdejrddvgedvnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtjedrvdegvddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegvlhhiiiesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152803 Archived-At: > So your problem is with the names of the faces? Then may I suggest to > name the new faces hi-red and hi-deepblue? Maybe something like this, but I'm not sure because the red background would be too glaring on 88 colors, but more readable orchid1 is not quite red. Also blue would be too dark for a light background, but more readable DarkSlateGray1 is not quite blue as its name suggests. diff --git a/lisp/hi-lock.el b/lisp/hi-lock.el index f503c2764b..223b1007a8 100644 --- a/lisp/hi-lock.el +++ b/lisp/hi-lock.el @@ -177,6 +177,24 @@ hi-blue "Face for hi-lock mode." :group 'hi-lock-faces) +(defface hi-red + '((((min-colors 88) (background dark)) + (:background "orchid1" :foreground "black")) + (((background dark)) (:background "red" :foreground "black")) + (((min-colors 88)) (:background "orchid1")) + (t (:background "red"))) + "Face for hi-lock mode." + :group 'hi-lock-faces) + +(defface hi-deepblue + '((((min-colors 88) (background dark)) + (:background "DarkSlateGray1" :foreground "black")) + (((background dark)) (:background "blue" :foreground "black")) + (((min-colors 88)) (:background "DarkSlateGray1")) + (t (:background "blue"))) + "Face for hi-lock mode." + :group 'hi-lock-faces) + (defface hi-black-b '((t (:weight bold))) "Face for hi-lock mode." @@ -189,13 +207,13 @@ hi-blue-b :group 'hi-lock-faces) (defface hi-green-b - '((((min-colors 88)) (:weight bold :foreground "green1")) + '((((min-colors 88)) (:weight bold :foreground "green3")) (t (:weight bold :foreground "green"))) "Face for hi-lock mode." :group 'hi-lock-faces) (defface hi-red-b - '((((min-colors 88)) (:weight bold :foreground "red1")) + '((((min-colors 88)) (:weight bold :foreground "firebrick2")) (t (:weight bold :foreground "red"))) "Face for hi-lock mode." :group 'hi-lock-faces) @@ -216,8 +234,8 @@ hi-lock-interactive-patterns (define-obsolete-variable-alias 'hi-lock-face-history 'hi-lock-face-defaults "23.1") (defvar hi-lock-face-defaults - '("hi-yellow" "hi-pink" "hi-green" "hi-blue" "hi-black-b" - "hi-blue-b" "hi-red-b" "hi-green-b" "hi-black-hb") + '("hi-yellow" "hi-pink" "hi-green" "hi-blue" "hi-red" "hi-deepblue" + "hi-black-b" "hi-blue-b" "hi-red-b" "hi-green-b" "hi-black-hb") "Default faces for hi-lock interactive functions.") (define-obsolete-variable-alias 'hi-lock-regexp-history