all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Alex <agrambot@gmail.com>
Cc: 33919@debbugs.gnu.org
Subject: bug#33919: [PATCH 0/5] Add Zstandard compression for installation and utilities
Date: Sun, 30 Dec 2018 11:06:10 +0100	[thread overview]
Message-ID: <87y387pbvx.fsf@gmx.de> (raw)
In-Reply-To: <87tviv3427.fsf@gmail.com> (Alex's message of "Sun, 30 Dec 2018 00:46:08 -0600")

Alex <agrambot@gmail.com> writes:

Hi Alex,

> I figured that it would be nice to support other compression programs
> for installed files, and Zstandard[1] seems like a good alternative
> for gzip in this area due to its fast decompression and wide range of
> options.

Thanks.

> 1) I tested about everything except the Tramp part. One possible issue
> is that zstd prints a progress/summary line to stdout without the -q
> flag when compressing a single file; does Tramp care about that here?

I cannot test your integration into tramp-archive.el, my Ubuntu 18.10
carries libarchive 3.2.2 only. Next year, @work, I have a Fedora 29
machine, which I can use for testing. Will report then.

Integration into tramp-sh.el works. The "-q" argument is not needed,
because Tramp redirects stderr to /dev/null for the compression
commands. The progress line seems to go there.

> diff --git a/etc/NEWS b/etc/NEWS
> index af99e29e40..e65823413b 100644
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -927,6 +927,10 @@ ad-hoc multi-hop file names must match the previous hop.
>  timeout, after which the underlying session is disabled.  This is for
>  security reasons.
>
> ++++
> +*** Zstandard compression is now supported when using libarchive 3.3
> +or newer.
> +
>  ** Rcirc

This is superfluous. tramp-archive.el is new in Emacs 27, and it is
mentioned in etc/NEWS. Changes on that file do not need to be documented
additionally.

Changes in compression of tramp-sh.el are not user visible, no need to
document them in etc/NEWS. This might change, if we decide to give the
user an option to decide, which compression has to be applied in
Tramp. That's not possible for now.

> --- a/lisp/net/tramp-archive.el
> +++ b/lisp/net/tramp-archive.el
> +;; ".gz", ".lrz", ".lz", ".lz4", ".lzma", ".lzo", ".uu", ".xz",".Z",
> +;; and .zst.  A valid archive file name would be

This shall be 

;; ".gz", ".lrz", ".lz", ".lz4", ".lzma", ".lzo", ".uu", ".xz", ".Z",
;; and ".zst".  A valid archive file name would be

> +    "tar" "tbz" "tgz" "tlz" "txz" ".tzst" ;; (Compressed) tape archives.

This shall be

    "tar" "tbz" "tgz" "tlz" "txz" "tzst" ;; (Compressed) tape archives.

Best regards, Michael.





  reply	other threads:[~2018-12-30 10:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-30  6:46 bug#33919: [PATCH 0/5] Add Zstandard compression for installation and utilities Alex
2018-12-30 10:06 ` Michael Albinus [this message]
2019-01-02 13:04   ` Michael Albinus
2018-12-30 15:21 ` Eli Zaretskii
2019-06-23 18:32   ` Lars Ingebrigtsen
2019-06-23 18:49     ` Michael Albinus
2019-06-24 14:07       ` Lars Ingebrigtsen
2019-06-24 14:44     ` Eli Zaretskii
2019-06-24 16:27       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y387pbvx.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=33919@debbugs.gnu.org \
    --cc=agrambot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.