From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#34294: 27.0.50; flymake-start-on-save-buffer has no effect Date: Sun, 03 Feb 2019 22:10:41 +0000 Message-ID: <87y36w8qvy.fsf@gmail.com> References: <87lg2x6fox.fsf@mail.linkov.net> <87h8dkk3ho.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="38690"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34294@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 03 23:11:21 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gqPyx-0009xh-3F for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Feb 2019 23:11:19 +0100 Original-Received: from localhost ([127.0.0.1]:32774 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqPyw-0004rg-2D for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Feb 2019 17:11:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqPyh-0004pl-Ky for bug-gnu-emacs@gnu.org; Sun, 03 Feb 2019 17:11:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gqPyg-0008Uj-AB for bug-gnu-emacs@gnu.org; Sun, 03 Feb 2019 17:11:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58556) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gqPyg-0008Ua-2c for bug-gnu-emacs@gnu.org; Sun, 03 Feb 2019 17:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gqPyf-0006Ex-Qi for bug-gnu-emacs@gnu.org; Sun, 03 Feb 2019 17:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Feb 2019 22:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34294 X-GNU-PR-Package: emacs Original-Received: via spool by 34294-submit@debbugs.gnu.org id=B34294.154923185223971 (code B ref 34294); Sun, 03 Feb 2019 22:11:01 +0000 Original-Received: (at 34294) by debbugs.gnu.org; 3 Feb 2019 22:10:52 +0000 Original-Received: from localhost ([127.0.0.1]:57837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gqPyV-0006EZ-S1 for submit@debbugs.gnu.org; Sun, 03 Feb 2019 17:10:52 -0500 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:33381) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gqPyU-0006EH-BD for 34294@debbugs.gnu.org; Sun, 03 Feb 2019 17:10:51 -0500 Original-Received: by mail-wr1-f45.google.com with SMTP id a16so6926829wrv.0 for <34294@debbugs.gnu.org>; Sun, 03 Feb 2019 14:10:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=7JmdzhQaEtBly5kb8OHsfoF/l5ufWu0I+VNCDwgbW3Q=; b=kNH/+vS3ZQIJAJvhBSchbzeA/UaEJGVODpiJ2CO8n6fNTmZGU3vPSC2fcB5zLj6lY/ 4gfR706PetxMa3sNuLDmRGhuLwFLREgaO3IPbbRsbZvzEc/2KOH4MSb/ybKrMjeQJZu9 BmHzakNY8Y6sOatya/zeOtCYp8Wx4RWckFaN7JTnvs1gimSLs8M0Acdpgl1TtvLtcc9G Jxk69l4s9ShipHBZ80tSeo7MrX0m/dSawrQiW7uTUIGu7MaKhprofzb0tPNNQRMEeYfl OTfzkwpMFQ+x4H1oEVOmu52miLKP/H2z075qo1wJKUFsm9iS7MbPCi0qZWOfTEWoNwaQ K0DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=7JmdzhQaEtBly5kb8OHsfoF/l5ufWu0I+VNCDwgbW3Q=; b=kS353UwGjHAsqSVSpl3gDcYNyzoDAvEuHn/zKXBsmUOnQOpqcAB4L3wvfcVyXWO67Q 9tzonDnmNErx5Q+z90CpvHwelh+9oS/ys1kg2De/W5Ii0OhV1v4pNpZzeR+MCem8NBCc 8Z7O5BFNyXxapO09aug3ISmCu0YyrXHiwmBM/ELtx+ebr25EMvkAGhUG3ILInTLXUKBz vdrlGx4N8IRTQAsZHZ8wu5iA1ZlHYmj6/vNnlhHEBFZPG7/CBSKtQiyi4CNKZbX+ijWB /TdqPHkay01i3CNmIG9wlbjBKYhinBR8b3PJWCQLdVOvbhBiaPEzimcSzzY6q2YaTj23 NaTg== X-Gm-Message-State: AJcUukekfSPq2HlaboLqIX2IvG0wLOnDZnuVEF2H5hntEM1Mt7inOvg8 j9mpCxhBRD9WkrGTKnHz3TrJO3qi X-Google-Smtp-Source: ALg8bN6/rn3dcwY9v1a+aUpm3F2tD7u6tFrhiGUG+xUu8jD2lXbrBd6gW+h0pglRwzkBn+Os8LdEzg== X-Received: by 2002:adf:c711:: with SMTP id k17mr45427301wrg.197.1549231843802; Sun, 03 Feb 2019 14:10:43 -0800 (PST) Original-Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id e9sm15060868wro.16.2019.02.03.14.10.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 03 Feb 2019 14:10:43 -0800 (PST) In-Reply-To: <87h8dkk3ho.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 03 Feb 2019 22:42:59 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155066 Archived-At: Juri Linkov writes: >>> I have flymake-start-on-save-buffer customized to 't' to check syntax >>> only when a buffer is saved, but it still checks the unfinished work >>> while edits are in progress, showing the errors that make no sense >>> until the buffer is saved >> >> They "make sense" if you were to interpret/compile the buffer's >> contents at that moment. It's called fly-make for a reason ;-). > > I just want flymake to fly a little lower ;-) OK, no problem. > 1. The defcustom definition of flymake-no-changes-timeout > currently doesn't allow customizing its value to nil, > because it's type is only 'number. It could provide > an option for `nil'. A patch is welcome to to fix this. > 2. Naming inconsistency - there are following customizable variables: > > (defcustom flymake-start-on-flymake-mode t > (defcustom flymake-start-on-save-buffer t > (defcustom flymake-start-syntax-check-on-newline t > > The last is unnecessary long and could be simplified to just: > > (defcustom flymake-start-on-newline t > > Please compare it with another variable already renamed with: > > (define-obsolete-variable-alias 'flymake-start-syntax-check-on-find-file > 'flymake-start-on-flymake-mode "26.1") A second patch is welcome to fix this too. Please use obsolete variable aliases, as you suggested. I trust you will choose good names. > 3. Maybe the documentation could be improved with the docstring of > flymake-start-on-save-buffer having a hint about disabling > flymake-no-changes-timeout? > > For example, etc/TODO has such entry: > > ** Flymake's customization mechanism needs to be both simpler (fewer > levels of indirection) and better documented, so it is easier to > understand. I find it quite hard to figure out what compilation > command it will use. That is probably obsolete and can be erased. My flymake.el redesign should have taken care of that, and is documented in the Flymake info node. If you feel it is sufficient documentation, a third patch is welcome to remove that TODO entry. > 4. Also I found these related entries in the same etc/TODO file: > > ** Display something in the margin on lines that have compilation > errors. Flymake does this, even though it uses the fringe by default, but I don't have more clues to what the author of this line intended. > ** Allow fringe indicators to display a tooltip (provide a help-echo > property?) I think this is a more generic wish and is not strictly Flymake related. > What do you think about displaying a tooltip on the fringe indicator > with the same text that is displayed on the tooltip over the location > of the error in the source buffer? It's easier to hover on the fringe > than finding the location in the buffer to hover. I don't have any strong opinion. It's fine, I guess, but not specifically tied to Flymake. It may be difficult to implement. BTW you can use flymake-goto-next-error and flymake-goto-prev-error to navigate between errors, it's what I use all the time. So to summarize, it'd be great if you could provide the three patches to implement the suggestions you gave. Jo=C3=A3o