From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 35238@debbugs.gnu.org
Subject: bug#35238: 27.0.50; Clarify eventp behaviour with booleans
Date: Fri, 12 Apr 2019 12:11:01 +0100 [thread overview]
Message-ID: <87y34fscl6.fsf@tcd.ie> (raw)
In-Reply-To: <jwvsguonmee.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 11 Apr 2019 19:42:46 -0400")
[-- Attachment #1: Type: text/plain, Size: 436 bytes --]
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>> As mentioned in a past commit[1], nil is not an event.
>> Since the car of a mouse click event is considered its type,
>> shouldn't (nil) also be rejected as an event?
>
> Not sure it's worth the trouble (there are already lots of other objects
> that aren't events but for which eventp returns non-nil).
Sure, but the following would at least make eventp treat nil
consistently:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: eventp.diff --]
[-- Type: text/x-diff, Size: 781 bytes --]
diff --git a/lisp/subr.el b/lisp/subr.el
index bdf98979c4..407bd6379d 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -1227,12 +1227,13 @@ listify-key-sequence
c)))
key)))
-(defun eventp (obj)
- "True if the argument is an event object."
- (when obj
- (or (integerp obj)
- (and (symbolp obj) obj (not (keywordp obj)))
- (and (consp obj) (symbolp (car obj))))))
+(defun eventp (object)
+ "Return non-nil if OBJECT is an input event or event object."
+ (or (integerp object)
+ (and (symbolp (if (consp object)
+ (setq object (car object))
+ object))
+ (not (keywordp object)))))
(defun event-modifiers (event)
"Return a list of symbols representing the modifier keys in event EVENT.
[-- Attachment #3: Type: text/plain, Size: 274 bytes --]
>> Should t be counted as an event?
>>
>> (eventp t) ; => t
>> (eventp '(t)) ; => t
>
> Not sure if we ever generate such an event, but what would be the
> benefit of rejecting it?
I don't know, it could even be detrimental; I was just curious.
Thanks,
--
Basil
next prev parent reply other threads:[~2019-04-12 11:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 22:42 bug#35238: 27.0.50; Clarify eventp behaviour with booleans Basil L. Contovounesios
2019-04-11 23:42 ` Stefan Monnier
2019-04-12 11:11 ` Basil L. Contovounesios [this message]
2019-04-12 12:25 ` Stefan Monnier
2019-04-12 12:30 ` Eli Zaretskii
2019-04-13 17:53 ` Basil L. Contovounesios
2019-04-14 3:13 ` Stefan Monnier
2019-04-22 23:19 ` Basil L. Contovounesios
2019-04-23 2:06 ` Stefan Monnier
2019-05-07 17:08 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y34fscl6.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=35238@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.