bug#35480: insert-wide-parentheses

bug#35480: insert-wide-parentheses

[積丹尼 Dan Jacobson]

M-( is insert-parentheses, so
M-（ should be insert-wide-parentheses.

bug#35480: insert-wide-parentheses

[Juri Linkov]

> M-( is insert-parentheses, so
> M-（ should be insert-wide-parentheses.

(define-key esc-map "（" 'insert-pair)
(add-to-list 'insert-pair-alist '(?\（ ?\（ ?\）))

bug#35480: insert-wide-parentheses

[積丹尼 Dan Jacobson]

>>>>> "JL" == Juri Linkov <juri@linkov.net> writes:
>> M-( is insert-parentheses, so
>> M-（ should be insert-wide-parentheses.

JL> (define-key esc-map "（" 'insert-pair)
JL> (add-to-list 'insert-pair-alist '(?\（ ?\（ ?\）))

OK but now it looks like
perl -C -wple 's/\d+/chr $&/eg;'
((（ （ ）)
 (( ))
 ([ ])
 ({ })
 (< >)
 (" ")
 (' ')
 (` '))

So I bet just

   (add-to-list 'insert-pair-alist '(?\（ ?\）))

is good enough. Anyways, I'm hoping the emacs authors will add this to
the defaults.

In fact they need to add wide versions of all those current narrow items there.

bug#35480: insert-wide-parentheses

[Juri Linkov]

>>> M-( is insert-parentheses, so
>>> M-（ should be insert-wide-parentheses.
>
> JL> (define-key esc-map "（" 'insert-pair)
> JL> (add-to-list 'insert-pair-alist '(?\（ ?\（ ?\）))
>
> OK but now it looks like
> perl -C -wple 's/\d+/chr $&/eg;'
> ((（ （ ）)
>  (( ))
>  ([ ])
>  ({ })
>  (< >)
>  (" ")
>  (' ')
>  (` '))
>
> So I bet just
>
>    (add-to-list 'insert-pair-alist '(?\（ ?\）))
>
> is good enough. Anyways, I'm hoping the emacs authors will add this to
> the defaults.
>
> In fact they need to add wide versions of all those current narrow items there.

OK, this adds all Unicode pairs to the default:

diff --git a/lisp/emacs-lisp/lisp.el b/lisp/emacs-lisp/lisp.el
index d10d5f0d10..f73dbb269d 100644
--- a/lisp/emacs-lisp/lisp.el
+++ b/lisp/emacs-lisp/lisp.el
@@ -646,7 +646,13 @@ narrow-to-defun
       (narrow-to-region beg end))))
 
 (defvar insert-pair-alist
-  '((?\( ?\)) (?\[ ?\]) (?\{ ?\}) (?\< ?\>) (?\" ?\") (?\' ?\') (?\` ?\'))
+  (append '((?\< ?\>) (?\" ?\") (?\' ?\') (?\` ?\'))
+          (let (alist)
+            (map-char-table
+             (lambda (open close)
+               (when (< open close) (push (list open close) alist)))
+             (unicode-property-table-internal 'paired-bracket))
+            (nreverse alist)))
   "Alist of paired characters inserted by `insert-pair'.
 Each element looks like (OPEN-CHAR CLOSE-CHAR) or (COMMAND-CHAR
 OPEN-CHAR CLOSE-CHAR).  The characters OPEN-CHAR and CLOSE-CHAR

bug#35480: insert-wide-parentheses

[Juri Linkov]

>>>> M-( is insert-parentheses, so
>>>> M-（ should be insert-wide-parentheses.
>>
>> JL> (define-key esc-map "（" 'insert-pair)
>> JL> (add-to-list 'insert-pair-alist '(?\（ ?\（ ?\）))
>>
>> OK but now it looks like
>> perl -C -wple 's/\d+/chr $&/eg;'
>> ((（ （ ）)
>>  (( ))
>>  ([ ])
>>  ({ })
>>  (< >)
>>  (" ")
>>  (' ')
>>  (` '))
>>
>> So I bet just
>>
>>    (add-to-list 'insert-pair-alist '(?\（ ?\）))
>>
>> is good enough. Anyways, I'm hoping the emacs authors will add this to
>> the defaults.
>>
>> In fact they need to add wide versions of all those current narrow items there.
>
> OK, this adds all Unicode pairs to the default:

Pushed to master and closed.

bug#35480: insert-wide-parentheses

[Andreas Schwab]

On Apr 30 2019, Juri Linkov <juri@linkov.net> wrote:

> OK, this adds all Unicode pairs to the default:
>
> diff --git a/lisp/emacs-lisp/lisp.el b/lisp/emacs-lisp/lisp.el
> index d10d5f0d10..f73dbb269d 100644
> --- a/lisp/emacs-lisp/lisp.el
> +++ b/lisp/emacs-lisp/lisp.el
> @@ -646,7 +646,13 @@ narrow-to-defun
>        (narrow-to-region beg end))))
>  
>  (defvar insert-pair-alist
> -  '((?\( ?\)) (?\[ ?\]) (?\{ ?\}) (?\< ?\>) (?\" ?\") (?\' ?\') (?\` ?\'))
> +  (append '((?\< ?\>) (?\" ?\") (?\' ?\') (?\` ?\'))
> +          (let (alist)
> +            (map-char-table
> +             (lambda (open close)
> +               (when (< open close) (push (list open close) alist)))
> +             (unicode-property-table-internal 'paired-bracket))
> +            (nreverse alist)))

Loading /home/abuild/rpmbuild/BUILD/emacs-27.0.50/lisp/emacs-lisp/lisp.el (source)...
Wrong type argument: char-table-p, nil
make[2]: *** [Makefile:808: bootstrap-emacs.pdmp] Error 255

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

bug#35480: insert-wide-parentheses

[Eli Zaretskii]

> From: Andreas Schwab <schwab@linux-m68k.org>
> Date: Mon, 06 May 2019 00:27:20 +0200
> Cc: 積丹尼 Dan Jacobson <jidanni@jidanni.org>,
> 	35480@debbugs.gnu.org
> 
> > OK, this adds all Unicode pairs to the default:
> >
> > diff --git a/lisp/emacs-lisp/lisp.el b/lisp/emacs-lisp/lisp.el
> > index d10d5f0d10..f73dbb269d 100644
> > --- a/lisp/emacs-lisp/lisp.el
> > +++ b/lisp/emacs-lisp/lisp.el
> > @@ -646,7 +646,13 @@ narrow-to-defun
> >        (narrow-to-region beg end))))
> >  
> >  (defvar insert-pair-alist
> > -  '((?\( ?\)) (?\[ ?\]) (?\{ ?\}) (?\< ?\>) (?\" ?\") (?\' ?\') (?\` ?\'))
> > +  (append '((?\< ?\>) (?\" ?\") (?\' ?\') (?\` ?\'))
> > +          (let (alist)
> > +            (map-char-table
> > +             (lambda (open close)
> > +               (when (< open close) (push (list open close) alist)))
> > +             (unicode-property-table-internal 'paired-bracket))
> > +            (nreverse alist)))
> 
> Loading /home/abuild/rpmbuild/BUILD/emacs-27.0.50/lisp/emacs-lisp/lisp.el (source)...
> Wrong type argument: char-table-p, nil
> make[2]: *** [Makefile:808: bootstrap-emacs.pdmp] Error 255

This change has another, IMO more serious, problem: it uses the
bidi-bracket property of characters entirely out of its intended
domain.  The _only_ valid usage of that property is in the context of
the UBA, the Unicode Bidirectional Algorithm, used for reordering
bidirectional text for display.  Pairing syntactical units in program
text is something entirely different.

bug#35480: insert-wide-parentheses

[Juri Linkov]

>> Loading /home/abuild/rpmbuild/BUILD/emacs-27.0.50/lisp/emacs-lisp/lisp.el (source)...
>> Wrong type argument: char-table-p, nil
>> make[2]: *** [Makefile:808: bootstrap-emacs.pdmp] Error 255

This is very strange.  I recompiled several times and had no such error.

> This change has another, IMO more serious, problem: it uses the
> bidi-bracket property of characters entirely out of its intended
> domain.  The _only_ valid usage of that property is in the context of
> the UBA, the Unicode Bidirectional Algorithm, used for reordering
> bidirectional text for display.  Pairing syntactical units in program
> text is something entirely different.

I reverted to the old default value, and changed defvar to defcustom.

Also tried to add a button that would pre-fill the default value
with Unicode bracket pairs, but I see no way to do this because
customize's :options is limited to ‘hook’, ‘plist’, ‘alist’ types
only, alas.

bug#35480: insert-wide-parentheses

[Noam Postavsky]

Juri Linkov <juri@linkov.net> writes:

> Also tried to add a button that would pre-fill the default value
> with Unicode bracket pairs, but I see no way to do this because
> customize's :options is limited to ‘hook’, ‘plist’, ‘alist’ types
> only, alas.

Can't you use the alist type?  The options is called insert-pair-ALIST
after all.

bug#35480: insert-wide-parentheses

[Juri Linkov]

>> Also tried to add a button that would pre-fill the default value
>> with Unicode bracket pairs, but I see no way to do this because
>> customize's :options is limited to ‘hook’, ‘plist’, ‘alist’ types
>> only, alas.
>
> Can't you use the alist type?  The options is called insert-pair-ALIST
> after all.

I tried the alist type:

(defcustom insert-pair-alist
  '((?\( ?\)) (?\[ ?\]) (?\{ ?\}) (?\< ?\>) (?\" ?\") (?\' ?\') (?\` ?\'))
  "Alist of paired characters inserted by `insert-pair'."
  :type '(alist :key-type (character :tag "Open/Command")
                :value-type (choice
                             (list :tag "Pair"
                                   (character :tag "Close"))
                             (list :tag "Triplet"
                                   (character :tag "Open")
                                   (character :tag "Close"))))
  :options '(?\（)
  :group 'lisp
  :version "27.1")

but its :options allows specifying only keys, not alist values.