From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#35562: "varset" bytecode inline path is never taken Date: Sat, 04 May 2019 12:10:12 -0400 Message-ID: <87y33mmc9n.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="180905"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: 35562@debbugs.gnu.org To: Simon Frankau Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 04 18:11:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMxFq-000ky8-5L for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 May 2019 18:11:14 +0200 Original-Received: from localhost ([127.0.0.1]:58525 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMxFp-0007of-2w for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 May 2019 12:11:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42582) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMxFj-0007oY-9H for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 12:11:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMxFh-00013X-Bc for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 12:11:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38499) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMxFe-00012l-CR for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 12:11:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hMxFe-0001N6-6R for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 12:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 May 2019 16:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35562 X-GNU-PR-Package: emacs Original-Received: via spool by 35562-submit@debbugs.gnu.org id=B35562.15569862225215 (code B ref 35562); Sat, 04 May 2019 16:11:02 +0000 Original-Received: (at 35562) by debbugs.gnu.org; 4 May 2019 16:10:22 +0000 Original-Received: from localhost ([127.0.0.1]:52040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMxF0-0001M2-59 for submit@debbugs.gnu.org; Sat, 04 May 2019 12:10:22 -0400 Original-Received: from mail-qt1-f182.google.com ([209.85.160.182]:40253) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMxEy-0001Lm-72 for 35562@debbugs.gnu.org; Sat, 04 May 2019 12:10:20 -0400 Original-Received: by mail-qt1-f182.google.com with SMTP id k24so6414575qtq.7 for <35562@debbugs.gnu.org>; Sat, 04 May 2019 09:10:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=saACDLXnAXT55coTVIaI/hokBDRU2DFUC/dhQ+GPpz4=; b=Qolehp63uPusJCmLohGGEp/WjYE8gPyEJ8ZYUBsnAe39iqJ6QUv6VQEiUCEM7F2Z0L E2snjmVxTPRj3h8Eb5aIgZFWL1q4Uj+jX3+qYHzk72fSwK0ygbZ8gcjx1FMYlMoZQ5TD 2nWVlUxeiR/6Atj+5o6WQefHNGIZerYo3GnSde0h1vXryVN9nYv8KZczP69muQ9F/WTn XZUpIaPtvUh/3OsxrZj/6RnhhaMcKQTznMkEBM1YmizJSzPxmi+ASkhw9/pP8iGGT8WZ +wejTb6lwQpcD0U2Ew6vT/eTdLoIiTu/Gjfc9rRHqK7GYXxRa1UpBVJTgezPTNDREAWL kwVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=saACDLXnAXT55coTVIaI/hokBDRU2DFUC/dhQ+GPpz4=; b=Wrrb5F5U2FrjYHyNW03JOHC2YxxSTNe5mpRsaNZhA0aJ7Lurpbp0ICHW81+Ly93A9q I7kCa/40ZKUgD5PdeK1NJwYgE2tOCeOeWFWmjiGnxURlViZnUgpL4UAlvMGZxGjOScZm nO3uA2p7eihaZx4nm1cGib9QQBZKjTqNI7H07Qtv5nLHNmlyu+UtkEx0GhuSvnBIkbA+ mEDVurS97ycXDFiz19cjTR5Ve/9Y26+pA9Orafy/YYoXhpvM0CXBY/Ma7qMEpTpjhp6v vLTt0x3Mj97cYHvFXjaauLDsoXmp+GHYTfnFAYLNneIMbl6kmfQtQR3yLD7hdpsr9Wfi pEwg== X-Gm-Message-State: APjAAAVk3RJcIekuY60Yh/HwlvcbnK2OtgK6ci7cRvY0a84TIXTKcaqy 9Z7Nt85YRzzCPrI33yKU+kfBEfEW X-Google-Smtp-Source: APXvYqzlQx+vPjQw1RW5slzSRYD6uau3590obOpoAHmWBnuX1+7n0QY0mxbMgY8eBJpxBSfSGEG1Jw== X-Received: by 2002:a0c:d0b1:: with SMTP id z46mr9505355qvg.140.1556986214586; Sat, 04 May 2019 09:10:14 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id m18sm3954692qki.64.2019.05.04.09.10.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 04 May 2019 09:10:13 -0700 (PDT) In-Reply-To: (Simon Frankau's message of "Sat, 4 May 2019 14:27:23 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158745 Archived-At: Simon Frankau writes: > While reading the source, I noticed in bytecode.c that: > && *!XSYMBOL (sym)->u.s.redirect* > should be: > && *XSYMBOL (sym)->u.s.redirect == SYMBOL_PLAINVAL* > As it is, the inline case is never run, since "redirect" is always non-zero. > > Since I'm new to emacs internals, I don't know how to benchmark to work out > if this makes a noticable performance difference. :) I guess something like this might work (haven't tested to see if difference is measurable though): (defvar bug-35562-test-var nil) (benchmark-run-compiled (dotimes (_ 1000000) ;; Unroll a bit, so that setting `bug-35562-test-var' takes more ;; time than incrementing loop counter. (setq bug-35562-test-var nil) (setq bug-35562-test-var nil) (setq bug-35562-test-var nil) (setq bug-35562-test-var nil) (setq bug-35562-test-var nil) (setq bug-35562-test-var nil) (setq bug-35562-test-var nil) (setq bug-35562-test-var nil)))