From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#35624: log-view-diff regression Date: Mon, 13 May 2019 23:40:35 +0300 Organization: LINKOV.NET Message-ID: <87y33a3x6k.fsf@mail.linkov.net> References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="147958"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 35624@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 13 23:01:41 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQI4r-000cLC-66 for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 May 2019 23:01:41 +0200 Original-Received: from localhost ([127.0.0.1]:34991 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQI4q-000835-2D for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 May 2019 17:01:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45797) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQI0b-0004Ao-EE for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 16:57:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQHlr-0006gk-Gl for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 16:42:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32909) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQHlq-0006gM-E5 for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 16:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hQHlq-0006p1-A7 for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 16:42:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87pnou2ak2.fsf@mail.linkov.net> Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 May 2019 20:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35624 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35624-submit@debbugs.gnu.org id=B35624.155778011126207 (code B ref 35624); Mon, 13 May 2019 20:42:02 +0000 Original-Received: (at 35624) by debbugs.gnu.org; 13 May 2019 20:41:51 +0000 Original-Received: from localhost ([127.0.0.1]:46453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQHlf-0006od-Jx for submit@debbugs.gnu.org; Mon, 13 May 2019 16:41:51 -0400 Original-Received: from goldenrod.birch.relay.mailchannels.net ([23.83.209.74]:33993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQHle-0006oF-5a for 35624@debbugs.gnu.org; Mon, 13 May 2019 16:41:50 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id BB27E5C61AE; Mon, 13 May 2019 20:41:44 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a99.g.dreamhost.com (unknown [100.96.11.48]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 70E585C6219; Mon, 13 May 2019 20:41:44 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a99.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Mon, 13 May 2019 20:41:44 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Wipe-Scare: 07ec6ca86e28bfbc_1557780104581_2148137940 X-MC-Loop-Signature: 1557780104581:3584899865 X-MC-Ingress-Time: 1557780104580 Original-Received: from pdx1-sub0-mail-a99.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a99.g.dreamhost.com (Postfix) with ESMTP id C70FA7FB92; Mon, 13 May 2019 13:41:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; s=linkov.net; bh=K1aVTzCnGiwOAogCGM41KeJa7Ks=; b=oQw/lTNm20jrhf 1T/Y5klEiuLZWrjzByQIscNuDwj9nKYX5KEol0CRqT+AOonPdIm5sHbFRMEXeuZW PJIaeId7XqiHorW5sYh/Tjmq64+UKbDbHxRtnCYKpMPlhsg04a0c3eWG2unxSYeJ qmXcJqKLVOCLzbox1EYyclK8or+6w= Original-Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a99.g.dreamhost.com (Postfix) with ESMTPSA id 936617FB91; Mon, 13 May 2019 13:41:39 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a99 X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrleeggdduhedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleeirddvfedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleeirddvfedtpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgeptd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159221 Archived-At: >> Here is a new patch that works also for single-file logs. It relies >> on the function 'log-view-end-of-defun' that takes care about the >> "Show 2X entries" footer: > > Looks good. Please install when you're comfortable with it. Pushed to master. But there is another regression. Do you remember that in older versions there was a header in the *vc-change-log* buffer? It was very useful to put the beginning of the region on the first non-revision line in the header to compare the current working revision with the last committed revision. Now this feature is gone, and the first line can't be used to compare with the working revision because now the first line contains the last committed revision. This patch restores this useful feature: diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index 192e6cf68f..040b0832be 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1017,8 +1017,8 @@ vc-git-print-log ;; If the buffer exists from a previous invocation it might be ;; read-only. (let ((inhibit-read-only t)) - (with-current-buffer - buffer + (with-current-buffer buffer + (insert "Working\n") (apply 'vc-git-command buffer 'async files (append