From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#20148: 24.4: function `bookmark-get-bookmark' Date: Thu, 30 May 2019 13:38:02 +0100 Message-ID: <87y32ot8wl.fsf@tcd.ie> References: <550BA52D.1080805@gmx.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="125321"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 20148-done@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 30 14:39:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWKKu-000WT7-HH for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 May 2019 14:39:12 +0200 Original-Received: from localhost ([127.0.0.1]:53525 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWKKt-00009R-8N for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 May 2019 08:39:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWKKl-000086-V3 for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 08:39:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWKKk-00040E-U1 for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 08:39:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47401) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hWKKk-0003xA-Jv for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 08:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hWKKk-0007wL-Gt for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 08:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 May 2019 12:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20148 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 20148-done@debbugs.gnu.org id=D20148.155921989330428 (code D ref 20148); Thu, 30 May 2019 12:39:02 +0000 Original-Received: (at 20148-done) by debbugs.gnu.org; 30 May 2019 12:38:13 +0000 Original-Received: from localhost ([127.0.0.1]:60944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWKJx-0007ud-1i for submit@debbugs.gnu.org; Thu, 30 May 2019 08:38:13 -0400 Original-Received: from mail-ed1-f65.google.com ([209.85.208.65]:43727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWKJu-0007uF-Jf for 20148-done@debbugs.gnu.org; Thu, 30 May 2019 08:38:11 -0400 Original-Received: by mail-ed1-f65.google.com with SMTP id w33so8896807edb.10 for <20148-done@debbugs.gnu.org>; Thu, 30 May 2019 05:38:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/uEtQCQSZjPToJL2ao5f8gGFxzAc9kpl/ftRqInay2I=; b=Cr42rgVrpfyMXJZifYvW38oErk9OJbGl/p0p/8IINwgXq04p6qUJWpGVAu9LqLNXp0 A4M0ZRSk0AbJ3rT4Mfo9TCmt7LChoRUlRlVo50WLfCUhrJ+d4zZhIX7mUgXOAoajQ98f WfB8tXAscW8TVmtKlg1YcSCPCP8qkAnXgaz4YhNIp5th4+X8bJ+EajLWfvPyLSqt8Cmm +7aqpHXn3LpdfvNRlp+sgoemu5xzrqmgjxO34sI7mAcqBg3kHyt6We4Sk4jK3wXfHRCI 0+IEXKCKdLOaNDWK3mp8glcgvFEOuvchcaVQgVob5vkJBfzxbF7cFR7ZsvbJs3ULoliH GRpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/uEtQCQSZjPToJL2ao5f8gGFxzAc9kpl/ftRqInay2I=; b=Lch0rqMYZGepunyGdr1SQltkXD2TT/0KoJjmF5TQVSzZ2MU0YRul0rh+EHKukeQ7Ed 54JvF/AjgsZ0vT9It/p+K6l3MWq3ALzuMIwjWFYNy7zIgwxbwb+co7BdMjXlyYoUOR4i Th7Z+K96cQzGBMSmKfM63/yzyTA9hRZgfa03bRj8IjhFZnoqyoE+VxJJD7E/iuayOra8 JiBdvJ6H07mwjt5avgZWU9dvDMUvFlgTITDtS8vJfAYoW+IB2tsunxTh2zcvQUBxXy8n eTcVrpjG5Ht2yx3IUMPJ7kb18lB8wU50zI0FtVqTderFNz2XQCxeYq1JLasVORV0BC9n 3sJw== X-Gm-Message-State: APjAAAUAI0pkYXCLX4eIC0uTYfHzlfdFOyb0u9HLuDsI4b4lLna77yrD ByVMYe2LcqYZ6J6UHCNb0cK4yv4qMycEnQ== X-Google-Smtp-Source: APXvYqz1uKY2iopjWYDrQi86Qojrk/+rflxZfcfhehgMqZFZoA+VA9+m1pzV39b+gKvNZ2gUwsKE2A== X-Received: by 2002:a17:906:1483:: with SMTP id x3mr3269080ejc.90.1559219884590; Thu, 30 May 2019 05:38:04 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:8cad:ae29:555d:852d]) by smtp.gmail.com with ESMTPSA id k37sm710992edb.11.2019.05.30.05.38.03 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 30 May 2019 05:38:03 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Sun, 26 May 2019 12:12:33 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159915 Archived-At: tags 20148 fixed close 20148 26.3 quit > From a874f231ba0216ca2c3feedaae8ddb32f378f80e Mon Sep 17 00:00:00 2001 > From: Stefan Kangas > Date: Sun, 26 May 2019 12:04:56 +0200 > Subject: [PATCH] Fix docstring of bookmark-get-bookmark > > * bookmark.el (bookmark-get-bookmark): Fix docstring. > --- > lisp/bookmark.el | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lisp/bookmark.el b/lisp/bookmark.el > index b1fe690dac..5c14f705eb 100644 > --- a/lisp/bookmark.el > +++ b/lisp/bookmark.el > @@ -334,7 +334,9 @@ bookmark-get-bookmark > If BOOKMARK-NAME-OR-RECORD is a string, look for the corresponding > bookmark record in `bookmark-alist'; return it if found, otherwise > error. Else if BOOKMARK-NAME-OR-RECORD is already a bookmark record, > -just return it." > +just return it. > +Signal an error if bookmark is invalid. If optional argument > +NOERROR is non-nil, return nil instead." > (cond > ((consp bookmark-name-or-record) bookmark-name-or-record) > ((stringp bookmark-name-or-record) The docstring already mentioned signalling an error, so I tweaked your patch to include only the second of the two new sentences, as well as to mention the full relative file name (lisp/bookmark.el) and the bug reference (bug#20148) in the commit log, and pushed to emacs-26[1], and am therefore closing this report. [1: 1b2f83bb79]: Fix docstring of bookmark-get-bookmark 2019-05-30 13:32:10 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1b2f83bb7984269b92eb0afb323e3e74baf87068 Thanks, -- Basil