From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#10162: [PATCH] 24.0.91; rcirc autojoin broken (freenode/oftc) when rcirc-authenticate-before-join is set Date: Mon, 03 Jun 2019 18:16:01 -0400 Message-ID: <87y32i48ny.fsf@gmail.com> References: <87ipm2o2m7.fsf@gmail.com> <875zpn5vy1.fsf@stevescott.ca> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="251607"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: 10162@debbugs.gnu.org To: Steve Scott Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 04 00:17:38 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hXvGr-0013MT-ED for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Jun 2019 00:17:37 +0200 Original-Received: from localhost ([127.0.0.1]:41667 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXvGq-000113-EL for geb-bug-gnu-emacs@m.gmane.org; Mon, 03 Jun 2019 18:17:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59822) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXvGJ-0000k9-UU for bug-gnu-emacs@gnu.org; Mon, 03 Jun 2019 18:17:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hXvGI-0006Zn-V0 for bug-gnu-emacs@gnu.org; Mon, 03 Jun 2019 18:17:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58034) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hXvGI-0006ZI-Pf for bug-gnu-emacs@gnu.org; Mon, 03 Jun 2019 18:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hXvGI-0004a8-JF for bug-gnu-emacs@gnu.org; Mon, 03 Jun 2019 18:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Jun 2019 22:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10162 X-GNU-PR-Package: emacs Original-Received: via spool by 10162-submit@debbugs.gnu.org id=B10162.155960017317555 (code B ref 10162); Mon, 03 Jun 2019 22:17:02 +0000 Original-Received: (at 10162) by debbugs.gnu.org; 3 Jun 2019 22:16:13 +0000 Original-Received: from localhost ([127.0.0.1]:43345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXvFV-0004Z5-D1 for submit@debbugs.gnu.org; Mon, 03 Jun 2019 18:16:13 -0400 Original-Received: from mail-io1-f47.google.com ([209.85.166.47]:33256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXvFR-0004Yp-8B for 10162@debbugs.gnu.org; Mon, 03 Jun 2019 18:16:10 -0400 Original-Received: by mail-io1-f47.google.com with SMTP id u13so15724288iop.0 for <10162@debbugs.gnu.org>; Mon, 03 Jun 2019 15:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=pNffeyFdwhH4UNpTca7WAp2x3lIJLJrTQ1IVie6jGfE=; b=emI9dxH08GFfMnb3/Us50eWrqp/p1/QKgkrLgW2U+8YmpXsaT4h6UvpgbMk2fztoX+ FWeV8XdOeaGbu5NivhknAWSzU5/XEGAVR+DwLI/iNbc9MisD0hbAza80w5VIdeix8OpK U44uvNDN1NZGWqWSgj8w6ITb5wiQJlLsCMO0LHS1SwRcAyCqOqJFuXZcmFQUJBcLhXuS D+CgG91P2G7UrMEH2q1KvkNDX+gXWHP3OBq0Jk9owcjb5ythoU3UNqUbOl8wmvzXcqNK TKLprkq9yofyf4K5G6VgygHvTIJapp6CaEf5kVEWMqm0LeTfOvX+kHMdsJEByamFkQ4V ALBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=pNffeyFdwhH4UNpTca7WAp2x3lIJLJrTQ1IVie6jGfE=; b=MRgPQySmxqBdTjsyUKdPG0BBZoCuc3AD64rXEv751menKk+/nIVz5q2U47w229H19o Gss23pBS71MdzM5IlvzB9atYpqRqpWz71lC8p2d0BfRbHu3NJ/bi3ekXDHtF+x/p7zzU ahzvL4FqKJGQ64UyWN0McQsfbToWJVEXHeVNT4DjJS1VpERblAyCgbom9d5tsOG8cGoN efFflDETCioQZE61wGUD7MjXMlhEY6duv39EC8VJCpecAwSKD2ldP7TbXuMRcXFiOmA0 dLin4CGH3SJvVQjM0Jc1YVO5eDhZTnCk5u5GnCZfH17syd4/JO3l0VmtDfWNCMAPeDcC wzbw== X-Gm-Message-State: APjAAAUlfIWx92MY+653KBtMghvVKSuahdz4jfR0yCmYayntBAD01cBx lOk/UK8NJTHfUxBTchasX+0scYhd X-Google-Smtp-Source: APXvYqy7br1AwTFj0PtHhT9uSW9Pq4f3LxHJTWSnXOdaOXMQuUqOn9MJFT43C9TCt1bbknB43QGZjw== X-Received: by 2002:a5d:8ccc:: with SMTP id k12mr324189iot.141.1559600163278; Mon, 03 Jun 2019 15:16:03 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id m68sm7043494itm.1.2019.06.03.15.16.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Jun 2019 15:16:02 -0700 (PDT) In-Reply-To: <875zpn5vy1.fsf@stevescott.ca> (Steve Scott's message of "Sun, 02 Jun 2019 21:55:34 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160089 Archived-At: Steve Scott writes: > Since the hostname returned by irc.freenode.net can be something other > than irc.freenode.net, e.g. niven.freenode.net, the entries for > rcirc-authinfo and rcirc-server-alist will not match. Thanks, I was hitting this, and based on your explanation, I changed my rcirc-authinfo entry to "[.]freenode[.]net\\'" instead of "irc.freenode.net" and autojoin started working. > + (if (and rcirc-auto-authenticate-flag > + ;; We have to ensure that there's an authentication > + ;; entry for that server. Otherwise, > + ;; there's no point in calling authenticate. > + (let (auth-required) > + (dolist (s rcirc-authinfo auth-required) > + (when (string-match (car s) rcirc-server) > + (setq auth-required t))))) > + (if rcirc-authenticate-before-join But it looks like we're still calling authenticate, even in the "otherwise" case, even though you say there's no point?