From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#34233: 27.0.50; defvar in comment Date: Wed, 10 Jul 2019 07:49:43 -0400 Message-ID: <87y3161548.fsf@gmail.com> References: <87o923qdrm.fsf@mouse.gnus.org> <875zobdowo.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="197575"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) Cc: Michael Heerdegen , 34233@debbugs.gnu.org, Sebastian Miele , Stefan Monnier To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 10 14:06:04 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlBMK-000ogg-3U for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Jul 2019 14:06:04 +0200 Original-Received: from localhost ([::1]:60162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlB7H-0003a7-Fo for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Jul 2019 07:50:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44971) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlB6s-0003Y0-2P for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 07:50:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlB6p-00016k-Fu for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 07:50:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54358) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hlB6o-00014f-7G for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 07:50:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hlB6o-0000t3-23 for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 07:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jul 2019 11:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34233 X-GNU-PR-Package: emacs Original-Received: via spool by 34233-submit@debbugs.gnu.org id=B34233.15627593923382 (code B ref 34233); Wed, 10 Jul 2019 11:50:02 +0000 Original-Received: (at 34233) by debbugs.gnu.org; 10 Jul 2019 11:49:52 +0000 Original-Received: from localhost ([127.0.0.1]:34945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlB6e-0000sS-86 for submit@debbugs.gnu.org; Wed, 10 Jul 2019 07:49:52 -0400 Original-Received: from mail-io1-f54.google.com ([209.85.166.54]:35492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlB6c-0000s9-0z for 34233@debbugs.gnu.org; Wed, 10 Jul 2019 07:49:50 -0400 Original-Received: by mail-io1-f54.google.com with SMTP id m24so4060401ioo.2 for <34233@debbugs.gnu.org>; Wed, 10 Jul 2019 04:49:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=JPFjjckE/7NotZCaBxXh+XGvAYsXoL7QsuUpq3pauJE=; b=GOQUuVYesMEbI0/DB90naM++818y2ZbdzKCAk/tIK146pJo0O6XBGc1i2wk3UIUNZ7 LYZqTReuiondZUc2S9fVQyrMTOJRglKZgIwyhV/kpceazXN3ptDfDbRM99PAgsSnU11E B8lfM22F5yqtjiPiTRH1JylisS8Gx7GF62OipXCd+mk+I6BE/7HHpRXB2OXiSmoJob2p iAqVCX39PiJYOckFdcjwjjz4kYQ5MTQeODDMnHKChbPDdiGjRGTwYIrtq9aOBUyhAUX/ 2iVqoMjWgfssQF0RvsmXry1DV15PTDvjGDNwEVlsX4erogn6G9N1A5PQ0cW+PLGIxNYt H8xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=JPFjjckE/7NotZCaBxXh+XGvAYsXoL7QsuUpq3pauJE=; b=oJtpVSV/WC9L/B42qfo7Wsm6NRfKwJOsJBmXZcPt4jTXe8feM+kM2DLmPI3MXVxbCl 7e/gSYfS2xemzP36NDe90/2q404rtwOSNJjV3/ZI7rleqh0XX/ttNnXvJGHw0RYOE5D3 CV4zzfTASQmosFPOaI0n9BE4sqEXtSFcSqEDQuAdHymsYrWzrIlk81Qi7+qJHc2N7psj EUzieOfa1ayMQ6Ivh04FUIcqGSVOJv2pmtDEbTuSdunyxBoCdWSJ4vFkuY9cgjIazAal cn8++hXsy1YMhiMCaX8EiAToZC4Dul1XauN2mSNT0gEPuXzU262BEKtq+JVoN8k22DvQ fqUg== X-Gm-Message-State: APjAAAV5TFyrCbh0bES28Hkt8lCe7hEv9jWGw+tqXUTKC0RZvnsinh+h pnER7Cu91RLSTRarTWjqr7g= X-Google-Smtp-Source: APXvYqzEJnBo82YsEf4saw+8BNC9nRLQWbD7kSdD1FG+0eFc1epU0CHmEWIgl5udIddrpn7BXpZNEA== X-Received: by 2002:a02:3093:: with SMTP id q141mr34888837jaq.128.1562759384311; Wed, 10 Jul 2019 04:49:44 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id s4sm2359649iop.25.2019.07.10.04.49.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 10 Jul 2019 04:49:43 -0700 (PDT) In-Reply-To: (Lars Ingebrigtsen's message of "Wed, 10 Jul 2019 13:42:10 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162618 Archived-At: Lars Ingebrigtsen writes: > Michael Heerdegen writes: > >> This is `eval-sexp-add-defvars' not checking if defvars are really code. > > So is this the correct solution? > > diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el > index cb1b17b447..0e99cb9ac0 100644 > --- a/lisp/progmodes/elisp-mode.el > +++ b/lisp/progmodes/elisp-mode.el > @@ -1179,7 +1179,13 @@ eval-sexp-add-defvars > (let ((var (intern (match-string 1)))) > (and (not (special-variable-p var)) > (save-excursion > - (zerop (car (syntax-ppss (match-beginning 0))))) > + (let ((syntax (syntax-ppss (match-beginning 0)))) > + ;; Top-level. > + (and (zerop (car syntax)) > + ;; Not in a comment. > + (null (nth 4 syntax)) > + ;; Not in a string. > + (null (nth 3 syntax))))) > (push var vars)))) > `(progn ,@(mapcar (lambda (v) `(defvar ,v)) vars) ,exp))))) > > (Those ppss things really should have accessors. :-)) There is already a function for this particular case: syntax-ppss-toplevel-pos.