From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#34233: 27.0.50; defvar in comment Date: Wed, 10 Jul 2019 23:17:02 +0200 Message-ID: <87y315k2sx.fsf@web.de> References: <87o923qdrm.fsf@mouse.gnus.org> <875zobdowo.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="99179"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34233@debbugs.gnu.org, Sebastian Miele , Stefan Monnier To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 10 23:18:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlJyd-000PfA-JB for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Jul 2019 23:18:11 +0200 Original-Received: from localhost ([::1]:37178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlJyc-0005rW-5U for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Jul 2019 17:18:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48008) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlJyV-0005r5-R2 for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 17:18:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlJyU-0001Mt-QZ for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 17:18:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56122) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hlJyU-0001M6-Ge for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 17:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hlJyU-0002D1-9F for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 17:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jul 2019 21:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34233 X-GNU-PR-Package: emacs Original-Received: via spool by 34233-submit@debbugs.gnu.org id=B34233.15627934488443 (code B ref 34233); Wed, 10 Jul 2019 21:18:02 +0000 Original-Received: (at 34233) by debbugs.gnu.org; 10 Jul 2019 21:17:28 +0000 Original-Received: from localhost ([127.0.0.1]:36710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlJxv-0002C7-RW for submit@debbugs.gnu.org; Wed, 10 Jul 2019 17:17:28 -0400 Original-Received: from mout.web.de ([212.227.15.4]:52741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlJxu-0002Bu-9c for 34233@debbugs.gnu.org; Wed, 10 Jul 2019 17:17:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1562793426; bh=bLM0SmXnVNM4B0rorsTupm4SYLE5PrVMFQcAWEtONXM=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=La3XPJ/6LHpXs7kURsQaF4Eb+7Md+C00jklyGnbBK3IqktBhHHdf9/B96OO66voj9 NGtvPVqRfxjRYqpqOX+aMuVtdW8Q7wtkKcepfyt3WgNK7TchNc4PkM1xc0drEWkwC4 jiF3tf8hy1V2Lgw1k2LbyMCvz696WMC8vG4gLynI= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([92.208.178.213]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MQt6E-1hudsy2XjK-00UFfr; Wed, 10 Jul 2019 23:17:06 +0200 In-Reply-To: (Lars Ingebrigtsen's message of "Wed, 10 Jul 2019 13:42:10 +0200") X-Provags-ID: V03:K1:oDthPwmbnkHTWqOw/LZUPjTm6b8g1hxZsRepNN60qIq962bn6iS mH/J/ikZU5RkMM+RXFZirY1UFKUCUlQeyO51aDbJ/FS70si27FkRu9ydxzxlVgWgQ75wU11 8ywKohdqxI5B6HR+qyIW++sLKddR8N9SN/vABGkmPUOzPRcgnuRodhtcRR+a34MEcPP/sk6 NrJLd1l9dFPFPYLbe2Zqg== X-UI-Out-Filterresults: notjunk:1;V03:K0:2t6NN+uR/0k=:XdYx0xnW6P1QGKuvXvcTvB mkIoLMWgUlsTjXuCuVVUuDYFFqvVFPRsk7y/OSfrJfbjgHj05NwwT3rrnn5bKag8TG3QmjTNv QkiYrvQKUHWxXPwAIMOe7p7e/MNh6Xjq5S8GEq8hYKvXKaA1/tvAo2LhvmJ4Dqt4M07Ho96nH fI7LLM8cOmPEFC9pmP3cwd7lGuIbZjrNraybvta7g3DgrATGZqdE2neYNP6eNycimIMMeHpgA l70LloKH04fvXtr1S5aL2sM0bFQvE4oAE7MM9e0s84ahkEYZ8/3IUrF8gZej9GVlRuogDlV55 MEb0y1qFKH7J9Zvzr5UzROola4Jq+vzbzSfH0aPY8YSh44yaA4GynRspylR9ErnrBZYIYlbfw WOIyRvAKg5Vtue0J5iEshHVr2E+cN6yUTvvHRNxpWj5ffnI717VxrL+Xe/a9OKr3hY2l7184F 4BdxoARXxTEf6QBhqSGZKfYhDyV4EHP8NHfjqcM3RZUfYmrBm1DgpQu2/CFJzbjhZ6+v/ecx4 Oyxl3ZOl92Pr2+0Xksau+CjWPLrZk8VqdPAQnpYhcW493cXp1Qq1/BXLRxW3yi46j5pZvx2Ys ikfWJxOX9RsX+D7GtEHzxo7neUYt3dCbV3SEFz8ABnFxDbNYwiArdbEYW1otSxeBaVGA3x5bW K+oAR/y60UTSSRYdzA5Ip1pY28EheBw07QqhzZAwmFN8Bc9Jl2t9y3TNTiB48bMWO2E62QO0O lKdAs2EqgRgvou15w0o51MylVAqycQiHj7vTj6gR9HgoPfoQ61sT7RbkbkXXCgq65V8kBRT2 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162662 Archived-At: Lars Ingebrigtsen writes: > So is this the correct solution? > > diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el > index cb1b17b447..0e99cb9ac0 100644 > --- a/lisp/progmodes/elisp-mode.el > +++ b/lisp/progmodes/elisp-mode.el > @@ -1179,7 +1179,13 @@ eval-sexp-add-defvars > (let ((var (intern (match-string 1)))) > (and (not (special-variable-p var)) > (save-excursion > - (zerop (car (syntax-ppss (match-beginning 0))))) > + (let ((syntax (syntax-ppss (match-beginning 0)))) > + ;; Top-level. > + (and (zerop (car syntax)) > + ;; Not in a comment. > + (null (nth 4 syntax)) > + ;; Not in a string. > + (null (nth 3 syntax))))) > (push var vars)))) > `(progn ,@(mapcar (lambda (v) `(defvar ,v)) vars) ,exp))))) Yes, I think so, plus Noam's suggestion. Michael.