From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 46df7bb 03/12: Add new function time-zone-format Date: Thu, 01 Aug 2019 02:20:26 +0300 Message-ID: <87y30dx03p.fsf@tcd.ie> References: <20190731194754.728.72904@vcs0.savannah.gnu.org> <20190731194757.DA2E121130@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="79222"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 01 01:20:43 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hsxtj-000KSm-4e for ged-emacs-devel@m.gmane.org; Thu, 01 Aug 2019 01:20:43 +0200 Original-Received: from localhost ([::1]:44972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsxti-0006Xw-2I for ged-emacs-devel@m.gmane.org; Wed, 31 Jul 2019 19:20:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50674) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsxte-0006Xc-6l for emacs-devel@gnu.org; Wed, 31 Jul 2019 19:20:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsxtd-00083K-AO for emacs-devel@gnu.org; Wed, 31 Jul 2019 19:20:38 -0400 Original-Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:37678) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hsxtd-00082L-0Q for emacs-devel@gnu.org; Wed, 31 Jul 2019 19:20:37 -0400 Original-Received: by mail-wr1-x42c.google.com with SMTP id n9so46404628wrr.4 for ; Wed, 31 Jul 2019 16:20:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Ba37btmGVjQVPPupJudWKXg5WlB3CyrH5HMTda3fd0o=; b=Ce79tkfuTyk0/kvcZS/jWls5oan5SZtiv3qMeeI+3frIuMf6FRbBBsijB6vnT3NXJL i1UuicI5GmNXQLh1/gdMcHiRkI8u8q+eEttIc+sA3d2EAVi9lD74T/2YRdODAbC+LKMM QguAVC9rPb5+mFHHSYCUArtXnqH+ees1wfm3aD7vjq4r9sCdmkSNryPL3XxiuP+Fz0nQ TlWglufScvZ2J8TSa2WoGqK/rzO8k7tW6dVwyv5Ryp/LizbTR1JAt5PkDOBgnBoZD6t5 8dEq0GIBPaA6e7iE+yvGy0XDxcyZHL697P6ix7qwEtPROnQ5ag+IjpBU4ltQqYs/gZJT J8kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Ba37btmGVjQVPPupJudWKXg5WlB3CyrH5HMTda3fd0o=; b=swcqPlAeyuE0m+CqMj5cmC7bEpBegNYJIXy1im8EMvq18lk5vB9VZXXozOHjg6g6dT PPyZ8QAmD7iYrO2xIdO0wCnSs/uXzia51AmHKuxAH2MF+aTCeHsep1xDrt3V2BoYjdVs mvgO5UZVwYIJXHdmVzbRZQlq+F7n3Lpe1p23kaZzRZbEM/JKhygDQmQxK3KRjAHtF7Je i1zRrFPRMRYVoQkkG5kd1oACMZNGk3tF8kIN5mcP0kj5hzBNtxsyYSTAFG5ghLrfTP7/ xoAtkwRCRFL+W0yJgYB7oZPORi+1LTvWvJEcBEYQVX+O+KPAArFGGQrSF5chTzVi0yti N7QQ== X-Gm-Message-State: APjAAAWXJ1pvCzlCw414Uz/AWjaB2TdUAMpH21oBMIqrVUvWgLOSVGJm kNlgPO18BKJ1bta5d5dfEfp0zvabqkK/Kw== X-Google-Smtp-Source: APXvYqw1We+k6+DkFE1FuRH3/aUzQ7ViG7cDTyzM15K1KKrfB8w7dcxr2RMkqL0iZHWWmGUsABvYtQ== X-Received: by 2002:a05:6000:1007:: with SMTP id a7mr64584012wrx.172.1564615234903; Wed, 31 Jul 2019 16:20:34 -0700 (PDT) Original-Received: from localhost (adsl-131.91.140.89.tellas.gr. [91.140.89.131]) by smtp.gmail.com with ESMTPSA id h16sm75303556wrv.88.2019.07.31.16.20.33 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 31 Jul 2019 16:20:34 -0700 (PDT) In-Reply-To: <20190731194757.DA2E121130@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Wed, 31 Jul 2019 15:47:57 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239075 Archived-At: larsi@gnus.org (Lars Ingebrigtsen) writes: > branch: master > commit 46df7bbe12cce4c9af7ce4357aa9f8d36c1d8933 > Author: Lars Ingebrigtsen > Commit: Lars Ingebrigtsen > > Add new function time-zone-format > [...] > +(defun time-zone-format (seconds) > + "Format SECONDS as a valid time zone string. > +For instance, 3600 is \"+01:00\"." > + (format "%s%02d:%02d" > + (if (< seconds 0) > + "-" > + "+") > + (/ (abs seconds) 3600) > + (mod (abs seconds) 3600))) > + Can't this (and its extension in a subsequent commit) be written in terms of, or replaced by, format-time-string? (format-time-string "%:z" nil 3600) ; => "+01:00" (format-time-string "%:z" nil -7200) ; => "-02:00" (format-time-string "%z" nil 3600) ; => "+0100" (format-time-string "%z" nil -7200) ; => "-0200" Thanks, -- Basil