Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file

Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file

[Lars Ingebrigtsen]

larsi@gnus.org (Lars Ingebrigtsen) writes:

> branch: master
> commit b82adee1f64231236d50b48662d3419417ba5d48
> Author: Johan Claesson <johanclaesson@bredband.net>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
>     Invalidate dir-locals-directory-cache when writing dir-local file
>
>     * lisp/files-x.el (modify-dir-local-variable): Remove file from
>     the cache when writing to ensure that we load the new version
>     later (bug#13860).

Oops; forgot the "Copyright-paperwork-exempt: yes", and I guess it's too
late to amend after I've pushed?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Sun, 18 Aug 2019 15:51:56 -0700
> Cc: Johan Claesson <johanclaesson@bredband.net>
> 
> >     Invalidate dir-locals-directory-cache when writing dir-local file
> >
> >     * lisp/files-x.el (modify-dir-local-variable): Remove file from
> >     the cache when writing to ensure that we load the new version
> >     later (bug#13860).
> 
> Oops; forgot the "Copyright-paperwork-exempt: yes", and I guess it's too
> late to amend after I've pushed?

Too late.

Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file

[Stefan Monnier]

>> Oops; forgot the "Copyright-paperwork-exempt: yes", and I guess it's too
>> late to amend after I've pushed?
> Too late.

Yup.  Hard to believe we're still stuck with this problem of "unfixable
commit messages" after all these years.


        Stefan

Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file

[Štěpán Němec]

On Mon, 19 Aug 2019 05:32:20 -0400
Stefan Monnier wrote:

>>> Oops; forgot the "Copyright-paperwork-exempt: yes", and I guess it's too
>>> late to amend after I've pushed?
>> Too late.
>
> Yup.  Hard to believe we're still stuck with this problem of "unfixable
> commit messages" after all these years.

There's "git notes", but I guess you're aware of that.

<https://git-scm.com/docs/git-notes>: "A typical use of notes is to
supplement a commit message without changing the commit itself."

-- 
Štěpán

Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file

[Noam Postavsky]

On Mon, 19 Aug 2019 at 05:52, Štěpán Němec <stepnem@gmail.com> wrote:

> >>> Oops; forgot the "Copyright-paperwork-exempt: yes", and I guess it's too
> >>> late to amend after I've pushed?
> >> Too late.
> >
> > Yup.  Hard to believe we're still stuck with this problem of "unfixable
> > commit messages" after all these years.
>
> There's "git notes", but I guess you're aware of that.
>
> <https://git-scm.com/docs/git-notes>: "A typical use of notes is to
> supplement a commit message without changing the commit itself."

Although this only adds to the message, right? A few years ago,
someone proposed 'git replace --edit' for this, but I found it creates
a lot of refs which cause noticeable slowdown for all git
operations[1]. Not sure if 'git notes' would also create many refs.
Andreas Schwab mentioned something about a new git refs backend to
scale better[2]. Did anything ever come of that?

[1]: https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg01240.html
[2]: https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg01185.html

Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file

[Štěpán Němec]

On Mon, 19 Aug 2019 13:05:58 -0400
Noam Postavsky wrote:

> On Mon, 19 Aug 2019 at 05:52, Štěpán Němec <stepnem@gmail.com> wrote:
>
>> >>> Oops; forgot the "Copyright-paperwork-exempt: yes", and I guess it's too
>> >>> late to amend after I've pushed?
>> >> Too late.
>> >
>> > Yup.  Hard to believe we're still stuck with this problem of "unfixable
>> > commit messages" after all these years.
>>
>> There's "git notes", but I guess you're aware of that.
>>
>> <https://git-scm.com/docs/git-notes>: "A typical use of notes is to
>> supplement a commit message without changing the commit itself."
>
> Although this only adds to the message, right? A few years ago,
> someone proposed 'git replace --edit' for this, but I found it creates
> a lot of refs which cause noticeable slowdown for all git
> operations[1]. Not sure if 'git notes' would also create many refs.
> Andreas Schwab mentioned something about a new git refs backend to
> scale better[2]. Did anything ever come of that?
>
> [1]: https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg01240.html
> [2]: https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg01185.html

Ah, I knew the git notes suggestion seemed too obvious to be useful...
It seems good for adding a pseudo-header to an occasional commit after
the fact (without changing the commit object) such as here, but I'd
expect you hit the same scalability issues as demonstrated in your tests
with git replace, if used in bulk on a repo of this size. (I have no
data to back that up, though, neither can I comment on your second
question.)

-- 
Štěpán

Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Lars Ingebrigtsen <larsi@gnus.org>,  johanclaesson@bredband.net,  emacs-devel@gnu.org
> Date: Mon, 19 Aug 2019 05:32:20 -0400
> 
> >> Oops; forgot the "Copyright-paperwork-exempt: yes", and I guess it's too
> >> late to amend after I've pushed?
> > Too late.
> 
> Yup.  Hard to believe we're still stuck with this problem of "unfixable
> commit messages" after all these years.

We can solve it easily if we go back to CVS.

Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file

[Ergus via Emacs development discussions.]

On Mon, Aug 19, 2019 at 05:46:47PM +0300, Eli Zaretskii wrote:
>> From: Stefan Monnier <monnier@iro.umontreal.ca>
>> Cc: Lars Ingebrigtsen <larsi@gnus.org>,  johanclaesson@bredband.net,  emacs-devel@gnu.org
>> Date: Mon, 19 Aug 2019 05:32:20 -0400
>>
>> >> Oops; forgot the "Copyright-paperwork-exempt: yes", and I guess it's too
>> >> late to amend after I've pushed?
>> > Too late.
>>
>> Yup.  Hard to believe we're still stuck with this problem of "unfixable
>> commit messages" after all these years.
>
>We can solve it easily if we go back to CVS.
>
This can be fixed with a rebase or a note.

But

A rebase in a public repo is not recommended, so that's why the
fork-join workflow is usually more extended (and the default in gitlab,
github and bitbucked). So the user pushes, rebases and fixes in it's
fork freely as in a local branch, with the advantage that other users
can pull/test and comment the changes (code, message, number of commits,
benchmarks, tests) before they go in the main repo. And only few users
have write access to the master repo and they decide how to add the
changes with a rebase, a merge or a rebase+merge with no-ff (to have
linear or grouped history...).

Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file

[Eli Zaretskii]

> Date: Mon, 19 Aug 2019 18:45:04 +0200
> Cc: larsi@gnus.org, johanclaesson@bredband.net,
>  Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
> From: Ergus via "Emacs development discussions." <emacs-devel@gnu.org>
> 
> This can be fixed with a rebase or a note.

Savannah disallows such rebases, and rightfully so.  In extreme
situations (and this is not one of them) we can ask the Savannah
admins to do that manually.