all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@mouse.gnus.org>
To: Vincent Lefevre <vincent@vinc17.net>
Cc: 37133@debbugs.gnu.org
Subject: bug#37133: 27.0.50; use Autoconf mode instead of m4 for acinclude.m4, aclocal.m4 and acsite.m4
Date: Fri, 23 Aug 2019 05:40:18 +0200	[thread overview]
Message-ID: <87y2zksg65.fsf@mouse.gnus.org> (raw)
In-Reply-To: <875zmqr0vp.fsf@vinc17.net> (Vincent Lefevre's message of "Wed, 21 Aug 2019 17:31:22 +0200")

Vincent Lefevre <vincent@vinc17.net> writes:

> By default, the m4 mode is used for the acinclude.m4, aclocal.m4 and
> acsite.m4 files. It would be better to use the more specific Autoconf
> mode for these files (like configure.ac).

I don't know these modes well, but the doc string for `autoconf-mode'
says:

---
Major mode for editing Autoconf configure.ac files.
---

So would using it for these other .m4 files be appropriate?  If it is,
the following patch would fix the problem.

diff --git a/lisp/files.el b/lisp/files.el
index f76635017d..2a84c2c48f 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -2719,6 +2719,8 @@ auto-mode-alist
      ("\\.bib\\'" . bibtex-mode)
      ("\\.bst\\'" . bibtex-style-mode)
      ("\\.sql\\'" . sql-mode)
+     ;; These .m4 files are Autoconf files.
+     ("\\(acinclude\\|aclocal\\|acsite\\)\\.m4\\'" . autoconf-mode)
      ("\\.m[4c]\\'" . m4-mode)
      ("\\.mf\\'" . metafont-mode)
      ("\\.mp\\'" . metapost-mode)


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2019-08-23  3:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21 15:31 bug#37133: 27.0.50; use Autoconf mode instead of m4 for acinclude.m4, aclocal.m4 and acsite.m4 Vincent Lefevre
2019-08-23  3:40 ` Lars Ingebrigtsen [this message]
2019-08-23 16:39   ` Glenn Morris
2019-08-25  6:12     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2zksg65.fsf@mouse.gnus.org \
    --to=larsi@mouse.gnus.org \
    --cc=37133@debbugs.gnu.org \
    --cc=vincent@vinc17.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.