From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#36940: tests slowness and failure after recent Tramp changes Date: Sun, 25 Aug 2019 18:34:21 +0200 Message-ID: <87y2zhw6eq.fsf@gmx.de> References: <57e233fe-19e9-6eac-7fd5-7e181879d4df@cs.ucla.edu> <87h86uh2l6.fsf@gmx.de> <1bec46f5-01e7-5ea4-5562-501185d80ecf@cs.ucla.edu> <87v9vaf4sk.fsf@gmx.de> <87r25xf1dn.fsf@gmx.de> <8736ibkbne.fsf@gmx.de> <87mughfj96.fsf@gmx.de> <470b50ab-6658-e3cb-cd59-916c398c442f@cs.ucla.edu> <87h86of1tm.fsf@gmx.de> <87v9v0avhm.fsf@gmx.de> <8736hryoi1.fsf@gmx.de> <8736hpxy87.fsf@gmx.de> <661631ef-57ff-a907-d69c-b78aebfa68b9@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="157890"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Stefan Kangas , 36940@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 25 18:35:43 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1vUT-000erX-RO for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Aug 2019 18:35:41 +0200 Original-Received: from localhost ([::1]:43830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1vUR-0005M1-Dx for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Aug 2019 12:35:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35209) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1vTr-0005K8-3Y for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 12:35:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1vTq-0002T6-3T for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 12:35:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36204) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i1vTp-0002Sy-T0 for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 12:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i1vTp-0003d1-M4 for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 12:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Aug 2019 16:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36940 X-GNU-PR-Package: emacs Original-Received: via spool by 36940-submit@debbugs.gnu.org id=B36940.156675088313897 (code B ref 36940); Sun, 25 Aug 2019 16:35:01 +0000 Original-Received: (at 36940) by debbugs.gnu.org; 25 Aug 2019 16:34:43 +0000 Original-Received: from localhost ([127.0.0.1]:45025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1vTW-0003c3-M3 for submit@debbugs.gnu.org; Sun, 25 Aug 2019 12:34:42 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:46125) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1vTT-0003bh-Id for 36940@debbugs.gnu.org; Sun, 25 Aug 2019 12:34:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1566750865; bh=+SNPsab+pp4ArddmF7ETy/iXvAO5eaVcSDlTTX9tG0A=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=UMNHFdOCmnYRbrpa451UK4v62wkpaEYngOzqpnMDsPLH3BaUD4N6ybroEIN1Qr2F2 ocvc5HPzx8eRKw6DvUQOBaerQ1jXIlqg967PNWhKyiI8+EoAXmTY3v+rBk1SQXIcNE HyQ+nJnCqf1DjjeDvutb81W1yY132WHdRssf/6ZM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.91.243.33]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N9dsV-1iGNvQ2kQ1-015av6; Sun, 25 Aug 2019 18:34:25 +0200 In-Reply-To: <661631ef-57ff-a907-d69c-b78aebfa68b9@cs.ucla.edu> (Paul Eggert's message of "Sun, 25 Aug 2019 08:39:01 -0700") X-Provags-ID: V03:K1:cqYUxjB9kyWzDvTQXS7grv5PWwyGOrqtJE+ptDNdafKRRaKlCS8 Ao0Z0p5NF+bA9376h22cJeD2TMAyVfWsIRf6RtU/L836sKlx0Ded9bgPvFulonR8HWKEXRY 5+HMaTwlpFtMpIDttvL4O7AbAPUTLUOCkfBGSUR7n0n210qmknSJjlt18jWv8ydBP8lvqvd TaLmutEZamUUGoSLy5P+g== X-UI-Out-Filterresults: notjunk:1;V03:K0:ZHEP5JfthiM=:9dx3mKW+OADYlAw5trxZ4V pUqKBzSo/yAak1qHr2t0wvrzuit6PD9SivOFX63XWk+PhdYKcseujotLzqLoYiDDLRTPDIggj RVm6CtrQ28nmAjDGe5AC6f/4kMUUyuHzU8GAJT+3oYyDLYxAjssX00hJbQZL4PQC/5Tb9hot0 wdJ7QRGPKKJdT54TXLBCmo417Nt7t2dj+LMYxTXduEh34tyKphu2tvJu6cNOwDy5cVzVVu50j 6cOxM2/ZYxXN6pE5IZm+sPiYFdxpGGhY4QaxLlYIFiKXh00WQszdy1SU/iGe+A2M2lJqjLi6x 0eFtbs5h/4/vumYfHjRwZeQKo4ZltptlWzXSNWP/bZ3Ml1LXxTFiEcF5Rnr//DN5t/s6m6w6P ar5siVwTkHRp57g1Oy5HujoLkwPlLUTBBnNOa8O6aBujjTbL6Q3F1wU0I8awJegfEFELXIlV1 2ksVhfkKH5cAqvZU9r6iKdVnW0y9GW5A5ZNiwAzJ3WvZ+vjLyJHcID4mLfi71ZWnBfQPHPrei +8Q/HtTKQm8W657mUDoh19s/it3tmZWFPQhenWggAss5ZqrG1O26oCbs+3N8I11tkrVejm8Mm /gQhZrRXl+BmTL8PF1BLrIfKjHD85DRURpKSbu0jYM9IB2c5cVLpeA+zazQv1Zu1PlCCkxbCV CszTTpayvaGZBXpZJu7CHus21xpBkNrHIT+Jo5vpHg+8BABCGHTG5WcGAbGZJQ3GXatzthKyM LNSik9yYLKh//d9b+i+m3fC9oYHp59TBISn3WTt+AFBr6C/Y0Bf8lX0LIBxX6wEKWHiVLh4b X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165842 Archived-At: Paul Eggert writes: Hi Paul, > Surely the fix won't work for most inode numbers greater than 2**53, > because converting them to double and back will lose information due > to rounding. Tramp uses this approach already at other places, I have just unified the way inode numbers are retrieved. No problem reported over the years. At which places in the code do you believe such errors will happen? The floating number will be converted in tramp-convert-file-attributes, I cannot see how a rounding error could happen there. Practically, the inode slot of file-attributes doesn't seem to be relevant. I haven't seen any code in Emacs which needs this slot. Likely, Tramp spends too much effort computing it, I believe. Best regards, Michael.