all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Stefan Kangas <stefan@marxist.se>, 36940@debbugs.gnu.org
Subject: bug#36940: tests slowness and failure after recent Tramp changes
Date: Sun, 25 Aug 2019 18:34:21 +0200	[thread overview]
Message-ID: <87y2zhw6eq.fsf@gmx.de> (raw)
In-Reply-To: <661631ef-57ff-a907-d69c-b78aebfa68b9@cs.ucla.edu> (Paul Eggert's message of "Sun, 25 Aug 2019 08:39:01 -0700")

Paul Eggert <eggert@cs.ucla.edu> writes:

Hi Paul,

> Surely the fix won't work for most inode numbers greater than 2**53,
> because converting them to double and back will lose information due
> to rounding.

Tramp uses this approach already at other places, I have just unified
the way inode numbers are retrieved. No problem reported over the years.

At which places in the code do you believe such errors will happen? The
floating number will be converted in tramp-convert-file-attributes, I
cannot see how a rounding error could happen there.

Practically, the inode slot of file-attributes doesn't seem to be
relevant. I haven't seen any code in Emacs which needs this
slot. Likely, Tramp spends too much effort computing it, I believe.

Best regards, Michael.





  reply	other threads:[~2019-08-25 16:34 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-06  0:28 bug#36940: tests slowness and failure after recent Tramp changes Paul Eggert
2019-08-06 12:59 ` Michael Albinus
2019-08-06 16:13   ` Paul Eggert
2019-08-06 19:16     ` Michael Albinus
2019-08-06 19:54     ` Michael Albinus
2019-08-06 23:27       ` Paul Eggert
2019-08-07 15:20         ` Michael Albinus
2019-08-07 19:36           ` Paul Eggert
2019-08-08 14:14             ` Michael Albinus
2019-08-07 21:42           ` Glenn Morris
2019-08-08 13:52             ` Michael Albinus
2019-08-10  1:39               ` Paul Eggert
2019-08-10  9:43                 ` Michael Albinus
2019-08-10 20:24                   ` Paul Eggert
2019-08-11 10:12                     ` Michael Albinus
2019-08-14 10:31                       ` Michael Albinus
2019-08-15  4:26                         ` Paul Eggert
2019-08-24  1:51                         ` Stefan Kangas
2019-08-24  8:08                           ` Michael Albinus
2019-08-24 12:51                             ` Stefan Kangas
     [not found]                               ` <CADwFkmnZ1D-t3BchTSuUrkbkOpKG=yCH9c1ZJbkyGr9mUZrAUg@mail.gmail.com>
2019-08-25  9:27                                 ` Michael Albinus
2019-08-25  9:51                                   ` Eli Zaretskii
2019-08-25 10:07                                     ` Eli Zaretskii
2019-08-25 11:26                                       ` Michael Albinus
2019-08-25 11:39                                         ` Eli Zaretskii
2019-08-25 11:46                                           ` Michael Albinus
2019-08-25 11:58                                             ` Eli Zaretskii
2019-08-26  9:22                                               ` Michael Albinus
2019-08-26  9:59                                                 ` Eli Zaretskii
2019-08-26 11:47                                                   ` Michael Albinus
2019-08-26 12:54                                                     ` Stefan Kangas
2019-08-26 14:19                                                       ` Michael Albinus
2019-08-26 14:36                                                         ` Stefan Kangas
2019-08-26 15:09                                                           ` Michael Albinus
2019-08-26 15:46                                                             ` Stefan Kangas
2019-08-26 16:43                                                               ` Michael Albinus
2019-08-26 17:46                                                                 ` Stefan Kangas
2019-08-26 19:47                                                                   ` Michael Albinus
2019-08-27 16:34                                                                     ` Stefan Kangas
2019-08-27 16:56                                                                       ` Michael Albinus
2019-08-28  0:23                                                                         ` Stefan Kangas
2019-08-25 11:28                                     ` Michael Albinus
2019-08-25 11:48                             ` Michael Albinus
2019-08-25 15:39                               ` Paul Eggert
2019-08-25 16:34                                 ` Michael Albinus [this message]
2019-08-25 20:36                                   ` Paul Eggert
2019-08-26  8:44                                     ` Michael Albinus
2019-08-27  2:17                                       ` Paul Eggert
2019-08-27 11:03                             ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2zhw6eq.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=36940@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.