From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#30990: Should the byte compiler warn about :type mismatches? Date: Fri, 11 Oct 2019 07:54:00 +0200 Message-ID: <87y2xrq13b.fsf@gnus.org> References: <87woxu7rf8.fsf@gmail.com> <838sq8grak.fsf@gnu.org> <87imp9aiu4.fsf@gnus.org> <87imox4rci.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="184262"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 30990@debbugs.gnu.org, Stefan Kangas To: alex.branham@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 11 07:55:25 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIntd-000lp9-HW for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Oct 2019 07:55:25 +0200 Original-Received: from localhost ([::1]:46076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIntc-0006Kc-FO for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Oct 2019 01:55:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48523) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIntH-0006KU-D4 for bug-gnu-emacs@gnu.org; Fri, 11 Oct 2019 01:55:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIntG-0005qs-Ch for bug-gnu-emacs@gnu.org; Fri, 11 Oct 2019 01:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48694) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iIntG-0005qo-8h for bug-gnu-emacs@gnu.org; Fri, 11 Oct 2019 01:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iIntG-0000vJ-5O for bug-gnu-emacs@gnu.org; Fri, 11 Oct 2019 01:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Oct 2019 05:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30990 X-GNU-PR-Package: emacs Original-Received: via spool by 30990-submit@debbugs.gnu.org id=B30990.15707732473436 (code B ref 30990); Fri, 11 Oct 2019 05:55:02 +0000 Original-Received: (at 30990) by debbugs.gnu.org; 11 Oct 2019 05:54:07 +0000 Original-Received: from localhost ([127.0.0.1]:57515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iInsN-0000tJ-4o for submit@debbugs.gnu.org; Fri, 11 Oct 2019 01:54:07 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:53528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iInsM-0000tB-81 for 30990@debbugs.gnu.org; Fri, 11 Oct 2019 01:54:06 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iInsH-0000tM-Cc; Fri, 11 Oct 2019 07:54:03 +0200 In-Reply-To: (Robert Pluim's message of "Thu, 10 Oct 2019 15:11:20 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168930 Archived-At: Robert Pluim writes: > Except that the underlying type is '(repeat ....) so I wonder if this: > > (dolist (ext '(".json.gpg" ".gpg" ".json" "") wallet) > (unless wallet > (setq w (locate-user-emacs-file (concat "sql-wallet" ext) > (concat ".sql-wallet" ext))) > (when (file-exists-p w) > (setq wallet w))))) ; <= this returns a string > > should use (setq wallet (list w)) instead Indeed. It looks like this is where it's used: (defun sql-auth-source-search-wallet (wallet product user server database port) [...] (let* ((auth-sources wallet) and auth-source-search assumes that auth-sources is a list of ... things, not a string: (cl-defun auth-source-search (&rest spec &key max require create delete &allow-other-keys) [...] (let* ((backends (mapcar #'auth-source-backend-parse auth-sources)) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no