From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled Date: Tue, 22 Oct 2019 20:18:17 -0400 Message-ID: <87y2xcco1i.fsf@gmail.com> References: <87h8eq332i.fsf@gmail.com> <87h84a6e42.fsf_-_@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="62670"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 33959@debbugs.gnu.org To: Carlos Pita Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 23 02:19:21 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iN4My-000G9N-41 for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Oct 2019 02:19:20 +0200 Original-Received: from localhost ([::1]:49522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iN4Mx-0007EQ-1A for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Oct 2019 20:19:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37602) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iN4Mi-0007DL-Qs for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 20:19:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iN4Mh-0004oK-L9 for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 20:19:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51820) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iN4Mg-0004np-3Q for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 20:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iN4Mf-0004Kh-TH for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 20:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Oct 2019 00:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33959 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33959-submit@debbugs.gnu.org id=B33959.157178991416618 (code B ref 33959); Wed, 23 Oct 2019 00:19:01 +0000 Original-Received: (at 33959) by debbugs.gnu.org; 23 Oct 2019 00:18:34 +0000 Original-Received: from localhost ([127.0.0.1]:60641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iN4ME-0004Jx-DF for submit@debbugs.gnu.org; Tue, 22 Oct 2019 20:18:34 -0400 Original-Received: from mail-qt1-f174.google.com ([209.85.160.174]:37531) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iN4M4-0004JP-JO; Tue, 22 Oct 2019 20:18:25 -0400 Original-Received: by mail-qt1-f174.google.com with SMTP id g50so15541724qtb.4; Tue, 22 Oct 2019 17:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=lA0E3B2W12dT4lLZiEh+SsES6h1+hbxYNLNf/J1QNSY=; b=ScChpmbRspysZCJa2nXdyfRodbQYojMhroj5wu3H1ihAGKdP/nMDUFfuNi/uzQbYdj TpwS2b3pZbs1YP2CTSGG7p4bOMpsoE37UHVcz3bBv3/uNPzXN0GBghSkbWP5eHFefgM+ byQhbRsUL7z/oFwtj9tgWbDkZnes3d2pPHtsWBCv/ihs9MZZd1+StFJ1OVIyB3A/JYiB lTmog0uQ1aydcWWmV7D6M7+dhX/Bxn7LlTkPZAwJPRAVSwoimddwgbfaQUuYzPsRapNY v3puGnnQ7sVEZ1jQzPHh4NfpiMxGiBWR9uzNlKbmypVl1yE3HS+ExQICl6rNhklIhogQ ySXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=lA0E3B2W12dT4lLZiEh+SsES6h1+hbxYNLNf/J1QNSY=; b=scSf6hVSO3N6rxAkjgM3LEqyo4DKs6AlIxaeNAZXLAgiT2PP/kPjdBuQ2+feVXdjYk QXldbFnL4Wh98/wLNEbzHEPrKZcr7B3y7Y+hUn8c/W2LPPrvfO2OWwk+tIFVaNBRc4jZ /g2WbXG33GlGsnHrV6EObT7Nbp0TJ4TW/cRNjEK1sx4MGt4B1Q6qEEM++TFOu5WD76jh M9lOTEkDiln3Q4CDI3M/93lp/QFpZFMoPbZKFXbHZyNHk9c9p2o2NYrjCKrbu7AoXzKL S93xAEQoH85UVU/raJyexs4oYWGiXzIDkEdu93Yc9UOQHnAPHTg5NIzlehRjodzwqL8/ dYPw== X-Gm-Message-State: APjAAAVFIKTqDVuIMJ/7DX7YCmr3Ek897KNEdr7ObEegf4VaVTN8mzOa xoQZWAAz+K9xtBnIRQePN5xhWyWi X-Google-Smtp-Source: APXvYqxs7sqdvSJkOAIN/y2OPEA0d9B/WrO28SocWe3f6xx5SPbJ92xeS1DdjqiQoo3W0GYhIGqbsQ== X-Received: by 2002:aed:37c9:: with SMTP id j67mr6409625qtb.291.1571789898705; Tue, 22 Oct 2019 17:18:18 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id k15sm1465088qtp.90.2019.10.22.17.18.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Oct 2019 17:18:17 -0700 (PDT) In-Reply-To: (Carlos Pita's message of "Wed, 16 Oct 2019 17:35:42 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170018 Archived-At: tags 33959 fixed close 33959 27.1 quit Carlos Pita writes: > Hi Noam, I don't want to be insistent (and I'm probably being) No worries, sorry for taking so long on this. > As it is now, it's certainly buggy. I know it would be desirable to > provide an unit test for [1] but this new commit I'm providing can't > harm (remember it's just an "around advice": `(unless (string= output > "") ... )`) and I believe my argument against the way the empty output > condition was checked before is sound and simple enough. Thanks and > sorry for the insistence. Looking at this now afresh, I agree that this change looks safe enough. I think I was confused before by the other patch removing that same guard in the first branch of the `if'. I do suspect that the filter function receiving an empty string is a bug in itself though. Meanwhile I've pushed your fix (since we'll want it in the GNU ELPA python.el for Emacs 26 and earlier regardless of whether the underlying process filter bug is fixed). [2: ab67287872]: 2019-10-22 20:11:49 -0400 Avoid extra lines in python-shell font lock buffer (Bug#33959) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ab6728787245e0d46bd8a8919e30c882f6011182