From: Michael Albinus <michael.albinus@gmx.de>
To: Wanrong Lin <wrglin@gmail.com>
Cc: 38079@debbugs.gnu.org
Subject: bug#38079: On Windows tramp hangs after server-start is called
Date: Thu, 07 Nov 2019 16:23:16 +0100 [thread overview]
Message-ID: <87y2wrd82j.fsf@gmx.de> (raw)
In-Reply-To: <0c0b89e3-ec38-6917-21c3-af35ece4a63f@gmail.com> (Wanrong Lin's message of "Wed, 6 Nov 2019 11:50:59 -0500")
[-- Attachment #1: Type: text/plain, Size: 420 bytes --]
Wanrong Lin <wrglin@gmail.com> writes:
Hi,
> Yes that can be another way to fix. The downside is we don't know this
> system-name upper/lower case change will cause any surprises somewhere
> else. But I don't understand the underlying difficulty to ensure
> system-name never changes. Thanks for fixing it either way.
Does the appended patch fix the problem for you?
> Warren
Best regards, Michael.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1163 bytes --]
diff --git a/lisp/tramp.el b/lisp/tramp.el
index b1ad1922..7b929255 100644
--- a/lisp/tramp.el
+++ b/lisp/tramp.el
@@ -457,15 +457,20 @@ interpreted as a regular expression which always matches."
:version "24.3"
:type 'boolean)
+;; For some obscure technical reasons, `system-name' on w32 returns
+;; either lower case or upper case letters. See
+;; <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38079#20>.
(defcustom tramp-restricted-shell-hosts-alist
(when (memq system-type '(windows-nt))
- (list (concat "\\`" (regexp-quote (system-name)) "\\'")))
+ (list (format "\\`\\(%s\\|%s\\)\\'"
+ (regexp-quote (downcase (system-name)))
+ (regexp-quote (upcase (system-name))))))
"List of hosts, which run a restricted shell.
This is a list of regular expressions, which denote hosts running
a registered shell like \"rbash\". Those hosts can be used as
proxies only, see `tramp-default-proxies-alist'. If the local
host runs a registered shell, it shall be added to this list, too."
- :version "24.3"
+ :version "27.1"
:type '(repeat (regexp :tag "Host regexp")))
(defcustom tramp-local-host-regexp
next prev parent reply other threads:[~2019-11-07 15:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 0:52 bug#38079: On Windows tramp hangs after server-start is called Wanrong Lin
2019-11-06 16:06 ` Eli Zaretskii
2019-11-06 16:14 ` martin rudalics
2019-11-06 17:37 ` Michael Albinus
2019-11-06 16:50 ` Wanrong Lin
2019-11-06 18:11 ` Eli Zaretskii
2019-11-08 7:51 ` Michael Albinus
2019-11-08 10:34 ` Eli Zaretskii
2019-11-08 10:50 ` Michael Albinus
2019-11-08 13:35 ` Eli Zaretskii
2019-11-07 15:23 ` Michael Albinus [this message]
2019-11-07 16:18 ` Wanrong Lin
2019-11-07 17:45 ` Michael Albinus
2019-11-07 16:18 ` Wanrong Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2wrd82j.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=38079@debbugs.gnu.org \
--cc=wrglin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.