From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#5344: 23.1.91; bug/wish: vc does not honour GIT_DIR / GIT_WORK_TREE environment variables Date: Sun, 24 Nov 2019 22:46:39 +0100 Message-ID: <87y2w5j6bk.fsf@gnus.org> References: <20100109014953.GC25574@shi.workgroup> <201001091929.o09JT9QF010981@godzilla.ics.uci.edu> <20100110223940.GB4845@shi.workgroup> <87imnaoica.fsf@gnus.org> <87wobpfnpq.fsf@len.workgroup> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="231443"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 5344@debbugs.gnu.org To: Gregor Zattler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 25 15:53:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iZFjk-000xy5-SU for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Nov 2019 15:53:13 +0100 Original-Received: from localhost ([::1]:44902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZFjj-0002XY-L1 for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Nov 2019 09:53:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54888) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZFjb-0002XP-7T for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 09:53:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZFja-0004nG-3i for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 09:53:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42050) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZFjZ-0004n4-WC for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 09:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZFjZ-0008WP-V7 for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 09:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Nov 2019 14:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5344 X-GNU-PR-Package: emacs Original-Received: via spool by 5344-submit@debbugs.gnu.org id=B5344.157469353132693 (code B ref 5344); Mon, 25 Nov 2019 14:53:01 +0000 Original-Received: (at 5344) by debbugs.gnu.org; 25 Nov 2019 14:52:11 +0000 Original-Received: from localhost ([127.0.0.1]:48023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZFik-0008VF-VV for submit@debbugs.gnu.org; Mon, 25 Nov 2019 09:52:11 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:51626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZFii-0008V1-TV for 5344@debbugs.gnu.org; Mon, 25 Nov 2019 09:52:09 -0500 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iYziK-0001wf-Da; Sun, 24 Nov 2019 22:46:42 +0100 In-Reply-To: <87wobpfnpq.fsf@len.workgroup> (Gregor Zattler's message of "Sun, 24 Nov 2019 13:44:33 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172365 Archived-At: (Please keep the debbugs address in the Cc header -- otherwise the mail doesn't reach the bug tracker.) Gregor Zattler writes: > Actually git does it the other way around: It uses the values of > the environment variables even if there is a .git directory > further up in the file system hierarchy. So it's not a fall > back but it overrides the default. The vc functions in Emacs sets GIT_DIR to "" before calling git, so in vc mode it would be a fallback. > When I wrote this bug report and later the tiny patch, what I > wanted was to edit dotfiles with emacsclient from the terminal > command line in terminal frames. But in several terminals there > are several shells with possibly different GIT_DIR/GIR_WORK_TREE > environment variables. > > But working with emacsclient there is only one emacs server and > therefore only one pair of GIT_DIR/GIR_WORK_TREE variables. > > To work with git from the command line with emacsclient the > environment variables would have to be frame local. > > This is where I stuck. > > Therefore nowadays I'm back to a single ~/.git directory, not > using the environment variables any more. And I'm working with > magit nowadays. Magit also does not support the > GIT_DIR/GIR_WORK_TREE environment variables. > > There are interesting discussions on this topic here: > https://github.com/magit/magit/issues/2939#issuecomment-271186636 > and here: https://github.com/magit/magit/issues/460 > > These are attempts to solve the pu: > https://gitlab.com/stepnem/vcsh-el > https://github.com/vanicat/magit-vcsh It seems like providing a simple alist of directories/git repos would do the trick in vc-dir, wouldn't it?