From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#38457: 27.0.50; dabbrev-expand regression due to message change Date: Thu, 05 Dec 2019 16:24:08 +0100 Message-ID: <87y2vqaj8n.fsf@gmail.com> References: <8736e3vve8.fsf@gmx.net> <8736e2coyv.fsf@mail.linkov.net> <83y2vujd0y.fsf@gnu.org> <87blspm0sm.fsf@mail.linkov.net> <837e3ckbem.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="185039"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 38457@debbugs.gnu.org, stephen.berman@gmx.net, Juri Linkov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 05 16:29:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ict3z-000lz3-PL for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Dec 2019 16:29:07 +0100 Original-Received: from localhost ([::1]:56278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ict3y-0000Ga-4U for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Dec 2019 10:29:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34007) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ict03-0004a7-LP for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 10:25:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ict02-0000ch-9c for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 10:25:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39062) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ict02-0000bp-4X for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 10:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ict01-0001LA-WC for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 10:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Dec 2019 15:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38457 X-GNU-PR-Package: emacs Original-Received: via spool by 38457-submit@debbugs.gnu.org id=B38457.15755594585044 (code B ref 38457); Thu, 05 Dec 2019 15:25:01 +0000 Original-Received: (at 38457) by debbugs.gnu.org; 5 Dec 2019 15:24:18 +0000 Original-Received: from localhost ([127.0.0.1]:45035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icszK-0001JI-B1 for submit@debbugs.gnu.org; Thu, 05 Dec 2019 10:24:18 -0500 Original-Received: from mail-wr1-f53.google.com ([209.85.221.53]:44092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icszJ-0001J4-11 for 38457@debbugs.gnu.org; Thu, 05 Dec 2019 10:24:17 -0500 Original-Received: by mail-wr1-f53.google.com with SMTP id q10so4070458wrm.11 for <38457@debbugs.gnu.org>; Thu, 05 Dec 2019 07:24:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=kv6TcD7hfO7P4en/NqrNanAHy9vFfMTA0ysx+7+/2Aw=; b=PZVaV2YwpJQtZRDWXTMWHEKaXVBsXrf3/9ZMFdPHPhH6sVae4hZC2GEGB4JjeEH0qa j9zY+ZFZqs40+s2oR9LCFeUj3zfJpUABYmV685J3qIpF03nR271am1mF5k/0+SOLnKBs yck1xnNWqsBc+HHt12TMGrcu+uen5u+akyK3LpSFAJzWp2Lzq6iHWVzsQzIeiT9viN83 pbygTvAV8lLyPmiZ9dWkMXO5p/NHCVMmVP5oCrhgSYxEFKHMq0JvVZtrjCDdLKnDXdfq ebJd82z6lo/RIqfVm867gfla0iorjVUMAmA7VcqYzRR/kDD3Je/CWdInAN+4USmzkfDR 41WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=kv6TcD7hfO7P4en/NqrNanAHy9vFfMTA0ysx+7+/2Aw=; b=puUbDUNqoTkQObh+T4AaXKt0lX9h7OTVRndJkVBiLu9eLKGbGBEvmow/aXiQ//w2T6 7WjgJLlG3KoWu40zyMQCubAa6qDLQMPyDqIB+qpCvpMS4wrsi+/Qaz48qI5VlSauE3cq mfKPkZMFVfmDZIrBVn5vuCFqpZbstZ5q2uqhbrWx+shMh+LjnCtIOP19LlPqw1HFUsRo TEFiFFnwPESEX2TrtLG0EwUZvz6ZoAHFUqLstG9s7rnVZbl1EzmywnL7BXVXJjBA4r3M 1rs2i8n4h2+2m6+i6V2XronzSOnTtb9j+ZtIzcSh1Lyyk0orUEF1Q0D1crsXKyk3D4cr odLg== X-Gm-Message-State: APjAAAXilIPCP0IhIVFWJQWUmy5UAPJhnz6MqgVvaqD/k9w9XhZ80Siz XVZRM3/3rO6Q6TrFCfiQs1E= X-Google-Smtp-Source: APXvYqzV5WA4sX8+WAi7oXqTbAaQ852DHc+9CenXKNoQHa+GLWsn++IFRBWHVNevUrlEC2CkPeUgtQ== X-Received: by 2002:a5d:44ca:: with SMTP id z10mr11536334wrr.266.1575559451200; Thu, 05 Dec 2019 07:24:11 -0800 (PST) Original-Received: from little-buster (2a01cb04010fc800344a427cd486b589.ipv6.abo.wanadoo.fr. [2a01:cb04:10f:c800:344a:427c:d486:b589]) by smtp.gmail.com with ESMTPSA id a24sm130080wmb.29.2019.12.05.07.24.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Dec 2019 07:24:10 -0800 (PST) In-Reply-To: <837e3ckbem.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 04 Dec 2019 05:38:41 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172916 Archived-At: Eli Zaretskii writes: >> From: Juri Linkov >>=20 >> > So please try to find a simpler fix for this problem, one that doesn't >> > involve a timer. >>=20 >> This is the simplest and the safest solution. > > The simplest solution would be to prevent dabbrev-expand from > displaying the message in the first place; there are conditions for > that which evidently the new implementation somehow triggers. > >> I wanted to implement it earlier but had no time before. I see no >> problems with it. > > Let's not rock the boat too much so close to the release cycle because > of a very minor problem which caused these changes. You may not see > any problems with it now, but I'm certain we will bump into numerous > problems very soon if we make such significant changes in this > infrastructure, which is used everywhere in Emacs. Mmm, as you say, the message infrastructure is used everywhere in Emacs, and it has received significant changes in aa89c84e00d. I think the regression Stephen noticed is more widespread than just dabbrev-expand: e.g. TRAMP is also affected[1]. Does it make sense to address each symptom individually? Were dabbrev, TRAMP, and possibly others wrong to assume that they could call (message =E2=80=A6) without cau= sing 2-second delays? NB: I am not saying that Juri's initial patch is the simplest nor the safest. It just seems to me that aa89c84e00d has already "rocked the boat" quite a bit, and addressing this specific bug report by tweaking dabbrev-expand will only take care of the tip of the iceberg, to continue the nautical metaphor=E2=80=A6 [1] C-x C-f /ssh:localhost: RET =E2=87=92 This hangs for 10 seconds unless the user furiously spams some command (e.g. C-n), as each of the following message takes 2 seconds to disappear: > Tramp: Opening connection for localhost using ssh... > Tramp: Sending command =E2=80=98exec ssh -o ControlMaster=3Dauto -o= ControlPath=3D'tramp.%C' -o ControlPersist=3Dno -e none localhost=E2=80=99 > Tramp: Waiting for prompts from remote shell...done > Tramp: Found remote shell prompt on =E2=80=98localhost=E2=80=99 > Tramp: Opening connection for localhost using ssh...done I haven't reported this as a separate issue yet, because I am assuming that both bugs are caused by recent changes in message and should be fixed there=E2=80=A6