From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Federico Tedin Newsgroups: gmane.emacs.bugs Subject: bug#39596: 26.3; Export INSIDE_EMACS with Eshell Date: Wed, 19 Feb 2020 17:22:18 +0100 Message-ID: <87y2sylf7p.fsf@gmail.com> References: <87a75lvds8.fsf@ambrevar.xyz> <87blpvc9ek.fsf@ambrevar.xyz> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="59953"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 39596@debbugs.gnu.org To: Pierre Neidhardt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 19 17:43:53 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j4SRy-000FQh-Gn for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Feb 2020 17:43:50 +0100 Original-Received: from localhost ([::1]:56188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4SRx-0003SE-FC for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Feb 2020 11:43:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39692) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4S7r-00027X-Au for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 11:23:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4S7q-0006Ch-5x for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 11:23:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37341) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j4S7q-0006CW-22 for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 11:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j4S7p-0005Xa-TN for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 11:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Federico Tedin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Feb 2020 16:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39596 X-GNU-PR-Package: emacs Original-Received: via spool by 39596-submit@debbugs.gnu.org id=B39596.158212934821257 (code B ref 39596); Wed, 19 Feb 2020 16:23:01 +0000 Original-Received: (at 39596) by debbugs.gnu.org; 19 Feb 2020 16:22:28 +0000 Original-Received: from localhost ([127.0.0.1]:43314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4S7H-0005Wn-UR for submit@debbugs.gnu.org; Wed, 19 Feb 2020 11:22:28 -0500 Original-Received: from mail-wm1-f52.google.com ([209.85.128.52]:54913) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4S7H-0005Wb-4x for 39596@debbugs.gnu.org; Wed, 19 Feb 2020 11:22:27 -0500 Original-Received: by mail-wm1-f52.google.com with SMTP id n3so1311630wmk.4 for <39596@debbugs.gnu.org>; Wed, 19 Feb 2020 08:22:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Htaf8nj6MjiG4KEbcZGpHKkGx2q6DZ1srfBF48QkivM=; b=euOMd6GkZqLHNxP84EGk7wXveQYJiwMIlZBXn9vcoqI/p1p2/MtUpP2A/wDETp5T4D MLXdsYCR+zSschId4ZeOhaYCNAAiEvmMdVmYQYcweq2Jq3LJHdU7+NNX5+aN6OkscV28 H95AllO0tBkdb2Z6FU81D/BMldV4tx30YhAx783RjTK/wi7iiuseLDIfBPi/IsYz6mqy l11ix/WNQb/jJHRr2wjpzCYd/XKInM+LXpGfxMUeWOHCLJ2ooAssetJ6Bl4c9Q3i+LZk pupDPAuV/+hWUzmxQcDnAHB/sJB3OOX/P+7J3pCVPssefTtUL7jfxXtOQM4hPs2DpDQX zrrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Htaf8nj6MjiG4KEbcZGpHKkGx2q6DZ1srfBF48QkivM=; b=VJ/317VSicWj/dI6tAeKFmDjzc39yrNv4MrE7D8MfbTAAS+CJBhM7e1JF2T5dgR0DF S0RLDJdYKFJ6QKZ0twfDUeJr/uxGBYorBUv+kbH17wmLBR0MZyKVTJ7NmUGNRjnqHFv0 G5MeCp2d30eRbL0xyg/EeA9WcNHMCtH1aLXHDx2cQenveOLzu09V7n2JcZxAcvRr0sjT OKxGDAJk57v0eoAkGPp/KxZpRAanr92AZPCterHv7Cg4BoHduNJUP7uuembmmJ450ZMS J37VQ9R0IUONzbfPgC6awpGZgfAIPzIwbKG+WjfuSD3EIBq9Ib0We+vnTHpvLER2sSdW odgw== X-Gm-Message-State: APjAAAWJ06NcUQqosMqMU3VoieyWOdPnU8urevHdbX+dUwVx3zC0qDhk 00MPBmwoTavCq8BH7m+L91ATgq3f X-Google-Smtp-Source: APXvYqzHe/kM3COaxI9Yrr/Gm/QB1JskHrO87yApq55Dvqon2qwYAt/vz/Ib4LbTHpDu/M6nR5uoTg== X-Received: by 2002:a1c:f21a:: with SMTP id s26mr8281204wmc.39.1582129340776; Wed, 19 Feb 2020 08:22:20 -0800 (PST) Original-Received: from lead ([2a02:8109:8ac0:2ff0:8cca:6d1d:698e:b77]) by smtp.gmail.com with ESMTPSA id f127sm429047wma.4.2020.02.19.08.22.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Feb 2020 08:22:19 -0800 (PST) In-Reply-To: <87blpvc9ek.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Wed, 19 Feb 2020 08:40:19 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176252 Archived-At: Pierre Neidhardt writes: > Thanks for looking at this, Federico! > > Your patch looks good to me, just one comment below: > >> --- a/lisp/eshell/em-dirs.el >> +++ b/lisp/eshell/em-dirs.el >> @@ -191,6 +191,9 @@ eshell-dirs-initialize >> (unless (ring-empty-p eshell-last-dir-ring) >> (expand-file-name >> (ring-ref eshell-last-dir-ring 0)))) >> + t) >> + ("INSIDE_EMACS" ,(lambda (_indices) >> + (format "%s,eshell" emacs-version)) >> t)))) > > Why did you unquote the lambda here? I need to unquote the lambda to get its value, right? Or maybe not, and I'm misunderstanding how lambdas work. I did notice though that the other lambdas in the list are unquoted. - Fede