From: Adam Porter <adam@alphapapa.net>
To: emacs-devel@gnu.org
Subject: Re: Emacs 27 face :extend attribute not working with pulse.el?
Date: Thu, 09 Apr 2020 08:18:59 -0500 [thread overview]
Message-ID: <87y2r4hk58.fsf@alphapapa.net> (raw)
In-Reply-To: 875ze8iza9.fsf@alphapapa.net
Adam Porter <adam@alphapapa.net> writes:
> Hi,
>
> I'm still using Emacs 26.3 as my main instance, but while testing
> Andrea's native-comp branch, I've also been testing Emacs 28.0.50 which,
> of course, includes the changes from Emacs 27.0.90.
>
> A while back I read on this list about the new face :extend attribute,
> how it required some changes in packages like Magit, etc. It sounded
> like the issues had been resolved, that setting the :extend attribute
> would restore previous behavior, etc.
>
> However, in my Scrollkeeper package
> (https://github.com/alphapapa/scrollkeeper.el), it does not seem to be
> working. One of the configurable guideline methods in the package uses
> pulse-momentary-highlight-oneline to highlight a line in the buffer when
> one of the scrolling commands is called (typically by setting a
> background color attribute). In Emacs 26.3, it works properly: the
> entire visual line, up to the width of the window, is highlighted. But
> in Emacs 28.0.50, even when the scrollkeeper-guideline-highlight face
> has the :extend attribute set to t, the highlighting does not extend to
> the width of the window.
>
> I think this issue may be in pulse.el, because evaluating this code has
> the same problem:
>
> (pulse-momentary-highlight-one-line (point))
After further investigation, I've found that setting ":extend t" on the
pulse-highlight-face seems to fix the problem and restore the behavior
seen in Emacs 26.3.
This seems like an obvious, easy fix to restore the previous behavior,
but I don't know if it's the "correct" one, because it appears to have
the side effect of forcing extension even when
pulse-momentary-highlight-one-line is called with a face argument which
does not have ":extend t" set.
next prev parent reply other threads:[~2020-04-09 13:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 13:06 Emacs 27 face :extend attribute not working with pulse.el? Adam Porter
2020-04-09 13:18 ` Adam Porter [this message]
2020-04-09 13:51 ` Eli Zaretskii
2020-04-09 14:46 ` Adam Porter
2020-04-09 16:46 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2r4hk58.fsf@alphapapa.net \
--to=adam@alphapapa.net \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.