From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Raffael Stocker Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: scanner Date: Fri, 10 Apr 2020 21:58:32 +0200 Message-ID: <87y2r3qfiv.fsf@mnet-mail.de> References: <871rov7dmc.fsf@mnet-mail.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="123949"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.2.0; emacs 26.3 Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 10 21:59:17 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMzo5-000WAC-IX for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Apr 2020 21:59:17 +0200 Original-Received: from localhost ([::1]:38294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMzo4-0007pJ-Kf for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Apr 2020 15:59:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35963) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMznW-0007I2-Is for emacs-devel@gnu.org; Fri, 10 Apr 2020 15:58:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jMznV-0006xg-Ci for emacs-devel@gnu.org; Fri, 10 Apr 2020 15:58:42 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.10]:51091) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jMznV-0006uo-6n for emacs-devel@gnu.org; Fri, 10 Apr 2020 15:58:41 -0400 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 48zTNG2rlXz1rsXD; Fri, 10 Apr 2020 21:58:38 +0200 (CEST) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 48zTNG2ZNbz1r0bp; Fri, 10 Apr 2020 21:58:38 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id Tr7OuqUOz9zm; Fri, 10 Apr 2020 21:58:37 +0200 (CEST) X-Auth-Info: /HxZz27L3FyKyWmpg0fYAXuEzc8UT5A/fSMiIonG6GkM/7S+Ek2geZzb5RZh0Dx2 Original-Received: from EmacsBook (ppp-93-104-88-152.dynamic.mnet-online.de [93.104.88.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 10 Apr 2020 21:58:37 +0200 (CEST) In-reply-to: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.18.0.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246799 Archived-At: Stefan Monnier writes: > Beside some technical details I had to tweak as part of the addition, > I noticed another problem: you add a submenu to the global menus (which > I guess is fine), TBH, I wasn't quite sure where to add my menu. But I'm open to better suggestions. > but some of the commands in that menu are not > autoloaded so selecting them signals an error. You should probably > "disable/grey" them until the package is loaded, or add autoloads, or > ... Thanks for spotting this, I will add autoloads. > I'm also wondering why you need all those `:key-sequence nil` in the menu. > Maybe it reflects a bug in our code? The Elisp doc says in (info "(elisp) Extended Menu Items"):=20 =E2=80=98:key-sequence nil=E2=80=99 This property indicates that there is normally no key binding which is equivalent to this menu item. Using this property saves time in preparing the menu for display, because Emacs does not need to search the keymaps for a keyboard equivalent for this menu item. I just thought this is how it's done. Raffael