From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 40808@debbugs.gnu.org, abdullah@net-c.com
Subject: bug#40808: 27.0.91; inaccuracy in isearch-lazy-count
Date: Thu, 30 Apr 2020 23:18:08 +0300 [thread overview]
Message-ID: <87y2qcsp6n.fsf@mail.linkov.net> (raw)
In-Reply-To: <874kt2586b.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 29 Apr 2020 23:56:32 +0300")
>> Fine with me, but please make this change on master, not on emacs-27.
>
> Right decision, because org-mode is broken anyway, and this fix won't make
> it better. A test case that demonstrates the problem in org-mode:
>
> 0. emacs -Q
> 1. visit emacs/etc/ORG-NEWS
> 2. isearch for "http": C-s http C-s C-s C-s ...
>
> it eventually stops at org links where "http" is invisible, such as
>
> [[https://orgmode.org/worg/library-of-babel.html][here]]
>
> The problem is that org-mode puts the text property 'invisible'
> only when the link is scrolled into view, I guess it puts the property
> using font-lock.
>
> So at least in emacs-27 now it consistently counts all matches
> ignoring their visibility.
I'm still unsure about pushing this change. The current state of things:
- in emacs-27 and master now it counts all matches, including invisible,
regardless of the value of search-invisible;
- the proposed change for master doesn't include in the count these
invisible matches that can't be visited by opening overlays;
- but this fix is pointless for org-mode where visiting invisible
matches is broken, and where its count varies after visiting
and opening hidden overlays.
next prev parent reply other threads:[~2020-04-30 20:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 6:42 bug#40808: 27.0.91; inaccuracy in isearch-lazy-count Abdullah Asad
2020-04-25 20:53 ` Juri Linkov
2020-04-28 18:46 ` Abdullah Asad
2020-04-28 19:19 ` Eli Zaretskii
2020-04-28 23:54 ` Juri Linkov
2020-04-29 7:11 ` Eli Zaretskii
2020-04-29 20:56 ` Juri Linkov
2020-04-30 20:18 ` Juri Linkov [this message]
2020-05-01 5:58 ` Eli Zaretskii
2020-05-03 22:33 ` Juri Linkov
2020-05-24 21:45 ` bug#40808: Org-mode " Juri Linkov
2020-05-25 8:49 ` Bastien
2020-08-26 12:40 ` Stefan Kangas
-- strict thread matches above, loose matches on Subject: below --
2021-07-12 1:58 bug#40808: 27.0.91; " Drew Adams
2022-07-07 17:09 ` Juri Linkov
2022-07-08 17:48 ` Juri Linkov
2022-12-10 17:51 ` Juri Linkov
2022-12-12 17:44 ` Juri Linkov
2022-12-28 18:54 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2qcsp6n.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=40808@debbugs.gnu.org \
--cc=abdullah@net-c.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.