all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Mingde (Matthew) Zeng" <matthewzmd@gmail.com>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: "Mingde \(Matthew\) Zeng" <matthewzmd@gmail.com>,
	bandali@gnu.org, emacs-devel@gnu.org
Subject: Re: [PATCHv2] erc: fix erc-reuse-buffers behavior
Date: Fri, 31 Jul 2020 10:03:29 -0400	[thread overview]
Message-ID: <87y2mz6atq.fsf@gmail.com> (raw)
In-Reply-To: <87o8o1t9w8.fsf@tcd.ie>


Thanks for the review! Addressed in my new patch.

> Can this and other occurrences of string-match be replaced with string-match-p?
My new patch only fixed the string-match that I introduced.
I did a search and found *many* string-match in the current codebase. I suggest investigate them further to see if most of them can be replaced with string-match-p in a separate commit.

> FWIW, #' is redundant on (lambda ...) in Elisp.
A new commit could be used to change all #'(lambda ...) to (lambda ...), if it's worth the hassle.

Thanks,
Matthew

--
Mingde (Matthew) Zeng



  reply	other threads:[~2020-07-31 14:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24  7:20 [PATCHv2] erc: fix erc-reuse-buffers behavior Mingde (Matthew) Zeng
2020-07-27 12:33 ` Basil L. Contovounesios
2020-07-31 14:03   ` Mingde (Matthew) Zeng [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-08-11 18:53 Mingde (Matthew) Zeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2mz6atq.fsf@gmail.com \
    --to=matthewzmd@gmail.com \
    --cc=bandali@gnu.org \
    --cc=contovob@tcd.ie \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.