From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43386: 27.1; Regression in `report-emacs-bug' Date: Mon, 14 Sep 2020 18:15:01 +0200 Message-ID: <87y2lcs5bu.fsf@gnus.org> References: <9713a95e-00f8-401c-be0f-3d54ad32ee55@default> <874ko1fejh.fsf@gnus.org> <846c2fb0-2b87-4073-a30f-e3eb61217909@default> <878sdddyba.fsf@gnus.org> <6abf2cf3-8105-4f8c-be98-dcbe5fd854f3@default> <874ko1dxdc.fsf@gnus.org> <831rj4be24.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3918"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43386@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 14 19:28:47 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHsHX-0000v1-FP for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Sep 2020 19:28:47 +0200 Original-Received: from localhost ([::1]:45766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHsHW-00033J-H7 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Sep 2020 13:28:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57634) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHr9A-0004Jc-Ee for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2020 12:16:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44478) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHr98-0004JA-Nd for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2020 12:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHr98-0000Fe-Jp for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2020 12:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Sep 2020 16:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43386 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 43386-submit@debbugs.gnu.org id=B43386.1600100114899 (code B ref 43386); Mon, 14 Sep 2020 16:16:02 +0000 Original-Received: (at 43386) by debbugs.gnu.org; 14 Sep 2020 16:15:14 +0000 Original-Received: from localhost ([127.0.0.1]:56024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHr8M-0000ER-Hh for submit@debbugs.gnu.org; Mon, 14 Sep 2020 12:15:14 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:32910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHr8K-0000EE-NT for 43386@debbugs.gnu.org; Mon, 14 Sep 2020 12:15:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tt6ppjBviVWKuoUNH/JpUL5H8Df/H1dq/S3qzqNgCT0=; b=UTitO50hHz1bQCeKEgR61/2ttI l7qBxWRAYHC8Uk7L5t2lTmXIlVCoSBh/IdudjrAZcmgv+Ww5ojwn/JK/CmuSXYUxB/xyYKdPz9cCM Ua2gCGG3XBseSTkuzZXZmi/sQqwrHQiaN6UoO9qrvDkg8x0cMUoCPPpTmDO3bgK3PuTg=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHr8B-0003NX-7j; Mon, 14 Sep 2020 18:15:05 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEU5OVBPa6ESDxP/ //+1cIoRAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+QJDg8jB4dfQ4kAAAGmSURBVCjPLZIxa+NAEIVH izcYVU7wpnClCC745leE44qgSiwac6S/Rr9CEbYxKlOkXokYxu9X3my4bZaPeW+H9yTynZSUT0uO XD0gn5M0ROXFv2YQiYn4XaICN5HDQBikQ8IsIhm6wMong0SgjTSYgkFlUEg07X/wZsoW2X+D9Nki NaHy4tZBKBgo+TjO0hmA9ME3n1d5Id+BbnfEZy9kApt0pAgdUehB2BI4vBjAAGNqMrQMYoxzDETF K+fJonFjSVGCnAXbho3dowFb5E1LpSaQmSq/3RacYQvo/TF0eExsRuDyI0TdTUxOS+Dp770JSht8 AD9/i4Ez+OSJl2iCbHmcdNL1k7BVpQeAcfqTG8XtgAVLaEPu7fkAZ1W1vrN2nBxRdqH1UWkcinra SGjef4GmY1618q5yoJRBLc/eYtsTpZ5W9lUMKrbLEy91niwl0tE5W2wdJCT3ZQBF9g2DRmUo52y1 8p11Mz7QyBfG7jqOmBItu2XuzzPnf4Gas57e0q3/hvZZw9sN/YKCaWX72zXbGmtq2VfXZsmqqaFU 1PMevT09x38EednopTs0ZQAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0wOS0xNFQxNTozNTowNysw MDowMLsEvUUAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMDktMTRUMTU6MzU6MDcrMDA6MDDKWQX5 AAAAAElFTkSuQmCC X-Now-Playing: Matmos's _Plastic Anniversary_: "Collapse Of The Fourth Kingdom" In-Reply-To: <831rj4be24.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 14 Sep 2020 17:58:27 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188076 Archived-At: Eli Zaretskii writes: > The call to sendmail-query-user-about-smtp is the one that asks about > how to send, and allows to select mailclient. But the conditions to > call it are false, and the rest is history. Yes, it's due to commit 3a59cc84069376802ba8fd731b524d78db58262c Author: Stefan Monnier AuthorDate: Tue Jul 30 16:37:01 2019 -0400 * lisp/gnus/message.el: Reduce redundancy with send-mail-function which changed the default of message-send-mail-function. However, even with that fixed, the code there is misguided. emacsbug queries for the method: (when (or (and (derived-mode-p 'message-mode) (eq message-send-mail-function 'sendmail-query-once)) (and (not (derived-mode-p 'message-mode)) (eq send-mail-function 'sendmail-query-once))) (sendmail-query-user-about-smtp) but doesn't do anything with it -- sendmail-query-user-about-smtp just returns a function. This is how that function is supposed to be used: (defun sendmail-query-once () "Query for `send-mail-function' and send mail with it. This also saves the value of `send-mail-function' via Customize." ;; If send-mail-function is already setup, we're incorrectly called ;; a second time, probably because someone's using an old value ;; of send-mail-function. (if (not (eq send-mail-function #'sendmail-query-once)) (funcall send-mail-function) (let ((function (sendmail-query-user-about-smtp))) (funcall function) (when (y-or-n-p "Save this mail sending choice?") (setq send-mail-function function) (customize-save-variable 'send-mail-function function))))) Notice that we offer to set it -- after we've seen that the user can send successfully, which we can't do from that hook. So to make this work sensibly requires some refactoring of the code. I'll have a look at it tomorrowish. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no