From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#42966: 28.0.50; vc-dir: wrong backend Date: Sat, 24 Oct 2020 15:41:38 +0200 Message-ID: <87y2jvwxkd.fsf@gmx.de> References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> <875z79z5mw.fsf@gnus.org> <52df0404-979f-872b-a60e-5259c0893f15@yandex.ru> <87wnzonful.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26637"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Sam Steingold , 42966@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 24 15:42:39 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kWJod-0006rx-Kw for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Oct 2020 15:42:39 +0200 Original-Received: from localhost ([::1]:39692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWJoc-0001Wj-He for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Oct 2020 09:42:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWJo2-0001Wd-BW for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2020 09:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49661) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kWJo2-0007ap-18 for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2020 09:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kWJo1-0007hi-VR for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2020 09:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Oct 2020 13:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs Original-Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160354691129596 (code B ref 42966); Sat, 24 Oct 2020 13:42:01 +0000 Original-Received: (at 42966) by debbugs.gnu.org; 24 Oct 2020 13:41:51 +0000 Original-Received: from localhost ([127.0.0.1]:32974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWJnr-0007hH-Fl for submit@debbugs.gnu.org; Sat, 24 Oct 2020 09:41:51 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:41241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWJno-0007h2-Ez for 42966@debbugs.gnu.org; Sat, 24 Oct 2020 09:41:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603546901; bh=3gtweTNjb6kWW0WHIAgEH7t6OZwzdCUPcamMaSJ6a28=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=ku4WpHyeNKgzGtpXL/2EVjB9HWX5lC2Y0kIc/Lto8DtdPOWxjZcqlQye71vJMbwfG nNF4jTc8ZxxbGOibnKf1UIiF9sli/7yg5Nx5OrGLVVomUXgW7JNpq27sPehDwGUuie VC5g6A5KzKA31izTF55im5mGGs6GHIJypi3cSi1U= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.86.54.44]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MJVHU-1kqB4P2ZeS-00JqOQ; Sat, 24 Oct 2020 15:41:41 +0200 In-Reply-To: (Dmitry Gutov's message of "Sat, 24 Oct 2020 02:53:35 +0300") X-Provags-ID: V03:K1:cYfYIVPzWF4o8MY4M0UFlADT4YNFnaWyXXSogseVqUfBwz9BL5e bDrjVC6y13wKLcJ1LJk6tO6jnmsSZ+vkAN6mQ79JnioIWZQ9USq1LMtiF97gWnGRbjsseFH 3YL62H9tCebQFtbrQVfbYk5oqmmXzHjSpTM6j+vcXd+9nnyFf9bg/Y7z1C0EDjE1JWJarff kzlmurGiFpwlerzNOIQ/g== X-UI-Out-Filterresults: notjunk:1;V03:K0:31AwNA3xtKY=:hFW/42XOOj+/wTf3u47ihr CJwHObKgQVuFhHg5dyH8FfOkXo8QVJTfRFJzQScG//GONf9ng6HQ/V9ueCUlAe1o/PzOSf/Hb z5dNyZndIR9/m/cYs5QNqEoAGzn5FyzbquiqEwH9TrTbm5FzYqHw+T87w5c5r2g3mX4eFSyeI ROmXhYmyIaHEz76T/6/1Q+Hr2cFO2+iUAxqf+/1Qq2U2TkaPV5/Xmlk9KO3QHJLMOzFwWQEzY iPL6owW+Y9ku/LEqkc01ZdgWYCfUGib8jKMPUh9dcVsd1AZBtSxLBQ8GVBYLS8Jh/GEOkF3vs M0gCTQdYLaUKLGptskXiTkPIAwMkitnBR5NIJDmtFtSRWnLdEwBCXOxJfPbwWJdkSHChu3Qdp h17hO6yv4h3suR33uUIr9IKJtJnvqNjDrrMnR+w1EUe2WtShupmfJaNfgQUMrT9xgngRhvTkM 0hzrBDScA8VQxi3werAqPMIK6tLmUMp79xj5UO1FD4wRBA8OsGTjbBLqfzX5RIragralQhkn6 TN5ECxMHmwcYKN9AsMGcfAon73aSxh65Mu5BvRPiry04/8ItqxvXOzJE150PtMUVAq+x2ep8+ 4+uk859ijsUKnFIltsLnXAzXf20REls2aVLN02RLXRATxge6TsuygYp2u+TVubY6l4nfsSpl4 aRhZqQIOwVXC5n5wbDUihNHFju3ssJn+rYDJYI8CNxZnOmzw+R30mqmSw7o98SwF5cPUn1Oun b3bTE5yA1ID0aIelGRcHmfb69WS6fN2qlGhVK6cevC+3qjyuPQW45orKGlQ4MepR1lDhAFGi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191426 Archived-At: Dmitry Gutov writes: > Hi Michael, Hi Dmitry, > Not in Tramp, but I see an old change in VC that was most likely > informed by a performance problem in Tramp. > > See the commit a40c87a0093. It adds caching of the result of > vc-git-root to a VC property 'git-root' on the file name. This seems to be bug#11757. > Does the change below still make some scenario perceptibly slower? > > diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el > index b1880c0f7b..91554bb6d8 100644 > --- a/lisp/vc/vc-git.el > +++ b/lisp/vc/vc-git.el > @@ -1573,8 +1573,7 @@ vc-git-extra-menu > (defun vc-git-extra-status-menu () vc-git-extra-menu-map) > > (defun vc-git-root (file) > - (or (vc-file-getprop file 'git-root) > - (vc-file-setprop file 'git-root (vc-find-root file ".git")))) > + (vc-find-root file ".git")) > > ;; grep-compute-defaults autoloads grep. > (declare-function grep-read-regexp "grep" ()) I haven't tested. But this means to call process-file several times, it would be a performance degradation, for sure. Best regards, Michael.