From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45539: 26.3; `add-to-ordered-list': Add optional arg for :test predicate for hash table Date: Wed, 30 Dec 2020 04:48:19 +0100 Message-ID: <87y2hgosxo.fsf@gnus.org> References: <1af7f2ac-0e6c-4c8a-860b-22148265d8aa@default> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14909"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45539@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 30 04:49:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuSU1-0003WL-O5 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Dec 2020 04:49:09 +0100 Original-Received: from localhost ([::1]:52876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuSU0-0000Nh-Q6 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Dec 2020 22:49:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuSTt-0000NX-V3 for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 22:49:01 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57355) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kuSTt-0000MV-Nt for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 22:49:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kuSTt-0004Ja-Lo for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 22:49:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Dec 2020 03:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45539 X-GNU-PR-Package: emacs Original-Received: via spool by 45539-submit@debbugs.gnu.org id=B45539.160930011916543 (code B ref 45539); Wed, 30 Dec 2020 03:49:01 +0000 Original-Received: (at 45539) by debbugs.gnu.org; 30 Dec 2020 03:48:39 +0000 Original-Received: from localhost ([127.0.0.1]:40665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuSTX-0004Il-1Z for submit@debbugs.gnu.org; Tue, 29 Dec 2020 22:48:39 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:32796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuSTU-0004IW-8B for 45539@debbugs.gnu.org; Tue, 29 Dec 2020 22:48:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xZk0QuIQsWzx/VD/eyyFOy/ub4rCZ9CQIZt2nukvXv4=; b=lcJMUSxyt4iz2HNR59QNUz0d7d nbbOnqOM01ZSUFs7dWa8F5pA5+XpZ2nsgc9+lJUxDdzLFUetBeyndmcs4O8J1BWK/d7a+D0B4L0Gk 8jeEyOBKcP8VjBpq9Gvy/2s7yNIjH/rwcEp4tkCz9YUzjzDFzJPM301cIqyyE5rhaWzY=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuSTE-0001g4-AY; Wed, 30 Dec 2020 04:48:29 +0100 X-Now-Playing: Simon & Garfunkel's _The Concert In Central Park_: "April Come She Will" In-Reply-To: <1af7f2ac-0e6c-4c8a-860b-22148265d8aa@default> (Drew Adams's message of "Tue, 29 Dec 2020 13:04:44 -0800 (PST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197002 Archived-At: Drew Adams writes: > Please consider adding an optional arg TEST-PREDICATE, which will be > passed to the hash table (and which will default to `eq'). Since the ordering is hard-coded to `<', allowing the things being compared are presumably all numbers, so allowing specifying the comparison function doesn't make much sense. However, using `eq' for numbers doesn't make much sense, either -- `eql' would be better. Looking at the in-tree usages, switching to `eql' shouldn't make much difference, so I've done the daring thing and switched to `eql'. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no