all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "J.P." <jp@neverwas.me>
Cc: 45162@debbugs.gnu.org
Subject: bug#45162: [PATCH] Fixup Re: bug#45162: 28.0.50; Messages scrambled by socks-filter
Date: Thu, 07 Jan 2021 13:44:59 +0100	[thread overview]
Message-ID: <87y2h4ykz8.fsf@gnus.org> (raw)
In-Reply-To: <87pn2ht4pk.fsf_-_@neverwas.me> (J. P.'s message of "Thu, 07 Jan 2021 02:35:19 -0800")

"J.P." <jp@neverwas.me> writes:

> In a boneheaded oversight, I neglected to reset the "scratch" work area
> after functions performing the SOCKS5 authentication subprotocol are
> through with it.
>
> This is a one-line follow-up that hopefully corrects that. Please see
> the included test, which passes after this tweak is applied.

Thanks; I've now applied the fix to Emacs 28, but not the test (because
the amount of code would require a copyright assignment).

I forgot whether I've asked before -- would you be willing to sign such
paperwork?  If so, reworking that test into an ert-deftest would be
nice.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2021-01-07 12:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10 13:02 bug#45162: 28.0.50; Messages scrambled by socks-filter J.P.
2020-12-11 15:37 ` Lars Ingebrigtsen
2020-12-11 22:01   ` J.P.
2020-12-11 22:06     ` Lars Ingebrigtsen
2021-01-07 10:35   ` bug#45162: [PATCH] Fixup " J.P.
2021-01-07 12:44     ` Lars Ingebrigtsen [this message]
2021-01-07 22:51       ` J.P.
2021-01-09 14:16       ` J.P.
2021-01-10 11:41         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2h4ykz8.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=45162@debbugs.gnu.org \
    --cc=jp@neverwas.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.