From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master 1559cc4: Fix missing file&line info in "Unknown defun property" warnings Date: Sat, 23 Jan 2021 22:20:00 +0000 Message-ID: <87y2gjz46n.fsf@tcd.ie> References: <20210123210445.12536.65283@vcs0.savannah.gnu.org> <20210123210447.45FA120AD1@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23555"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 23 23:21:23 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3RHX-00061J-1z for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 23:21:23 +0100 Original-Received: from localhost ([::1]:40372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3RHW-0006sn-3T for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 17:21:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54516) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3RGL-0005vq-VN for emacs-devel@gnu.org; Sat, 23 Jan 2021 17:20:09 -0500 Original-Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:40952) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3RGJ-0003q0-AA for emacs-devel@gnu.org; Sat, 23 Jan 2021 17:20:09 -0500 Original-Received: by mail-wm1-x32b.google.com with SMTP id c127so7461550wmf.5 for ; Sat, 23 Jan 2021 14:20:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ybqlnBtIlqKLMvm1vdK6x6MAwqoM5uZygIUH+cpyp2M=; b=pBd1mVLByOlD5GfefgLS9yS3OMSIcnRpivfu5DNOoCU6t5KGUGLsUUoxHARYu+OV8f EF/NBsX6uE9GPbBFl9zuUo/MQxF0wUXavyNfXxwdSzFhCX7LYDcZ5q2mxmjY7ugb4ur8 /m6EcdMn+giQEWmaDnsygzohh1bqfcxPmHlabPILRLT+Bf95zALg/6PLLb1+IwWuaLHL bRJbOqlkFsQdSan/qrVufT9caRwUFzQQjD8G1awXuzLD/T3W+CAeHKp2T8MSjMOUpYgZ QhTOnPX5HbnD2ZiCHJh3W/95w4JHreDGV+vwObIrGWW+m/ixTxBwV3Pp2+bbyLhBVhoR 7kJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ybqlnBtIlqKLMvm1vdK6x6MAwqoM5uZygIUH+cpyp2M=; b=MTN2+fOPCCRVS503By9wL+sOug3sfns7bcIrGq8KWs8UQWClrr7NNDjWeHY4uqrQq4 7smUjE6j2d3gBlG0rhKJyTS/Xz7bsqqSKWTFu239UP+eN5nhXHhxNdruIK/MjvQHEPaW 4PtoOhqF+xGMe0SI+HIZg2GO/WlTgHAfXNknpv0JV1n6k6DMNUa6P2sYo0HPCa4BDFtl 02z6bTx4Clq59SBPaGQ+SMCO/bbgC/6jPy9JYoskhuIvinz1HRNyo5+9w2efkSG5N623 Bl5onohhGwDMoDL9lvYG/vmdNK2oArUoQu8h7AK3RG6m4jcW4NZPUDg1H8pJN44jTziL GFjg== X-Gm-Message-State: AOAM531pePyyQa5thRy9ecajGaR8NkHAs337tCD9kFWsrPOAjSDPh5IS ArtvfFV66KpHtul2h+cD9Zmwm8iG+RBvYw5Z X-Google-Smtp-Source: ABdhPJx29D/M+u0NjfB9fa/cbX+77XY6AlRfpQPKuMnlrDQs2QdQpxZ4CiDBa1BhXN7+BATs+EwVOA== X-Received: by 2002:a7b:c415:: with SMTP id k21mr1274851wmi.96.1611440402506; Sat, 23 Jan 2021 14:20:02 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id h1sm13928620wrr.73.2021.01.23.14.20.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Jan 2021 14:20:01 -0800 (PST) In-Reply-To: <20210123210447.45FA120AD1@vcs0.savannah.gnu.org> (Stefan Monnier's message of "Sat, 23 Jan 2021 16:04:46 -0500 (EST)") Received-SPF: none client-ip=2a00:1450:4864:20::32b; envelope-from=contovob@tcd.ie; helo=mail-wm1-x32b.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263324 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable monnier@iro.umontreal.ca (Stefan Monnier) writes: > branch: master > commit 1559cc445a306b61b2a47c710e049ea26fe5265d > Author: Stefan Monnier > Commit: Stefan Monnier > > Fix missing file&line info in "Unknown defun property" warnings >=20=20=20=20=20 > * lisp/emacs-lisp/byte-run.el (defmacro, defun): Use > `macroexp--warn-and-return` rather than `message`. >=20=20=20=20=20 > * lisp/emacs-lisp/macroexp.el: Fix `macroexp--compiling-p`. > (macroexp--warn-and-return): Don't try and detect repetition on forms > like `nil`. > (macroexp-macroexpand): Don't forget to bind `macroexpand-all-environ= ment`. This gave rise to the following 'make check' failures: --8<---------------cut here---------------start------------->8--- Test cl-lib-defstruct-record passed unexpectedly Ran 47 tests, 46 results as expected, 1 unexpected (2021-01-23 22:05:59+000= 0, 0.052134 sec) 1 expected failures 1 unexpected results: PASSED cl-lib-defstruct-record lisp/emacs-lisp/seq-tests.el:416:41: Error: =E2=80=98add-to-list=E2=80=99 c= an=E2=80=99t use lexical var =E2=80=98elts=E2=80=99; use =E2=80=98push=E2=80=99 or =E2=80=98cl-p= ushnew=E2=80=99 In toplevel form: lisp/autorevert-tests.el:642:24: Error: =E2=80=98add-to-list=E2=80=99 can= =E2=80=99t use lexical var =E2=80=98buffers=E2=80=99; use =E2=80=98push=E2=80=99 or =E2=80=98cl-pu= shnew=E2=80=99 lisp/autorevert-tests.el:657:15: Error: =E2=80=98add-to-list=E2=80=99 can= =E2=80=99t use lexical var =E2=80=98buffers=E2=80=99; use =E2=80=98push=E2=80=99 or =E2=80=98cl-pu= shnew=E2=80=99 --8<---------------cut here---------------end--------------->8--- Are the attached changes TRT, or is there something subtle going on? Thanks, --=20 Basil --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=check.diff diff --git a/test/lisp/autorevert-tests.el b/test/lisp/autorevert-tests.el index 683e3ea30d..19d9f7b13f 100644 --- a/test/lisp/autorevert-tests.el +++ b/test/lisp/autorevert-tests.el @@ -609,11 +609,12 @@ auto-revert-test07-auto-revert-several-buffers (should auto-revert-mode)) (dotimes (i num-buffers) - (add-to-list - 'buffers - (make-indirect-buffer - (car buffers) (format "%s-%d" (buffer-file-name (car buffers)) i) 'clone) - 'append)) + (let ((buf (make-indirect-buffer + (car buffers) + (format "%s-%d" (buffer-file-name (car buffers)) i) + 'clone))) + (unless (memq buf buffers) + (setq buffers (nconc buffers (list buf)))))) (dolist (buf buffers) (with-current-buffer buf (should (string-equal (buffer-string) "any text")) @@ -640,10 +641,10 @@ auto-revert-test07-auto-revert-several-buffers (auto-revert-tests--write-file "any text" tmpfile (pop times)) (dotimes (i num-buffers) - (add-to-list - 'buffers - (generate-new-buffer (format "%s-%d" (file-name-nondirectory tmpfile) i)) - 'append)) + (let ((buf (generate-new-buffer + (format "%s-%d" (file-name-nondirectory tmpfile) i)))) + (unless (memq buf buffers) + (setq buffers (nconc buffers (list buf)))))) (dolist (buf buffers) (with-current-buffer buf (insert-file-contents tmpfile 'visit) diff --git a/test/lisp/emacs-lisp/cl-lib-tests.el b/test/lisp/emacs-lisp/cl-lib-tests.el index 97a44c43ef..888af1b80a 100644 --- a/test/lisp/emacs-lisp/cl-lib-tests.el +++ b/test/lisp/emacs-lisp/cl-lib-tests.el @@ -548,10 +548,10 @@ cl-lib-tests--dummy-function t) (ert-deftest cl-lib-defstruct-record () - ;; This test fails when compiled, see Bug#24402/27718. - :expected-result (if (byte-code-function-p - (symbol-function 'cl-lib-tests--dummy-function)) - :failed :passed) + ;; This test used to fail when compiled, see Bug#24402/27718. + ;; :expected-result (if (byte-code-function-p + ;; (symbol-function 'cl-lib-tests--dummy-function)) + ;; :failed :passed) (cl-defstruct foo x) (let ((x (make-foo :x 42))) (should (recordp x)) @@ -566,6 +566,7 @@ old-struct (should (eq (type-of x) 'vector)) (cl-old-struct-compat-mode 1) + (defvar cl-struct-foo) (let ((cl-struct-foo (cl--struct-get-class 'foo))) (setf (symbol-function 'cl-struct-foo) :quick-object-witness-check) (should (eq (type-of x) 'foo)) diff --git a/test/lisp/emacs-lisp/seq-tests.el b/test/lisp/emacs-lisp/seq-tests.el index 670398354a..f1dfc24b3f 100644 --- a/test/lisp/emacs-lisp/seq-tests.el +++ b/test/lisp/emacs-lisp/seq-tests.el @@ -108,16 +108,12 @@ test-seq-map-indexed '((a 0) (b 1) (c 2) (d 3))))) (ert-deftest test-seq-do-indexed () - (let ((result nil)) - (seq-do-indexed (lambda (elt i) - (add-to-list 'result (list elt i))) - nil) - (should (equal result nil))) + (let (result) + (seq-do-indexed (lambda (elt i) (push (list elt i) result)) ()) + (should-not result)) (with-test-sequences (seq '(4 5 6)) - (let ((result nil)) - (seq-do-indexed (lambda (elt i) - (add-to-list 'result (list elt i))) - seq) + (let (result) + (seq-do-indexed (lambda (elt i) (push (list elt i) result)) seq) (should (equal (seq-elt result 0) '(6 2))) (should (equal (seq-elt result 1) '(5 1))) (should (equal (seq-elt result 2) '(4 0)))))) @@ -410,12 +406,11 @@ test-seq-sort-by (ert-deftest test-seq-random-elt-take-all () (let ((seq '(a b c d e)) - (elts '())) - (should (= 0 (length elts))) + elts) (dotimes (_ 1000) (let ((random-elt (seq-random-elt seq))) - (add-to-list 'elts - random-elt))) + (or (memq random-elt elts) + (push random-elt elts)))) (should (= 5 (length elts))))) (ert-deftest test-seq-random-elt-signal-on-empty () --=-=-=--